Re: [Buildroot] [PATCH v2 3/4] package/fail2ban: bump version to 1.1.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fiona,

On Tue, 9 Jul 2024 12:19:49 +0200
Fiona Klute <fiona.klute@gmx.de> wrote:

> >> -FAIL2BAN_VERSION = 1.0.2
> >> +FAIL2BAN_VERSION = 1.1.0
> >>   FAIL2BAN_SITE = $(call github,fail2ban,fail2ban,$(FAIL2BAN_VERSION))
> >>   FAIL2BAN_LICENSE = GPL-2.0+
> >>   FAIL2BAN_LICENSE_FILES = COPYING
> >>   FAIL2BAN_CPE_ID_VENDOR = fail2ban
> >>   FAIL2BAN_SELINUX_MODULES = fail2ban
> >>   FAIL2BAN_SETUP_TYPE = setuptools
> >> +FAIL2BAN_DEPENDENCIES = host-python3 python-pyasynchat  
> >
> > Why are you adding host-python3 in the dependencies here?  
> 
> I saw a build failure because host Python hadn't been built before
> without it. I now suspect that was the result of adding a runtime-only
> dependency to build-time dependencies (see below), I guess it broke some
> implicit dependency handling? After completely removing that line the
> build passes, too.

Adding a runtime dependency to build-time dependencies cannot break
dependency handling. It just enforces a "strong" dependency that
doesn't exist, but it clearly cannot be responsible for a build
failure. So it looks like we haven't figured out why the build was at
some point failing for you.

A good practice when testing a package:

$ make clean
$ ./utils/docker-run make fail2ban

This will only build fail2ban and its build dependencies, and nothing
else. This will therefore make sure that you properly captured all
dependencies. And it does so in a minimal docker container, to ensure
no tools from your host machine are used.

> > Also, are you sure python-pyasynchat is a build time dependency, and
> > not just a runtime dependency? If that's the case, then you need to
> > kept the select in the Config.in file (with a comment # runtime), but
> > not have it as a build-time dependency in fail2ban.mk.  
> 
> That's indeed a runtime dependency.
> 
> Thanks for the review! I've just sent an updated version of the series
> with the runtime comment added and the build time dependency removed. If
> it's good to merge now, please keep in mind that it's only going to fix
> the fail2ban build if merged after Angelo's fixes to the config file
> handling (linked in the cover letter).

ACK, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot