Re: [Buildroot] [PATCH v2 3/4] package/fail2ban: bump version to 1.1.0

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	Fiona Klute via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2 3/4] package/fail2ban: bump version to 1.1.0
Date: Wed, 10 Jul 2024 13:47:19 +0200	[thread overview]
Message-ID: <20240710134719.5b84b352@windsurf> (raw)
In-Reply-To: <e3604bce-6189-4cef-a0f2-19257f66ebf1@gmx.de>

Hello Fiona,

On Wed, 10 Jul 2024 13:17:58 +0200
Fiona Klute <fiona.klute@gmx.de> wrote:

> If you just use a fresh defconfig, yes, but that doesn't quite work for
> fail2ban (there isn't one that enables it, it needs Python, and I'd like
> to build with musl to match my target). I guess it'd be easy enough to
> create a snippet with the required config, append it after defconfig,
> and run "make oldconfig".
> 
> But then I still wouldn't get to reuse BR2_DL_DIR (though
> utils/docker-run can use that from environment) and the CCache setup.

Not sure what's the problem here. Here is another example, where I
start from a simple config for an ARMv7 toolchain:

$ mkdir /tmp/foo
$ cp ~/buildroot/support/config-fragments/autobuild/bootlin-armv7-glibc.config .config
$ ~/buildroot/utils/docker-run make -C ~/buildroot O=$(pwd) menuconfig

enable BR2_PACKAGE_PYTHON3=y and BR2_PACKAGE_FAIL2BAN=y in menuconfig, exit

$ ~/buildroot/utils/docker-run make

and that's it. No need to have an existing defconfig.

Regarding BR2_DL_DIR: it re-uses the one defined in your environment
outside the docker container, so it just works. Regarding BR2_CCACHE,
you can set the option in menuconfig, but indeed it wouldn't re-use the
cache that's available outside the container.

> I could use a defconfig from my external tree, but then I'd need to get
> utils/docker-run to mount it. That might actually be an option: Make
> utils/docker-run honor BR2_EXTERNAL the same way it does BR2_DL_DIR.
> Would such a patch be welcome? If yes I'm going to give it a try.

See above: you don't need an existing defconfig to test things.

However, it would indeed perhaps make sense for docker-run to mount
BR2_EXTERNAL trees inside the container.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot