[Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

[Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

[Athaariq Ardhiansyah]

Latest RPi firmware already provided support for Raspberry Pi 5.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue

Changes v2 -> v4:
  - Change back from commit ID to commit tag

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
---
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index 4501db739c..5dc6efd8b3 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  00fe5487376e9d5ed14cbc72a9b7a5bd8d6900c84aee10f6d656f192a26d161c  rpi-firmware-5476720d52cf579dc1627715262b30ba1242525e.tar.gz
+sha256  48d0b1b041bf77dc81d7ed04c423a7f4ce0afd0e3fbea26462309e738b89a552  rpi-firmware-1.20240529.tar.gz
 sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 7ae9ff6c28..81066f0fc0 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 5476720d52cf579dc1627715262b30ba1242525e
+RPI_FIRMWARE_VERSION = 1.20240529
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v4 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)

[Athaariq Ardhiansyah]

Latest raspberrypi-usbboot package has Raspberry Pi 5 support. It is
considerably matured at commit 4a3d31171769f87d919340778e5aaeaba01e10b5.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue
  - Use the latest commit instead of the latest tag

Changes v2 -> v3:
  - Update the commit title
  - Add more explanation on commit description

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
---
 ...akefile-allow-passing-CFLAGS-LDFLAGS.patch | 27 +++++++++----------
 .../raspberrypi-usbboot.hash                  |  2 +-
 .../raspberrypi-usbboot.mk                    |  2 +-
 3 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
index 29a9311651..ea53f8360a 100644
--- a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
+++ b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
@@ -1,31 +1,28 @@
-From acd175aa53af1f1b8422bf1f1fe57eafc710cdca Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Fri, 2 Dec 2016 23:09:44 +0100
+From e09c92d68efa4efbd48a3366f9053a4f8c275091 Mon Sep 17 00:00:00 2001
+From: Athaariq Ardhiansyah <foss@athaariq.my.id>
+Date: Mon, 3 Jun 2024 15:35:49 +0700
 Subject: [PATCH] Makefile: allow passing CFLAGS/LDFLAGS
 
-This might be needed to pass some custom CFLAGS/LDFLAGS when building
-rpiboot.
+This might be needed to pass some custom CFLAGS/LDFLAGS when building rpiboot.
 
 Submitted-upstream: https://github.com/raspberrypi/usbboot/pull/2
 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-[Rebased on 9324fd7]
 Signed-off-by: Peter Seiderer <ps.report@gmx.net>
-[Rebased on 20221215-105525-0-g1afa26c5]
-Signed-off-by: Fiona Klute <fiona.klute+wiwa@gmx.de>
+Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
 ---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/Makefile b/Makefile
-index dc78cfe..c9d4910 100755
+index 4479b1b..076ae43 100755
 --- a/Makefile
 +++ b/Makefile
-@@ -1,7 +1,7 @@
- PKG_VER=$(shell grep rpiboot debian/changelog | head -n1 | sed 's/.*(\(.*\)).*/\1/g')
- GIT_VER=$(shell git rev-parse HEAD 2>/dev/null | cut -c1-8 || echo "")
- rpiboot: main.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
--	$(CC) -Wall -Wextra -g -o $@ $< `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\""
-+	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ $< `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" $(LDFLAGS)
+@@ -3,7 +3,7 @@ GIT_VER=$(shell git rev-parse HEAD 2>/dev/null | cut -c1-8 || echo "")
+ INSTALL_PREFIX?=/usr
+ 
+ rpiboot: main.c bootfiles.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
+-	$(CC) -Wall -Wextra -g -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\"
++	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\" $(LDFLAGS)
  
  %.h: %.bin ./bin2c
  	./bin2c $< $@
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
index 830ead8243..1a183bf47f 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha256  2f02dbe9a88e9dfad5f05e513e1f30afd47b1575820f7c3b09665dfefc45bbaa  raspberrypi-usbboot-20221215-105525.tar.gz
+sha256  2182a6bf5ca9cd54ee3bca2d7667758ceac685fa78a3a6ae663762bde03e781a  raspberrypi-usbboot-4a3d31171769f87d919340778e5aaeaba01e10b5.tar.gz
 
 # License files
 sha256  b40930bbcf80744c86c46a12bc9da056641d722716c378f5659b9e555ef833e1  LICENSE
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
index 24a1f6d906..7eef7df600 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RASPBERRYPI_USBBOOT_VERSION = 20221215-105525
+RASPBERRYPI_USBBOOT_VERSION = 4a3d31171769f87d919340778e5aaeaba01e10b5
 RASPBERRYPI_USBBOOT_SITE = \
 	$(call github,raspberrypi,usbboot,$(RASPBERRYPI_USBBOOT_VERSION))
 RASPBERRYPI_USBBOOT_LICENSE = Apache-2.0
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)

[Thomas Petazzoni via buildroot]

Hello,

On Sun, 14 Jul 2024 23:04:53 +0700
Athaariq Ardhiansyah <foss@athaariq.my.id> wrote:

> diff --git a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
> index 29a9311651..ea53f8360a 100644
> --- a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
> +++ b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
> @@ -1,31 +1,28 @@
> -From acd175aa53af1f1b8422bf1f1fe57eafc710cdca Mon Sep 17 00:00:00 2001
> -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -Date: Fri, 2 Dec 2016 23:09:44 +0100
> +From e09c92d68efa4efbd48a3366f9053a4f8c275091 Mon Sep 17 00:00:00 2001
> +From: Athaariq Ardhiansyah <foss@athaariq.my.id>
> +Date: Mon, 3 Jun 2024 15:35:49 +0700
>  Subject: [PATCH] Makefile: allow passing CFLAGS/LDFLAGS

Please don't change the author of existing patches.

>  
> -This might be needed to pass some custom CFLAGS/LDFLAGS when building
> -rpiboot.
> +This might be needed to pass some custom CFLAGS/LDFLAGS when building rpiboot.

This change is spurious.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v4 3/3] board/raspberrypi: add support for Raspberry Pi 5

[Athaariq Ardhiansyah]

Since the last Raspberry Pi 5 submission has no progress, I'm submitting
these patches anyway. The newly released Raspberry Pi 5 board shares
similar software structure except it has less proprietary API.
Therefore, rpi-userland and all of raspberry-centric GPIO utilities are
no longer supported.

Keep in mind that RPi 5 has no native 32-bit support due to Cortex-A76
processor specification. That is the reason why I did not add _64.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing newlines due to terminal issue

Changes v3 -> v4:
  - Rebase to master
  - Drop 4K page size, until we figured out how to run 32bit userspace
    on top of 64bit kernel
  - Change back from commit ID to commit tag
  - Rewrite the commit description
  - Fix incorrect CPU from upstream config, RPi5 has no LITTLE.big

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
---
 board/raspberrypi/config_5.txt                | 42 +++++++++++++++++++
 .../patches/linux-headers/linux-headers.hash  |  1 -
 board/raspberrypi/patches/linux/linux.hash    |  2 +-
 configs/raspberrypi5_defconfig                | 17 ++++----
 4 files changed, 50 insertions(+), 12 deletions(-)
 delete mode 120000 board/raspberrypi/patches/linux-headers/linux-headers.hash

diff --git a/board/raspberrypi/config_5.txt b/board/raspberrypi/config_5.txt
index bbed19fe46..738c2198c8 100644
--- a/board/raspberrypi/config_5.txt
+++ b/board/raspberrypi/config_5.txt
@@ -9,6 +9,48 @@ kernel=Image
 # To use an external initramfs file
 #initramfs rootfs.cpio.gz
 
+# Automatically load initramfs files, if found
+auto_initramfs=1
+
+# Uncomment some or all of these to enable the optional hardware interfaces
+#dtparam=i2c_arm=on
+#dtparam=i2s=on
+#dtparam=spi=on
+
+# Enable audio (loads snd_bcm2835)
+dtparam=audio=on
+
+# Automatically load overlays for detected cameras
+camera_auto_detect=1
+
+# Automatically load overlays for detected DSI displays
+display_auto_detect=1
+
+# Enable DRM VC4 V3D driver
+dtoverlay=vc4-kms-v3d-pi5
+max_framebuffers=2
+
+# Don't have the firmware create an initial video= setting in cmdline.txt.
+# Use the kernel's default instead.
+disable_fw_kms_setup=1
+
 # Disable overscan assuming the display supports displaying the full resolution
 # If the text shown on the screen disappears off the edge, comment this out
 disable_overscan=1
+
+# fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
+dtoverlay=miniuart-bt
+
+# enable autoprobing of Bluetooth driver without need of hciattach/btattach
+dtparam=krnbt=on
+
+# enable 64bits support
+arm_64bit=1
+
+# Run as fast as firmware / board allows
+arm_boost=1
+
+# Raspberry PI 5 won't use UART0 as terminal out of the box. We need to enable
+# this through config.txt
+enable_uart=1
+dtoverlay=uart0-pi5
diff --git a/board/raspberrypi/patches/linux-headers/linux-headers.hash b/board/raspberrypi/patches/linux-headers/linux-headers.hash
deleted file mode 120000
index 5808d92afe..0000000000
--- a/board/raspberrypi/patches/linux-headers/linux-headers.hash
+++ /dev/null
@@ -1 +0,0 @@
-../linux/linux.hash
\ No newline at end of file
diff --git a/board/raspberrypi/patches/linux/linux.hash b/board/raspberrypi/patches/linux/linux.hash
index 8d43c25151..fc7338d0d0 100644
--- a/board/raspberrypi/patches/linux/linux.hash
+++ b/board/raspberrypi/patches/linux/linux.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256  dab3052783c68c46a5bc645b1c38d9705da995ab42823566518b62eb1fa1ef97  linux-576cc10e1ed50a9eacffc7a05c796051d7343ea4.tar.gz
+sha256  05ac851ea9b720ba44c66eb88cdcb7cbd280401b1dd1fab3391a3883e4719197  linux-stable_20240529.tar.gz
diff --git a/configs/raspberrypi5_defconfig b/configs/raspberrypi5_defconfig
index 3c88ce46cd..0517fcd36b 100644
--- a/configs/raspberrypi5_defconfig
+++ b/configs/raspberrypi5_defconfig
@@ -1,8 +1,9 @@
 BR2_aarch64=y
-BR2_cortex_a76_a55=y
-BR2_ARM_FPU_VFPV4=y
+BR2_cortex_a76=y
 
-BR2_TOOLCHAIN_BUILDROOT_CXX=y
+# patches
+BR2_GLOBAL_PATCH_DIR="board/raspberrypi/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
 
 BR2_SYSTEM_DHCP="eth0"
 
@@ -10,9 +11,8 @@ BR2_SYSTEM_DHCP="eth0"
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
 
 BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/raspberrypi/linux-4k-page-size.fragment"
 BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
-BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,576cc10e1ed50a9eacffc7a05c796051d7343ea4)/linux-576cc10e1ed50a9eacffc7a05c796051d7343ea4.tar.gz"
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,stable_20240529)/linux-stable_20240529.tar.gz"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2712"
 
 # Build the DTB from the kernel sources
@@ -34,8 +34,8 @@ BR2_PACKAGE_HOST_MTOOLS=y
 # Filesystem / image
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
-BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
-# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
+BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS="-O 64bit"
 BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi5/post-build.sh"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi5/post-image.sh"
 
@@ -45,6 +45,3 @@ BR2_PACKAGE_KMOD_TOOLS=y
 BR2_PACKAGE_XZ=y
 BR2_PACKAGE_KMOD=y
 BR2_PACKAGE_HOST_KMOD_XZ=y
-
-BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
-BR2_GLOBAL_PATCH_DIR="board/raspberrypi5/patches"
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 3/3] board/raspberrypi: add support for Raspberry Pi 5

[Thomas Petazzoni via buildroot]

Hello,

On Sun, 14 Jul 2024 23:04:54 +0700
Athaariq Ardhiansyah <foss@athaariq.my.id> wrote:

> Since the last Raspberry Pi 5 submission has no progress, I'm submitting
> these patches anyway. The newly released Raspberry Pi 5 board shares
> similar software structure except it has less proprietary API.
> Therefore, rpi-userland and all of raspberry-centric GPIO utilities are
> no longer supported.
> 
> Keep in mind that RPi 5 has no native 32-bit support due to Cortex-A76
> processor specification. That is the reason why I did not add _64.
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
> 
> ---
> Changes v1 -> v2:
>   - Fix missing newlines due to terminal issue
> 
> Changes v3 -> v4:
>   - Rebase to master
>   - Drop 4K page size, until we figured out how to run 32bit userspace
>     on top of 64bit kernel
>   - Change back from commit ID to commit tag
>   - Rewrite the commit description
>   - Fix incorrect CPU from upstream config, RPi5 has no LITTLE.big
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
> ---
>  board/raspberrypi/config_5.txt                | 42 +++++++++++++++++++
>  .../patches/linux-headers/linux-headers.hash  |  1 -
>  board/raspberrypi/patches/linux/linux.hash    |  2 +-
>  configs/raspberrypi5_defconfig                | 17 ++++----
>  4 files changed, 50 insertions(+), 12 deletions(-)
>  delete mode 120000 board/raspberrypi/patches/linux-headers/linux-headers.hash

Thanks, but here you're submitted a diff against the previous
raspberrypi5_defconfig submission. Please submit a full patch adding
the complete support for RPi5, not a diff against some random other
patch posted on the mailing list.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

[Thomas Petazzoni via buildroot]

Hello Athaariq,

On Sun, 14 Jul 2024 23:04:52 +0700
Athaariq Ardhiansyah <foss@athaariq.my.id> wrote:

> Latest RPi firmware already provided support for Raspberry Pi 5.

Thanks for the new patch. 

However, I don't understand your commit message. What "Latest" are you
talking about? Keep in mind that someone might read this in 2 years,
and the notion of "Latest" today and in 2 years will not be the same.

Also why is this sentence in the past tense? Do you mean that the
5476720d52cf579dc1627715262b30ba1242525e version currently packaged
already has RPi 5 support, or that we need to update to 1.20240529 to
have RPi 5 support?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

[Gaël PORTAY]

Hello Athaariq,

Thanks for the bump!

On Sun Jul 14, 2024 at 6:04 PM CEST, Athaariq Ardhiansyah wrote:
> Latest RPi firmware already provided support for Raspberry Pi 5.
>

Well, I think there is no big value about that message; furthermore, the
current raspberry5_defconfig does not (really) use that package:
 - It needs the config.txt that is **NOT** part of that package, weird
   though.
 - Since the pi4, (i.e pi5 included) the firmware is contained in the
   EEPROM (i.e. there is no more bootcode.bin in the first boot
   partition to boot a pi).
 - The device-tree blobs are taken from the linux kernel (not from the
   rpi-firmware).
 - The pi5 has its own dedicated console[1], therefore there is no more
   needs for the dtoverlay=miniuart-bt to have a console; this is why
   the raspberrypi5_defconfig unsets the config
   BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS.

Let's back to the commit message; it would have more sense if you tell
your change updates to the package version to a tag (instead of a taking
a "random" commit between tags). These days, upstream has released (i.e.
it has tagged commits) more often than we have bumped the package.
Therefore, it makes sense to bump the rpi-firmware to a tagged commit.
(TBH, the commit title suffices by itself, so leaving it blank is fine
with me).

However, and this is important, the rpi-firmware and the linux kernel
for raspberrypi are closely "linked" together because of the device-tree
blobs.

Indeed, the rpi-firmware provides the device-tree blob overlays and
these files needs the symbols of the matching device-tree blobs that are
provided by the kernel.

As a consequence, the version between rpi-firmware and linux ~~should~~
**MUST** match to avoid any boot-failure with the the load of overlays.

In all, a bump of the rpi-firmware **SHOULD** correspond to a bump of
the linux kernel, for every raspberrypi defconfig files (in a separate
commit). See commit[2][3].

You will find the commit id in extra/git_hash[4] in the rpi-firmware
tree: c1432b4bae5b6582f4d32ba381459f33c34d1424. And, you will figure out
it corresponds to tag stable_20240529[5] in the linux-raspberrypi tree.

Could you update BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION accordingly in
a dedicated commit? (I think you could use the tag name, no tested).

Thanks.

> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
>
> ---
> Changes v1 -> v2:
>   - Fix missing description due to terminal issue
>
> Changes v2 -> v4:
>   - Change back from commit ID to commit tag
>
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

It is not necessary to Signed-off-by (twice) in the changelog :).

> ---
>  package/rpi-firmware/rpi-firmware.hash | 2 +-
>  package/rpi-firmware/rpi-firmware.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
> index 4501db739c..5dc6efd8b3 100644
> --- a/package/rpi-firmware/rpi-firmware.hash
> +++ b/package/rpi-firmware/rpi-firmware.hash
> @@ -1,3 +1,3 @@
>  # Locally computed
> -sha256  00fe5487376e9d5ed14cbc72a9b7a5bd8d6900c84aee10f6d656f192a26d161c  rpi-firmware-5476720d52cf579dc1627715262b30ba1242525e.tar.gz
> +sha256  48d0b1b041bf77dc81d7ed04c423a7f4ce0afd0e3fbea26462309e738b89a552  rpi-firmware-1.20240529.tar.gz
>  sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 7ae9ff6c28..81066f0fc0 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RPI_FIRMWARE_VERSION = 5476720d52cf579dc1627715262b30ba1242525e
> +RPI_FIRMWARE_VERSION = 1.20240529
>  RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
>  RPI_FIRMWARE_LICENSE = BSD-3-Clause
>  RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom

Please tell me if it is unclear or if I missed something; I am no
maintainer, and I may say stupid things :)

Regards,
Gaël

[1]: https://www.raspberrypi.com/documentation/computers/configuration.html#primary-and-secondary-uart
[2]: https://github.com/buildroot/buildroot/commit/51b4421758e5ccba0f051672ccd28bc3114948d9
[3]: https://github.com/buildroot/buildroot/commit/28e6953ba84d39a6074aee439a64ef86b109dcf0
[4]: https://github.com/raspberrypi/firmware/blob/1.20240529/extra/git_hash
[5]: https://github.com/raspberrypi/linux/commit/c1432b4bae5b6582f4d32ba381459f33c34d1424
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

[Thomas Petazzoni via buildroot]

Hello,

On Mon, 15 Jul 2024 11:10:22 +0200
Gaël PORTAY <gael.portay@gmail.com> wrote:

> In all, a bump of the rpi-firmware **SHOULD** correspond to a bump of
> the linux kernel, for every raspberrypi defconfig files (in a separate
> commit). See commit[2][3].
> 
> You will find the commit id in extra/git_hash[4] in the rpi-firmware
> tree: c1432b4bae5b6582f4d32ba381459f33c34d1424. And, you will figure out
> it corresponds to tag stable_20240529[5] in the linux-raspberrypi tree.

These rules should be written, in the rpi-firmware.mk, and probably in
the various RPi defconfigs.

> Could you update BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION accordingly in
> a dedicated commit? (I think you could use the tag name, no tested).

Yes, it can use tags.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

[Athaariq Ardhiansyah]

Hello Thomas and Gaël,

 > Thanks, but here you're submitted a diff against the previous
 > raspberrypi5_defconfig submission. Please submit a full patch adding
 > the complete support for RPi5, not a diff against some random other
 > patch posted on the mailing list.

I don't think it's from random patches, it just my shameful mistake
while rebasing the patch to the master branch. Let me explain.

 > Let's back to the commit message; it would have more sense if you tell
 > your change updates to the package version to a tag

Okay done, please review the patch series:
https://patchwork.ozlabs.org/project/buildroot/patch/20240715160941.90353-1-foss@athaariq.my.id/

Please note that host-raspberrypi-usbboot has no proper tag for RPi5
support. Therefore, picking a commit with explicit RPi5 support
mentioned in the description is the only way to do.

 > It is not necessary to Signed-off-by (twice) in the changelog 🙂.

Ah yes 😭 I forgot to omit "-s" flag from "git send-email ...". I am so
sorry for that :(

 > Please don't change the author of existing patches. This change is
 > spurious.

Yet another my shameful mistake :( somehow it messed up after multiple
times of rebase. My big apology for anyone who got offended from this.
I have no intention of letting someone down.

Sincerely,
Athaariq Ardhiansyah

NB: How to not panic after inhaled magic smoke that emitted from a chip?
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot