Re: [Buildroot] [PATCH] package/busybox: fix build with glibc 2.39

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fred,

On Mon, 15 Jul 2024 12:16:06 +0200
Fred Lefranc <fred.lefranc.evs@gmail.com> wrote:

> diff --git a/package/busybox/Config.in b/package/busybox/Config.in
> index 3c2aa515f8..85fa0c7f9a 100644
> --- a/package/busybox/Config.in
> +++ b/package/busybox/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_BUSYBOX
>  	bool "BusyBox"
>  	default y
> +	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC

I'm not sure we want to make this a mandatory dependency. Indeed, with
our default Busybox configuration it's not needed.

> +ifeq ($(BR2_PACKAGE_LIBXCRYPT)$(BR2_TOOLCHAIN_USES_GLIBC),yy)
> +	BUSYBOX_DEPENDENCIES += libxcrypt

No indentation for BUSYBOX_DEPENDENCIES.

> +endif

So basically, I would just do:

ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
BUSYBOX_DEPENDENCIES += libxcrypt
endif

and leave it up to the users who tweak their Busybox configuration to
figure out that they need to enable BR2_PACKAGE_LIBXCRYPT.

I remember there was some discussion with Yann on IRC about this topic,
but I don't remember what the conclusion was, but the above would be my
suggestion.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot