Re: [Buildroot] [PATCH v4] package/busybox: fix build with glibc 2.39

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 17 Jul 2024 14:11:46 +0200
Fred Lefranc <fred.lefranc.evs@gmail.com> wrote:

> When glibc was bumped to version 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97,
> it removed the deprecated libcrypt support.
> 
> In such a situation, until the upgrade of glibc to 2.39, Busybox could rely on the
> libcrypt provided by glibc. Since version 2.39, glibc no longer provides libcrypt,
> causing a build failure with Busybox configurations that have CONFIG_USE_BB_CRYPT
> disabled.
> 
> To fix this, add the libxcrypt dependency to Busybox when BR2_PACKAGE_LIBXCRYPT is
> selected. The user is still responsible for enabling BR2_PACKAGE_LIBXCRYPT when
> their Busybox configuration has CONFIG_USE_BB_CRYPT disabled.
> 
> Signed-off-by: Fred Lefranc <fred.lefranc+evs@gmail.com>
> ---
> Changes v3 -> v4
>   - fix commit message to explain the non-working case
> Changes v2 -> v3
>   - fix commit message
> Changes v1 -> v2
>   - busybox.mk: fix BUSYBOX_DEPENDENCIES ident & remove the check
> for BR2_TOOLCHAIN_USES_GLIBC (req by Thomas)
>   - Config.in: remove libxcrypt mandatory dependency
> (req by Thomas)
> ---
>  package/busybox/busybox.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Thanks for your persistence, patch applied! The lines of the commit log
were a bit too long, so I rewrapped the paragraphs.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot