Re: [Buildroot] [PATCH v3] package/busybox: fix build with glibc 2.39

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fred,

On Tue, 16 Jul 2024 09:59:34 +0200
Fred Lefranc <fred.lefranc.evs@gmail.com> wrote:

> When glibc was bumped to version 2.39 in commit
> b5680f53d60acf8ff6010082f873438a39bd5d97 it removed the deprecated
> libcrypt support.
> 
> As glibc's libcrypt was providing busybox's libcrypt dependency this
> broke any busybox build using glibc version 2.39.

Thanks for the new patch, but this still is wrong or too vague.

When you say "this broke any busybox build", it means that Busybox
build is completely broken. However, I don't see any Busybox build
failures in our autobuilders. So quite certainly, it's not all Busybox
builds that are broken.

So your commit should much better document which Busybox configurations
are broken. What is the build failure you encounter? After enabling
which option?

From a quick look, <crypt.h> is included by libbb/pw_encrypt.c, which
does:

#if !ENABLE_USE_BB_CRYPT
# if !defined(__FreeBSD__)
#  include <crypt.h>
# endif
#endif

So it's only if you *disable* USE_BB_CRYPT that you will have an issue
I believe? And USE_BB_CRYPT is enabled in our default configuration.

Could you please be a lot more specific/precise in your commit log? I
think your change is correct, but your commit log doesn't provide a
good justification for it.

On my side, I confirm that I can reproduce the build issue if I disable
USE_BB_CRYPT in my Busybox configuration. Is this the issue you're
seeing?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot