Re: [Buildroot] [PATCH v3] package/busybox: fix build with glibc 2.39

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fred,

On Tue, 16 Jul 2024 19:32:05 +0200
Fred Lefranc <fred.lefranc.evs@gmail.com> wrote:

> Here is a revised version:

This is much better. Minor comments.

> When glibc was bumped to version 2.39 in commit
> b5680f53d60acf8ff6010082f873438a39bd5d97
> it removed the deprecated libcrypt support.
> 
> Busybox has internal crypt functions that are enabled by default. However,
> a user
> can choose to use the system's crypt function instead by disabling
> CONFIG_USE_BB_CRYPT.
> In such situations, glibc's libcrypt was providing busybox's libcrypt
> dependency
> and so busybox builds are broken when using glibc version 2.39 with
> CONFIG_USE_BB_CRYPT
> disabled.

In this last sentence, the usage of English tenses doesn't seem correct
to me (even though I'm not a native speaker). What about:

In such situation, until the upgrade of glibc to 2.39, Busybox could
rely on the libcrypt provided by glibc. However, this the bump of glibc
to 2.39, glibc no longer provides libcrypt, causing a build failure
with Busybox configurations that have CONFIG_USE_BB_CRYPT disabled.

> 
> To fix this, add the libxcrypt dependency to busybox when
> BR2_PACKAGE_LIBXCRYPT is
> selected. The user still has to select the libxcrypt package for this patch
> to work
> properly.

Replace last sentence with:

The user is still responsible for enabling BR2_PACKAGE_LIBXCRYPT when
their Busybox configuration has CONFIG_USE_BB_CRYPT disabled.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot