* [Buildroot] [PATCH] package/nfs-utils: bump version to 2.7.1
@ 2024-09-24 9:07 Giulio Benetti
2024-10-26 20:13 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2024-09-24 9:07 UTC (permalink / raw)
To: buildroot; +Cc: Petr Vorel, Giulio Benetti
* add libxml2 dependency that is now mandatory
* drop 2 local patches that have been committed.
* add 2 patches committed upstream to fix musl build failure.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
...-reexport-.c-Re-add-missing-includes.patch | 44 ----------------
...de-junction.h-Define-macros-for-musl.patch | 51 +++++++++++++++++++
...d_sqlite.c-Add-missing-sys-syscall.h.patch | 31 -----------
...rt-junction-path.c-Fix-buld-for-musl.patch | 40 +++++++++++++++
package/nfs-utils/Config.in | 1 +
package/nfs-utils/nfs-utils.hash | 4 +-
package/nfs-utils/nfs-utils.mk | 6 +--
7 files changed, 97 insertions(+), 80 deletions(-)
delete mode 100644 package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
create mode 100644 package/nfs-utils/0001-support-include-junction.h-Define-macros-for-musl.patch
delete mode 100644 package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
create mode 100644 package/nfs-utils/0002-support-junction-path.c-Fix-buld-for-musl.patch
diff --git a/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch b/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
deleted file mode 100644
index 4f79af450e..0000000000
--- a/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
+++ /dev/null
@@ -1,44 +0,0 @@
-From 4710e469cd0f512ac5e2c3c4335d8e21b97f21b0 Mon Sep 17 00:00:00 2001
-From: Petr Vorel <pvorel@suse.cz>
-Date: Tue, 5 Dec 2023 20:40:36 +0100
-Subject: [PATCH] reexport/{fsidd,reexport}.c: Re-add missing includes
-
-Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2),
-<sys/un.h> for struct sockaddr_un.
-
-Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers")
-Fixes: bdc79f02 ("support/reexport.c: Remove unused headers")
-Signed-off-by: Petr Vorel <pvorel@suse.cz>
-Upstream: https://lore.kernel.org/linux-nfs/20231205223543.31443-1-pvorel@suse.cz/
----
- support/reexport/fsidd.c | 2 ++
- support/reexport/reexport.c | 1 +
- 2 files changed, 3 insertions(+)
-
-diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
-index 3e62b3fc..814fb48e 100644
---- a/support/reexport/fsidd.c
-+++ b/support/reexport/fsidd.c
-@@ -7,6 +7,8 @@
- #include <dlfcn.h>
- #endif
- #include <event2/event.h>
-+#include <sys/un.h>
-+#include <unistd.h>
-
- #include "conffile.h"
- #include "reexport_backend.h"
-diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
-index 78516586..1900b336 100644
---- a/support/reexport/reexport.c
-+++ b/support/reexport/reexport.c
-@@ -7,6 +7,7 @@
- #endif
- #include <sys/types.h>
- #include <sys/vfs.h>
-+#include <unistd.h>
- #include <errno.h>
-
- #include "nfsd_path.h"
---
-2.43.0
diff --git a/package/nfs-utils/0001-support-include-junction.h-Define-macros-for-musl.patch b/package/nfs-utils/0001-support-include-junction.h-Define-macros-for-musl.patch
new file mode 100644
index 0000000000..3ae6996d8c
--- /dev/null
+++ b/package/nfs-utils/0001-support-include-junction.h-Define-macros-for-musl.patch
@@ -0,0 +1,51 @@
+From 34a7959ddfb50db806c3f0e848947ff1117f37e2 Mon Sep 17 00:00:00 2001
+From: Robert Yang <liezhi.yang@windriver.com>
+Date: Fri, 20 Sep 2024 07:43:00 -0400
+Subject: [PATCH 1/2] support/include/junction.h: Define macros for musl
+
+Fixed 1:
+In file included from cache.c:1217:
+../../support/include/junction.h:128:21: error: expected ';' before 'char'
+ 128 | __attribute_malloc__
+ | ^
+ | ;
+ 129 | char **nfs_dup_string_array(char **array);
+
+Fixed 2:
+junction.c: In function 'junction_set_sticky_bit':
+junction.c:164:39: error: 'ALLPERMS' undeclared (first use in this function)
+ 164 | stb.st_mode &= (unsigned int)~ALLPERMS;
+
+Upstream: http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=34a7959ddfb50db806c3f0e848947ff1117f37e2
+
+Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
+Signed-off-by: Steve Dickson <steved@redhat.com>
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ support/include/junction.h | 10 ++++++++++
+ 1 file changed, 10 insertions(+)
+
+diff --git a/support/include/junction.h b/support/include/junction.h
+index 7257d80b..d127dd55 100644
+--- a/support/include/junction.h
++++ b/support/include/junction.h
+@@ -26,6 +26,16 @@
+ #ifndef _NFS_JUNCTION_H_
+ #define _NFS_JUNCTION_H_
+
++/* For musl, refered to glibc's sys/cdefs.h */
++#ifndef __attribute_malloc__
++#define __attribute_malloc__ __attribute__((__malloc__))
++#endif
++
++/* For musl, refered to glibc's sys/stat.h */
++#ifndef ALLPERMS
++#define ALLPERMS (S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO)/* 07777 */
++#endif
++
+ #include <stdint.h>
+
+ /*
+--
+2.43.0
+
diff --git a/package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch b/package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
deleted file mode 100644
index 88e1a9068d..0000000000
--- a/package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From aee92881ba80cf2ae7381d19f09e7fbeda57974c Mon Sep 17 00:00:00 2001
-From: Petr Vorel <petr.vorel@gmail.com>
-Date: Tue, 5 Dec 2023 23:20:33 +0100
-Subject: [PATCH] support/backend_sqlite.c: Add missing <sys/syscall.h>
-
-This fixes build on systems which actually needs getrandom()
-(to get SYS_getrandom).
-
-Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
-Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
-Reported-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
-Signed-off-by: Petr Vorel <pvorel@suse.cz>
-Upstream: https://lore.kernel.org/linux-nfs/20231205223543.31443-2-pvorel@suse.cz/
----
- support/reexport/backend_sqlite.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/support/reexport/backend_sqlite.c b/support/reexport/backend_sqlite.c
-index 0eb5ea37..54dfe447 100644
---- a/support/reexport/backend_sqlite.c
-+++ b/support/reexport/backend_sqlite.c
-@@ -7,6 +7,7 @@
- #include <stdio.h>
- #include <stdlib.h>
- #include <string.h>
-+#include <sys/syscall.h>
- #include <unistd.h>
-
- #ifdef HAVE_GETRANDOM
---
-2.43.0
diff --git a/package/nfs-utils/0002-support-junction-path.c-Fix-buld-for-musl.patch b/package/nfs-utils/0002-support-junction-path.c-Fix-buld-for-musl.patch
new file mode 100644
index 0000000000..6098eed3e2
--- /dev/null
+++ b/package/nfs-utils/0002-support-junction-path.c-Fix-buld-for-musl.patch
@@ -0,0 +1,40 @@
+From 4ddf3188f610a4ccfa8539cd94f5505a1a22db6c Mon Sep 17 00:00:00 2001
+From: Robert Yang <liezhi.yang@windriver.com>
+Date: Fri, 20 Sep 2024 07:44:53 -0400
+Subject: [PATCH 2/2] support/junction/path.c: Fix buld for musl
+
+Fixed:
+path.c:164:24: error: implicit declaration of function 'strchrnul'; did you mean 'strchr'? [-Wimplicit-function-declaration]
+[snip]
+
+path.c:239:27: error: 'NAME_MAX' undeclared (first use in this function); did you mean 'AF_MAX'?
+
+Upstream: http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=4ddf3188f610a4ccfa8539cd94f5505a1a22db6c
+
+Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
+Signed-off-by: Steve Dickson <steved@redhat.com>
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ support/junction/path.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/support/junction/path.c b/support/junction/path.c
+index 13a14386..dd0f59a0 100644
+--- a/support/junction/path.c
++++ b/support/junction/path.c
+@@ -23,6 +23,12 @@
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
+ */
+
++/* For musl */
++#ifndef _GNU_SOURCE
++#define _GNU_SOURCE
++#endif
++#include <limits.h>
++
+ #include <sys/types.h>
+ #include <sys/stat.h>
+
+--
+2.43.0
+
diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in
index 02cc7e78cc..062af104bf 100644
--- a/package/nfs-utils/Config.in
+++ b/package/nfs-utils/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_NFS_UTILS
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom()
select BR2_PACKAGE_LIBEVENT
select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
+ select BR2_PACKAGE_LIBXML2
select BR2_PACKAGE_SQLITE
select BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
diff --git a/package/nfs-utils/nfs-utils.hash b/package/nfs-utils/nfs-utils.hash
index 9d74991df1..6241eb1c3d 100644
--- a/package/nfs-utils/nfs-utils.hash
+++ b/package/nfs-utils/nfs-utils.hash
@@ -1,4 +1,4 @@
-# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.6.4/sha256sums.asc
-sha256 01b3b0fb9c7d0bbabf5114c736542030748c788ec2fd9734744201e9b0a1119d nfs-utils-2.6.4.tar.xz
+# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.7.1/sha256sums.asc
+sha256 885c948a84a58bca4148f459588f9a7369dbb40dcc466f04e455c6b10fd0aa48 nfs-utils-2.7.1.tar.xz
# Locally computed
sha256 576540abf5e95029ad4ad90e32071385a5e95b2c30708c706116f3eb87b9a3de COPYING
diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index b757e3e51d..7fb3c2a7ec 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -4,12 +4,12 @@
#
################################################################################
-NFS_UTILS_VERSION = 2.6.4
+NFS_UTILS_VERSION = 2.7.1
NFS_UTILS_SOURCE = nfs-utils-$(NFS_UTILS_VERSION).tar.xz
NFS_UTILS_SITE = https://www.kernel.org/pub/linux/utils/nfs-utils/$(NFS_UTILS_VERSION)
NFS_UTILS_LICENSE = GPL-2.0+
NFS_UTILS_LICENSE_FILES = COPYING
-NFS_UTILS_DEPENDENCIES = host-nfs-utils host-pkgconf libevent libtirpc sqlite util-linux
+NFS_UTILS_DEPENDENCIES = host-nfs-utils host-pkgconf libevent libtirpc libxml2 sqlite util-linux
NFS_UTILS_CPE_ID_VENDOR = linux-nfs
NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no
@@ -21,7 +21,7 @@ NFS_UTILS_CONF_OPTS = \
--with-statedir=/run/nfs \
--with-rpcgen=$(HOST_DIR)/bin/rpcgen
-HOST_NFS_UTILS_DEPENDENCIES = host-pkgconf host-libtirpc host-libevent host-sqlite host-util-linux
+HOST_NFS_UTILS_DEPENDENCIES = host-pkgconf host-libtirpc host-libxml2 host-libevent host-sqlite host-util-linux
HOST_NFS_UTILS_CONF_OPTS = \
--enable-tirpc \
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.7.1
2024-09-24 9:07 [Buildroot] [PATCH] package/nfs-utils: bump version to 2.7.1 Giulio Benetti
@ 2024-10-26 20:13 ` Thomas Petazzoni via buildroot
2024-11-04 20:23 ` [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1 Giulio Benetti
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-26 20:13 UTC (permalink / raw)
To: Giulio Benetti; +Cc: buildroot, Petr Vorel
Hello Giulio,
On Tue, 24 Sep 2024 11:07:56 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> * add libxml2 dependency that is now mandatory
> * drop 2 local patches that have been committed.
> * add 2 patches committed upstream to fix musl build failure.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> ...-reexport-.c-Re-add-missing-includes.patch | 44 ----------------
> ...de-junction.h-Define-macros-for-musl.patch | 51 +++++++++++++++++++
> ...d_sqlite.c-Add-missing-sys-syscall.h.patch | 31 -----------
> ...rt-junction-path.c-Fix-buld-for-musl.patch | 40 +++++++++++++++
> package/nfs-utils/Config.in | 1 +
> package/nfs-utils/nfs-utils.hash | 4 +-
> package/nfs-utils/nfs-utils.mk | 6 +--
> 7 files changed, 97 insertions(+), 80 deletions(-)
> delete mode 100644 package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
> create mode 100644 package/nfs-utils/0001-support-include-junction.h-Define-macros-for-musl.patch
> delete mode 100644 package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
> create mode 100644 package/nfs-utils/0002-support-junction-path.c-Fix-buld-for-musl.patch
Thanks for your patch. However, as far as I can see, libxml2 is not a
mandatory dependency, you only need it when --enable-junctions (which
is now the default). But I believe we should keep it optional in
Buildroot for the target package (which a sub-option in Config.in), and
simply disable junctions for the host package.
Also, your patches have PATCH 1/2 and PATCH 2/2, so they will cause
some check-package warnings.
Could you rework/adjust?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1
2024-10-26 20:13 ` Thomas Petazzoni via buildroot
@ 2024-11-04 20:23 ` Giulio Benetti
2024-11-04 21:16 ` Petr Vorel
2024-12-29 21:20 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 6+ messages in thread
From: Giulio Benetti @ 2024-11-04 20:23 UTC (permalink / raw)
To: buildroot; +Cc: Petr Vorel, Giulio Benetti
* disable junction and nfsdctl by default
* drop 2 local patches that have been committed.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
...-reexport-.c-Re-add-missing-includes.patch | 44 -------------------
...d_sqlite.c-Add-missing-sys-syscall.h.patch | 31 -------------
package/nfs-utils/nfs-utils.hash | 4 +-
package/nfs-utils/nfs-utils.mk | 6 ++-
4 files changed, 7 insertions(+), 78 deletions(-)
delete mode 100644 package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
delete mode 100644 package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
diff --git a/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch b/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
deleted file mode 100644
index 4f79af450e..0000000000
--- a/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
+++ /dev/null
@@ -1,44 +0,0 @@
-From 4710e469cd0f512ac5e2c3c4335d8e21b97f21b0 Mon Sep 17 00:00:00 2001
-From: Petr Vorel <pvorel@suse.cz>
-Date: Tue, 5 Dec 2023 20:40:36 +0100
-Subject: [PATCH] reexport/{fsidd,reexport}.c: Re-add missing includes
-
-Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2),
-<sys/un.h> for struct sockaddr_un.
-
-Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers")
-Fixes: bdc79f02 ("support/reexport.c: Remove unused headers")
-Signed-off-by: Petr Vorel <pvorel@suse.cz>
-Upstream: https://lore.kernel.org/linux-nfs/20231205223543.31443-1-pvorel@suse.cz/
----
- support/reexport/fsidd.c | 2 ++
- support/reexport/reexport.c | 1 +
- 2 files changed, 3 insertions(+)
-
-diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
-index 3e62b3fc..814fb48e 100644
---- a/support/reexport/fsidd.c
-+++ b/support/reexport/fsidd.c
-@@ -7,6 +7,8 @@
- #include <dlfcn.h>
- #endif
- #include <event2/event.h>
-+#include <sys/un.h>
-+#include <unistd.h>
-
- #include "conffile.h"
- #include "reexport_backend.h"
-diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
-index 78516586..1900b336 100644
---- a/support/reexport/reexport.c
-+++ b/support/reexport/reexport.c
-@@ -7,6 +7,7 @@
- #endif
- #include <sys/types.h>
- #include <sys/vfs.h>
-+#include <unistd.h>
- #include <errno.h>
-
- #include "nfsd_path.h"
---
-2.43.0
diff --git a/package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch b/package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
deleted file mode 100644
index 88e1a9068d..0000000000
--- a/package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From aee92881ba80cf2ae7381d19f09e7fbeda57974c Mon Sep 17 00:00:00 2001
-From: Petr Vorel <petr.vorel@gmail.com>
-Date: Tue, 5 Dec 2023 23:20:33 +0100
-Subject: [PATCH] support/backend_sqlite.c: Add missing <sys/syscall.h>
-
-This fixes build on systems which actually needs getrandom()
-(to get SYS_getrandom).
-
-Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
-Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
-Reported-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
-Signed-off-by: Petr Vorel <pvorel@suse.cz>
-Upstream: https://lore.kernel.org/linux-nfs/20231205223543.31443-2-pvorel@suse.cz/
----
- support/reexport/backend_sqlite.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/support/reexport/backend_sqlite.c b/support/reexport/backend_sqlite.c
-index 0eb5ea37..54dfe447 100644
---- a/support/reexport/backend_sqlite.c
-+++ b/support/reexport/backend_sqlite.c
-@@ -7,6 +7,7 @@
- #include <stdio.h>
- #include <stdlib.h>
- #include <string.h>
-+#include <sys/syscall.h>
- #include <unistd.h>
-
- #ifdef HAVE_GETRANDOM
---
-2.43.0
diff --git a/package/nfs-utils/nfs-utils.hash b/package/nfs-utils/nfs-utils.hash
index 9d74991df1..b4ecbd0aec 100644
--- a/package/nfs-utils/nfs-utils.hash
+++ b/package/nfs-utils/nfs-utils.hash
@@ -1,4 +1,4 @@
-# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.6.4/sha256sums.asc
-sha256 01b3b0fb9c7d0bbabf5114c736542030748c788ec2fd9734744201e9b0a1119d nfs-utils-2.6.4.tar.xz
+# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.8.1/sha256sums.asc
+sha256 a0be95b08396908048583fcf6b34a7c1ab49d53e8a12eb28673ccfd2eff0c505 nfs-utils-2.8.1.tar.xz
# Locally computed
sha256 576540abf5e95029ad4ad90e32071385a5e95b2c30708c706116f3eb87b9a3de COPYING
diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index b757e3e51d..d79760ab00 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -4,7 +4,7 @@
#
################################################################################
-NFS_UTILS_VERSION = 2.6.4
+NFS_UTILS_VERSION = 2.8.1
NFS_UTILS_SOURCE = nfs-utils-$(NFS_UTILS_VERSION).tar.xz
NFS_UTILS_SITE = https://www.kernel.org/pub/linux/utils/nfs-utils/$(NFS_UTILS_VERSION)
NFS_UTILS_LICENSE = GPL-2.0+
@@ -17,6 +17,8 @@ NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no
NFS_UTILS_CONF_OPTS = \
--enable-tirpc \
--enable-ipv6 \
+ --disable-junction \
+ --disable-nfsdctl \
--without-tcp-wrappers \
--with-statedir=/run/nfs \
--with-rpcgen=$(HOST_DIR)/bin/rpcgen
@@ -30,6 +32,8 @@ HOST_NFS_UTILS_CONF_OPTS = \
--disable-gss \
--disable-uuid \
--disable-ipv6 \
+ --disable-junction \
+ --disable-nfsdctl \
--without-tcp-wrappers \
--with-statedir=/run/nfs \
--disable-caps \
--
2.39.5
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1
2024-11-04 20:23 ` [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1 Giulio Benetti
@ 2024-11-04 21:16 ` Petr Vorel
2024-11-04 21:40 ` Giulio Benetti
2024-12-29 21:20 ` Thomas Petazzoni via buildroot
1 sibling, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2024-11-04 21:16 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Yann E. MORIN, Thomas Petazzoni, buildroot
Hi Giulio,
Thanks for the update!
> * disable junction and nfsdctl by default
...
> NFS_UTILS_CONF_OPTS = \
> --enable-tirpc \
> --enable-ipv6 \
> + --disable-junction \
> + --disable-nfsdctl \
> --without-tcp-wrappers \
> --with-statedir=/run/nfs \
> --with-rpcgen=$(HOST_DIR)/bin/rpcgen
> @@ -30,6 +32,8 @@ HOST_NFS_UTILS_CONF_OPTS = \
> --disable-gss \
> --disable-uuid \
> --disable-ipv6 \
> + --disable-junction \
> + --disable-nfsdctl \
> --without-tcp-wrappers \
> --with-statedir=/run/nfs \
> --disable-caps \
What was the reason to disable them? Shouldn't be at least nfsdctl enabled?
man nfsdctl(8) "control program for the Linux kernel NFS server" [1]
That sounds useful.
man nfsref(8) "manage NFS referrals"
...
A junction is a file system object on an NFS server that, when an
NFS client encounters it, triggers a referral. Similar to a
symlink, a junction contains one or more target locations that
the server sends to clients in the form of an NFSv4 referral.
I'm not sure how much useful this is, but it's enabled by default. Also Debian
explicitly enables it. Do we have a good reason to disable it?
> * drop 2 local patches that have been committed.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
[1] https://manpages.debian.org/testing/nfs-kernel-server/nfsdctl.8.en.html
[2] https://man7.org/linux/man-pages/man8/nfsref.8.html
[3] https://salsa.debian.org/kernel-team/nfs-utils/-/blob/master/debian/rules?ref_type=heads
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1
2024-11-04 21:16 ` Petr Vorel
@ 2024-11-04 21:40 ` Giulio Benetti
0 siblings, 0 replies; 6+ messages in thread
From: Giulio Benetti @ 2024-11-04 21:40 UTC (permalink / raw)
To: Petr Vorel; +Cc: Yann E. MORIN, Thomas Petazzoni, buildroot
Hi Petr,
On 11/4/24 22:16, Petr Vorel wrote:
> Hi Giulio,
>
> Thanks for the update!
>
>> * disable junction and nfsdctl by default
> ...
>> NFS_UTILS_CONF_OPTS = \
>> --enable-tirpc \
>> --enable-ipv6 \
>> + --disable-junction \
>> + --disable-nfsdctl \
>> --without-tcp-wrappers \
>> --with-statedir=/run/nfs \
>> --with-rpcgen=$(HOST_DIR)/bin/rpcgen
>> @@ -30,6 +32,8 @@ HOST_NFS_UTILS_CONF_OPTS = \
>> --disable-gss \
>> --disable-uuid \
>> --disable-ipv6 \
>> + --disable-junction \
>> + --disable-nfsdctl \
>> --without-tcp-wrappers \
>> --with-statedir=/run/nfs \
>> --disable-caps \
>
> What was the reason to disable them? Shouldn't be at least nfsdctl enabled?
nfsdctl has been added with nfs-utils commit
8c32613d5311930c17c056d93996bcd8e00e0fa4
so between version 2.7.1 and 2.8.1 and with this bump I've tried to keep
things as they were.
>
> man nfsdctl(8) "control program for the Linux kernel NFS server" [1]
> That sounds useful.
Yes it is. But I think it deserves a separate patch since it's not about
bumping the version. Feel free to provide one for it.
>
> man nfsref(8) "manage NFS referrals"
> ...
> A junction is a file system object on an NFS server that, when an
> NFS client encounters it, triggers a referral. Similar to a
> symlink, a junction contains one or more target locations that
> the server sends to clients in the form of an NFSv4 referral.
>
> I'm not sure how much useful this is, but it's enabled by default. Also Debian
> explicitly enables it. Do we have a good reason to disable it?
To keep it enabled we need libxml2 dependency, so I've preferred to keep
it disabled as pointed by Thomas on patch to bump to version 2.7.1
This can be enabled as an option too, so here again you can send a patch.
Kind regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
>
>> * drop 2 local patches that have been committed.
>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
>
> Kind regards,
> Petr
>
> [1] https://manpages.debian.org/testing/nfs-kernel-server/nfsdctl.8.en.html
> [2] https://man7.org/linux/man-pages/man8/nfsref.8.html
> [3] https://salsa.debian.org/kernel-team/nfs-utils/-/blob/master/debian/rules?ref_type=heads
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1
2024-11-04 20:23 ` [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1 Giulio Benetti
2024-11-04 21:16 ` Petr Vorel
@ 2024-12-29 21:20 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-12-29 21:20 UTC (permalink / raw)
To: Giulio Benetti; +Cc: buildroot, Petr Vorel
On Mon, 4 Nov 2024 21:23:19 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> * disable junction and nfsdctl by default
> * drop 2 local patches that have been committed.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> ...-reexport-.c-Re-add-missing-includes.patch | 44 -------------------
> ...d_sqlite.c-Add-missing-sys-syscall.h.patch | 31 -------------
> package/nfs-utils/nfs-utils.hash | 4 +-
> package/nfs-utils/nfs-utils.mk | 6 ++-
> 4 files changed, 7 insertions(+), 78 deletions(-)
> delete mode 100644 package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
> delete mode 100644 package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-29 21:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 9:07 [Buildroot] [PATCH] package/nfs-utils: bump version to 2.7.1 Giulio Benetti
2024-10-26 20:13 ` Thomas Petazzoni via buildroot
2024-11-04 20:23 ` [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1 Giulio Benetti
2024-11-04 21:16 ` Petr Vorel
2024-11-04 21:40 ` Giulio Benetti
2024-12-29 21:20 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox