Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Brian Cain via buildroot <buildroot@buildroot.org>
Cc: Brian Cain <brian.cain@oss.qualcomm.com>
Subject: Re: [Buildroot] [RFC v2 02/14] toolchain/toolchain-external: add hexagon toolchain support
Date: Wed, 5 Feb 2025 11:58:14 +0100	[thread overview]
Message-ID: <20250205115814.3a75066d@windsurf> (raw)
In-Reply-To: <20241219053053.2389046-3-brian.cain@oss.qualcomm.com>

Hello Brian,

On Wed, 18 Dec 2024 21:30:41 -0800
Brian Cain via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
> ---
>  toolchain/toolchain-external/Config.in                |  6 ++++++
>  .../toolchain-external-hexagon/Config.in              |  7 +++++++
>  .../toolchain-external-hexagon/Config.in.options      | 10 ++++++++++
>  .../toolchain-external-hexagon.hash                   |  6 ++++++
>  .../toolchain-external-hexagon.mk                     | 11 +++++++++++
>  5 files changed, 40 insertions(+)

Please update the DEVELOPERS file as part of this commit.

>  create mode 100644 toolchain/toolchain-external/toolchain-external-hexagon/Config.in
>  create mode 100644 toolchain/toolchain-external/toolchain-external-hexagon/Config.in.options
>  create mode 100644 toolchain/toolchain-external/toolchain-external-hexagon/toolchain-external-hexagon.hash
>  create mode 100644 toolchain/toolchain-external/toolchain-external-hexagon/toolchain-external-hexagon.mk

I believe the toolchain should be perhaps be named
toolchain-external-linaro-hexagon toolchain. Indeed,
toolchain-external-hexagon is too generic, and could be a name for
*any* hexagon toolchain.

> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index e91aa16326..7bd5309671 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -29,6 +29,9 @@ source "toolchain/toolchain-external/toolchain-external-linaro-armeb/Config.in"
>  # MIPS
>  source "toolchain/toolchain-external/toolchain-external-codesourcery-mips/Config.in"
>  
> +# Hexagon
> +source "toolchain/toolchain-external/toolchain-external-hexagon/Config.in"
> +
>  # Bootlin toolchains, available for virtually all architectures
>  source "toolchain/toolchain-external/toolchain-external-bootlin/Config.in"
>  
> @@ -123,6 +126,9 @@ source "toolchain/toolchain-external/toolchain-external-linaro-arm/Config.in.opt
>  # ARM big-endian
>  source "toolchain/toolchain-external/toolchain-external-linaro-armeb/Config.in.options"
>  
> +# Hexagon
> +source "toolchain/toolchain-external/toolchain-external-hexagon/Config.in.options"
> +
>  # MIPS
>  source "toolchain/toolchain-external/toolchain-external-codesourcery-mips/Config.in.options"
>  
> diff --git a/toolchain/toolchain-external/toolchain-external-hexagon/Config.in b/toolchain/toolchain-external/toolchain-external-hexagon/Config.in
> new file mode 100644
> index 0000000000..256eeb87dc
> --- /dev/null
> +++ b/toolchain/toolchain-external/toolchain-external-hexagon/Config.in
> @@ -0,0 +1,7 @@
> +comment "Toolchains available for Hexagon DSP"
> +
> +config BR2_TOOLCHAIN_EXTERNAL_HEXAGON
> +	bool "Clang/LLVM Hexagon Toolchain"
> +	depends on BR2_HOSTARCH = "x86_64" || "aarch64"
> +	select BR2_TOOLCHAIN_EXTERNAL_CLANG

As of commit PATCH 02, this Config.in symbol doesn't exist, so you need
to adjust the order of the patches so that it gets added earlier.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-02-05 10:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 14:07 [Buildroot] [RFC 00/12] add hexagon architecture Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 01/12] arch: add hexagon architecture support Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 02/12] toolchain/toolchain-external: add hexagon toolchain support Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 03/12] toolchain/toolchain-external: add hexagon support for toolchain-wrapper Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 04/12] toolchain/toolchain-external: add support for clang Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 05/12] toolchain/toolchain-external: skip "-march=" for hexagon Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 06/12] linux: add support for hexagon clang Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 07/12] arch: add hexagon ARCH definition Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 08/12] package/hexagonMVM: new package Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 09/12] board/qcom/sa8775: add support for qcom sa8775-cdsp0 Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 10/12] configs: add hexagon QEMU config Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 11/12] DEVELOPERS: add myself as developer for hexagon Brian Cain
2024-10-25 14:07 ` [Buildroot] [RFC 12/12] package: disable -ztext " Brian Cain
2024-12-19  5:30 ` [Buildroot] [RFC v2 00/14] add hexagon architecture Brian Cain
2024-12-19  5:30   ` [Buildroot] [RFC v2 01/14] arch: add hexagon architecture support Brian Cain via buildroot
2025-02-05 10:54     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 02/14] toolchain/toolchain-external: add hexagon toolchain support Brian Cain via buildroot
2025-02-05 10:58     ` Thomas Petazzoni [this message]
2024-12-19  5:30   ` [Buildroot] [RFC v2 03/14] toolchain/toolchain-external: add hexagon support for toolchain-wrapper Brian Cain via buildroot
2025-02-05 11:01     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 04/14] toolchain/toolchain-external: add support for clang Brian Cain via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 05/14] toolchain/toolchain-external: skip "-march=" for hexagon Brian Cain via buildroot
2025-02-05 11:03     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 06/14] linux: add support for hexagon clang Brian Cain via buildroot
2025-02-05 11:04     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 07/14] arch: add hexagon ARCH definition Brian Cain via buildroot
2025-02-05 11:05     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 08/14] package/hexagonMVM: new package Brian Cain via buildroot
2025-02-05 11:08     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 09/14] board/qcom/sa8775: add support for qcom sa8775-cdsp0 Brian Cain
2025-02-05 11:28     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 10/14] configs: add hexagon QEMU config Brian Cain via buildroot
2025-02-05 11:26     ` Thomas Petazzoni
2025-03-04 21:16       ` Brian Cain via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 11/14] DEVELOPERS: add myself as developer for hexagon Brian Cain via buildroot
2025-02-05 11:28     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 12/14] toolchain: disable PIE " Brian Cain
2025-02-05 11:29     ` Thomas Petazzoni
2024-12-19  5:30   ` [Buildroot] [RFC v2 13/14] configs: switch hexagon QEMU to SHARED Brian Cain via buildroot
2025-02-05 11:30     ` Thomas Petazzoni via buildroot
2024-12-19  5:30   ` [Buildroot] [RFC v2 14/14] package: disable -ztext Brian Cain via buildroot
2025-02-05 11:33     ` Thomas Petazzoni
2025-02-05 10:49   ` [Buildroot] [RFC v2 00/14] add hexagon architecture Thomas Petazzoni via buildroot
2025-03-10  0:44     ` Brian Cain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250205115814.3a75066d@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=brian.cain@oss.qualcomm.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox