Re: [Buildroot] [RFC v2 03/14] toolchain/toolchain-external: add hexagon support for toolchain-wrapper

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Wed, 18 Dec 2024 21:30:42 -0800
Brian Cain via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>

This commit needs a non-empty commit message. Also, I don't think this
commit is really hexagon related, but more Clang related.

> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index c08bf0a653..d45f2c54de 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -150,8 +150,14 @@ endef
>  endif
>  
>  ifeq ($(BR2_TOOLCHAIN_EXTERNAL_MUSL),y)
> +ifeq ($(BR2_hexagon),y)
> +TOOLCHAIN_EXTERNAL_LIBS += libc.so libclang_rt.builtins-hexagon.so*
> +TOOLCHAIN_EXTERNAL_LIBS += libc++.so* libc++abi.so* libunwind.so*
> +TOOLCHAIN_EXTERNAL_LIBS += ld-musl-*.so*

None of this is hexagon related, to this exception of
libclang_rt.builtins-hexagon.so*. So this should be organized properly,
with I guess libc++.so* libc++abi.so* being added when
BR2_TOOLCHAIN_EXTERNAL_CLANG=y. Perhaps
libclang_rt.builtins-$(BR2_ARCH).so* as well.

I'm not sure about libunwind.so*. Also unclear why ld-musl-*.so* is
needed here, and not for other musl toolchains. To be clarified.

> +else
>  TOOLCHAIN_EXTERNAL_LIBS += libc.so
>  endif
> +endif
>  
>  ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
>  TOOLCHAIN_EXTERNAL_LIBS += libstdc++.so.*
> @@ -283,7 +289,7 @@ define TOOLCHAIN_EXTERNAL_INSTALL_WRAPPER
>  		*-ar|*-ranlib|*-nm) \
>  			ln -sf $$(echo $$i | sed 's%^$(HOST_DIR)%..%') .; \
>  			;; \
> -		*cc|*cc-*|*++|*++-*|*cpp|*-gfortran|*-gdc) \
> +		*cc|*cc-*|*++|*++-*|*cpp|*-gfortran|*-gdc|*clang) \

Related to clang support.

>  			ln -sf toolchain-wrapper $$base; \
>  			;; \
>  		*gdb|*gdbtui) \
> @@ -465,6 +471,9 @@ define TOOLCHAIN_EXTERNAL_INSTALL_SYSROOT_LIBS
>  	else \
>  		ARCH_SUBDIR=`echo $${ARCH_SYSROOT_DIR} | sed -r -e "s:^$${SYSROOT_DIR}(.*)/$$:\1:"` ; \
>  	fi ; \
> +	if test "$(BR2_hexagon)" = "y"; then \
> +		SUPPORT_LIB_DIR=$(TOOLCHAIN_EXTERNAL_BIN)/../target/$(TOOLCHAIN_EXTERNAL_PREFIX); \
> +	fi ; \

Is this really hexagon specific? Or specific to Clang? Or specific to
the particular external toolchain? I'm pretty sure the BR2_hexagon
condition is incorrect here.

Are there other Clang external toolchains, for other CPU architectures,
that we could use to test what is generic Clang stuff vs. what is
perhaps Hexagon-specific?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot