Re: [Buildroot] [RFC v2 05/14] toolchain/toolchain-external: skip "-march=" for hexagon

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brian Cain via buildroot <buildroot@buildroot.org>
Cc: Brian Cain <brian.cain@oss.qualcomm.com>
Subject: Re: [Buildroot] [RFC v2 05/14] toolchain/toolchain-external: skip "-march=" for hexagon
Date: Wed, 5 Feb 2025 12:03:02 +0100	[thread overview]
Message-ID: <20250205120302.51583465@windsurf> (raw)
In-Reply-To: <20241219053053.2389046-6-brian.cain@oss.qualcomm.com>

On Wed, 18 Dec 2024 21:30:44 -0800
Brian Cain via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index cc36b0bcfd..44891e638f 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -210,9 +210,11 @@ TOOLCHAIN_EXTERNAL_CFLAGS += -m64
>  TOOLCHAIN_EXTERNAL_TOOLCHAIN_WRAPPER_ARGS += -DBR_64
>  endif
>  ifneq ($(GCC_TARGET_ARCH),)
> +ifneq ($(BR2_hexagon),y)
>  TOOLCHAIN_EXTERNAL_CFLAGS += -march=$(GCC_TARGET_ARCH)
>  TOOLCHAIN_EXTERNAL_TOOLCHAIN_WRAPPER_ARGS += -DBR_ARCH='"$(GCC_TARGET_ARCH)"'
>  endif

Why is this needed? You don't set BR2_GCC_TARGET_ARCH in
arch/Config.in.hexagon, so GCC_TARGET_ARCH should I believe be empty,
and therefore this code should not kick-in.

If not, please clarify, and please have a non-empty commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot