Re: [Buildroot] [RFC v2 10/14] configs: add hexagon QEMU config

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Brian Cain via buildroot <buildroot@buildroot.org>
Cc: Brian Cain <brian.cain@oss.qualcomm.com>
Subject: Re: [Buildroot] [RFC v2 10/14] configs: add hexagon QEMU config
Date: Wed, 5 Feb 2025 12:26:09 +0100	[thread overview]
Message-ID: <20250205122609.054fe9bd@windsurf> (raw)
In-Reply-To: <20241219053053.2389046-11-brian.cain@oss.qualcomm.com>

Hello Brian,

On Wed, 18 Dec 2024 21:30:49 -0800
Brian Cain via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>

Nice to see that there is Qemu support! Is this supported in upstream
Qemu?

> diff --git a/configs/qcom_dsp_qemu_defconfig b/configs/qcom_dsp_qemu_defconfig
> new file mode 100644
> index 0000000000..cc9b7157ad
> --- /dev/null
> +++ b/configs/qcom_dsp_qemu_defconfig
> @@ -0,0 +1,44 @@
> +BR2_hexagon=y
> +BR2_HEXAGON_v73=y
> +BR2_STATIC_LIBS=y

This is changed in a follow-up patch, which isn't good, please use the
correct setting from the start.

> +BR2_TOOLCHAIN_EXTERNAL=y
> +BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y

Why don't you use the toolchain-external-hexagon package here?

> +BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
> +BR2_ROOTFS_DEVICE_CREATION_STATIC=y

We really want to use the default for this.

> +BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
> +BR2_PACKAGE_BZIP2=y
> +BR2_PACKAGE_ZLIB=y
> +BR2_PACKAGE_LOCKDEV=n
> +BR2_PACKAGE_LIBEVENT=n
> +BR2_PACKAGE_ATFTP=n
> +BR2_PACKAGE_DROPBEAR=y
> +BR2_PACKAGE_LSH=y
> +
> +BR2_PACKAGE_BASH=y
> +BR2_PACKAGE_ZSH=y
> +
> +BR2_PACKAGE_LIQUID_DSP=y
> +BR2_PACKAGE_GNURADIO_FFT=y
> +
> +BR2_PACKAGE_XINETD=n
> +BR2_PACKAGE_COREUTILS=y
> +BR2_PACKAGE_HEXAGONMVM=y

Please remove all of this custom package selection, except
BR2_PACKAGE_HEXAGONMVM=y maybe if it's really needed for the platform
to boot.

> +BR2_TARGET_ROOTFS_TAR_GZIP=y
> +BR2_TARGET_ROOTFS_INITRAMFS=y
> +
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.kernel.org/pub/scm/linux/kernel/git/bcain/linux.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="bcain/boot_qemu_v6.11"

Is this a branch or a target? We don't want to use a branch.

> +BR2_LINUX_KERNEL_DEFCONFIG="qemu"
> +

Also, please add a board/qemu/ directory for this configuration, with a
readme.txt. In particular, the readme.txt should include the exact Qemu
command line to use to boot the system.

> diff --git a/linux/linux.hash b/linux/linux.hash
> index ccf6235166..3c5eaea676 100644
> --- a/linux/linux.hash
> +++ b/linux/linux.hash
> @@ -9,6 +9,7 @@ sha256  0d0ffae5bf0e6f9c6a1ce42da2bc2a8696ca55721c103497eb1245be8cc04b20  linux-
>  # Locally computed
>  sha256  fb0edc3c18e47d2b6974cb0880a0afb5c3fa08f50ee87dfdf24349405ea5f8ae  linux-cip-5.10.162-cip24.tar.gz
>  sha256  b5539243f187e3d478d76d44ae13aab83952c94b885ad889df6fa9997e16a441  linux-cip-5.10.162-cip24-rt10.tar.gz
> +sha256  a97a6fdc814b57b15107139978369d4efd1474142911e8f76b050874cc9ee3e4  linux-bcain_boot_qemu_v6.11-git4.tar.gz

Nope, you cannot "pollute" linux/linux.hash with your custom hash. Look
at other defconfigs, they use BR2_GLOBAL_PATCH_DIRECTORY to provide
additional hash files.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot