* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
@ 2014-02-21 21:00 Romain Naour
2014-02-21 22:57 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Romain Naour @ 2014-02-21 21:00 UTC (permalink / raw)
To: buildroot
The cross-compilation test is based on the ability to run
a test program on the host, which is wrong.
If it runs, then the configure script concludes
that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.
The configure script needs to be regenerated to fix the
cross-compilation test.
Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
package/ncftp/ncftp.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
index ff6c70a..841c82b 100644
--- a/package/ncftp/ncftp.mk
+++ b/package/ncftp/ncftp.mk
@@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
NCFTP_LICENSE = Clarified Artistic License
NCFTP_LICENSE_FILES = doc/LICENSE.txt
+NCFTP_DEPENDENCIES = host-autoconf
+
+define NCFTP_RUN_AUTOCONF
+ (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
+endef
+
+NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
+
ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
NCFTP_TARGET_BINS += ncftpget
endif
--
1.8.5.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-21 21:00 [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test Romain Naour
@ 2014-02-21 22:57 ` Thomas Petazzoni
2014-02-21 23:41 ` Peter Korsgaard
2014-02-23 22:23 ` Arnout Vandecappelle
2 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2014-02-21 22:57 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Fri, 21 Feb 2014 22:00:52 +0100, Romain Naour wrote:
> The cross-compilation test is based on the ability to run
> a test program on the host, which is wrong.
>
> If it runs, then the configure script concludes
> that we're doing native compilation,
> if it doesn't run, we're doing cross-compilation.
>
> The configure script needs to be regenerated to fix the
> cross-compilation test.
>
> Fixes
> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/ncftp/ncftp.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-21 21:00 [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test Romain Naour
2014-02-21 22:57 ` Thomas Petazzoni
@ 2014-02-21 23:41 ` Peter Korsgaard
2014-02-23 22:23 ` Arnout Vandecappelle
2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2014-02-21 23:41 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:
> The cross-compilation test is based on the ability to run
> a test program on the host, which is wrong.
> If it runs, then the configure script concludes
> that we're doing native compilation,
> if it doesn't run, we're doing cross-compilation.
> The configure script needs to be regenerated to fix the
> cross-compilation test.
> Fixes
> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-21 21:00 [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test Romain Naour
2014-02-21 22:57 ` Thomas Petazzoni
2014-02-21 23:41 ` Peter Korsgaard
@ 2014-02-23 22:23 ` Arnout Vandecappelle
2014-02-23 22:52 ` Romain Naour
2 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2014-02-23 22:23 UTC (permalink / raw)
To: buildroot
On 02/21/14 22:00, Romain Naour wrote:
> The cross-compilation test is based on the ability to run
> a test program on the host, which is wrong.
>
> If it runs, then the configure script concludes
> that we're doing native compilation,
> if it doesn't run, we're doing cross-compilation.
>
> The configure script needs to be regenerated to fix the
> cross-compilation test.
>
> Fixes
> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/ncftp/ncftp.mk | 8 ++++++++
Looks like the patch file itself got lost in this revision...
Regards,
Arnout
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
> index ff6c70a..841c82b 100644
> --- a/package/ncftp/ncftp.mk
> +++ b/package/ncftp/ncftp.mk
> @@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
> NCFTP_LICENSE = Clarified Artistic License
> NCFTP_LICENSE_FILES = doc/LICENSE.txt
>
> +NCFTP_DEPENDENCIES = host-autoconf
> +
> +define NCFTP_RUN_AUTOCONF
> + (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
> +endef
> +
> +NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
> +
> ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
> NCFTP_TARGET_BINS += ncftpget
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-23 22:23 ` Arnout Vandecappelle
@ 2014-02-23 22:52 ` Romain Naour
2014-02-25 17:13 ` Arnout Vandecappelle
0 siblings, 1 reply; 8+ messages in thread
From: Romain Naour @ 2014-02-23 22:52 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :
> On 02/21/14 22:00, Romain Naour wrote:
>> The cross-compilation test is based on the ability to run
>> a test program on the host, which is wrong.
>>
>> If it runs, then the configure script concludes
>> that we're doing native compilation,
>> if it doesn't run, we're doing cross-compilation.
>>
>> The configure script needs to be regenerated to fix the
>> cross-compilation test.
>>
>> Fixes
>> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> package/ncftp/ncftp.mk | 8 ++++++++
> Looks like the patch file itself got lost in this revision...
Thanks to the advice of ThomasP, the patch file is no longer necessary
since the configure script is regenerated correctly by autoconf.
I tested this patch in the same conditions as for ncftp build errors
(with a chrootwhere ncurses was not installed on the host)
Best regards,
Romain
>
>
> Regards,
> Arnout
>
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
>> index ff6c70a..841c82b 100644
>> --- a/package/ncftp/ncftp.mk
>> +++ b/package/ncftp/ncftp.mk
>> @@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
>> NCFTP_LICENSE = Clarified Artistic License
>> NCFTP_LICENSE_FILES = doc/LICENSE.txt
>>
>> +NCFTP_DEPENDENCIES = host-autoconf
>> +
>> +define NCFTP_RUN_AUTOCONF
>> + (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
>> +endef
>> +
>> +NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
>> +
>> ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
>> NCFTP_TARGET_BINS += ncftpget
>> endif
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-23 22:52 ` Romain Naour
@ 2014-02-25 17:13 ` Arnout Vandecappelle
2014-02-26 21:05 ` Romain Naour
0 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2014-02-25 17:13 UTC (permalink / raw)
To: buildroot
On 23/02/14 23:52, Romain Naour wrote:
> Hi Arnout,
> Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :
>> On 02/21/14 22:00, Romain Naour wrote:
>>> The cross-compilation test is based on the ability to run
>>> a test program on the host, which is wrong.
>>>
>>> If it runs, then the configure script concludes
>>> that we're doing native compilation,
>>> if it doesn't run, we're doing cross-compilation.
>>>
>>> The configure script needs to be regenerated to fix the
>>> cross-compilation test.
>>>
>>> Fixes
>>> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>>>
>>>
>>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>>> ---
>>> package/ncftp/ncftp.mk | 8 ++++++++
>> Looks like the patch file itself got lost in this revision...
>
> Thanks to the advice of ThomasP, the patch file is no longer necessary
> since the configure script is regenerated correctly by autoconf.
> I tested this patch in the same conditions as for ncftp build errors
> (with a chrootwhere ncurses was not installed on the host)
OK, now I understand.
I'm going to send a follow-up patch to clarify this. Otherwise, an
eventual version bumper will have a hard time understanding what is going on.
Regards,
Arnout
>
> Best regards,
> Romain
>
>>
>>
>> Regards,
>> Arnout
>>
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
>>> index ff6c70a..841c82b 100644
>>> --- a/package/ncftp/ncftp.mk
>>> +++ b/package/ncftp/ncftp.mk
>>> @@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
>>> NCFTP_LICENSE = Clarified Artistic License
>>> NCFTP_LICENSE_FILES = doc/LICENSE.txt
>>> +NCFTP_DEPENDENCIES = host-autoconf
>>> +
>>> +define NCFTP_RUN_AUTOCONF
>>> + (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
>>> +endef
>>> +
>>> +NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
>>> +
>>> ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
>>> NCFTP_TARGET_BINS += ncftpget
>>> endif
>>>
>>
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-25 17:13 ` Arnout Vandecappelle
@ 2014-02-26 21:05 ` Romain Naour
2014-02-26 21:23 ` Arnout Vandecappelle
0 siblings, 1 reply; 8+ messages in thread
From: Romain Naour @ 2014-02-26 21:05 UTC (permalink / raw)
To: buildroot
Hi Arnout, All
Le 25/02/2014 18:13, Arnout Vandecappelle a ?crit :
> On 23/02/14 23:52, Romain Naour wrote:
>> Hi Arnout,
>> Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :
>>> On 02/21/14 22:00, Romain Naour wrote:
>>>> The cross-compilation test is based on the ability to run
>>>> a test program on the host, which is wrong.
>>>>
>>>> If it runs, then the configure script concludes
>>>> that we're doing native compilation,
>>>> if it doesn't run, we're doing cross-compilation.
>>>>
>>>> The configure script needs to be regenerated to fix the
>>>> cross-compilation test.
>>>>
>>>> Fixes
>>>> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>>>>
>>>>
>>>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>>>> ---
>>>> package/ncftp/ncftp.mk | 8 ++++++++
>>> Looks like the patch file itself got lost in this revision...
>> Thanks to the advice of ThomasP, the patch file is no longer necessary
>> since the configure script is regenerated correctly by autoconf.
>> I tested this patch in the same conditions as for ncftp build errors
>> (with a chrootwhere ncurses was not installed on the host)
> OK, now I understand.
>
> I'm going to send a follow-up patch to clarify this. Otherwise, an
> eventual version bumper will have a hard time understanding what is going on.
>
You are right, the problem is not obvious and
I should have written a comment in addition to the commit log.
I wonder if any other packages can be affected by this issue ?
At least we know that autoconf 2.13 is not safe for cross-compilation...
Thank you for clarifying this issue :)
Best regards,
Romain
>>>> 1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
>>>> index ff6c70a..841c82b 100644
>>>> --- a/package/ncftp/ncftp.mk
>>>> +++ b/package/ncftp/ncftp.mk
>>>> @@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
>>>> NCFTP_LICENSE = Clarified Artistic License
>>>> NCFTP_LICENSE_FILES = doc/LICENSE.txt
>>>> +NCFTP_DEPENDENCIES = host-autoconf
>>>> +
>>>> +define NCFTP_RUN_AUTOCONF
>>>> + (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
>>>> +endef
>>>> +
>>>> +NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
>>>> +
>>>> ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
>>>> NCFTP_TARGET_BINS += ncftpget
>>>> endif
>>>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
2014-02-26 21:05 ` Romain Naour
@ 2014-02-26 21:23 ` Arnout Vandecappelle
0 siblings, 0 replies; 8+ messages in thread
From: Arnout Vandecappelle @ 2014-02-26 21:23 UTC (permalink / raw)
To: buildroot
On 26/02/14 22:05, Romain Naour wrote:
> I wonder if any other packages can be affected by this issue ?
> At least we know that autoconf 2.13 is not safe for cross-compilation...
The first autoconf version after 2.13 is 2.50, and this solves the
cross-compilation issue (see release notes). 2.50 was released on May 21,
2001. Seems unlikely that there are many packages that are distributed
with such an ancient autoconf...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-02-26 21:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 21:00 [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test Romain Naour
2014-02-21 22:57 ` Thomas Petazzoni
2014-02-21 23:41 ` Peter Korsgaard
2014-02-23 22:23 ` Arnout Vandecappelle
2014-02-23 22:52 ` Romain Naour
2014-02-25 17:13 ` Arnout Vandecappelle
2014-02-26 21:05 ` Romain Naour
2014-02-26 21:23 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox