[Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary

[Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=11dbb615338cd768acc2c3138064ddf557e9b60b
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Packages shouldn't strip executables by themselves, so that Buildroot
controls whether stripping should occur or not. This also fixes the
build on Blackfin FLAT where stripping actually doesn't work because
stripping FLAT binaries is not supported.

Fixes:

  http://autobuild.buildroot.org/results/7d4/7d4e59c96928a06db5091235bf2eacf462ba8a21/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/hdparm/hdparm.mk |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/hdparm/hdparm.mk b/package/hdparm/hdparm.mk
index 1a200fb..0ca3c39 100644
--- a/package/hdparm/hdparm.mk
+++ b/package/hdparm/hdparm.mk
@@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
 define HDPARM_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
 		CFLAGS="$(TARGET_CFLAGS)" \
-		LDFLAGS="$(TARGET_LDFLAGS)"
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		STRIP=/bin/true
 endef
 
 define HDPARM_INSTALL_TARGET_CMDS

[Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary

[Arnout Vandecappelle]

On 06/11/14 23:03, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=11dbb615338cd768acc2c3138064ddf557e9b60b
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> Packages shouldn't strip executables by themselves, so that Buildroot
> controls whether stripping should occur or not. This also fixes the
> build on Blackfin FLAT where stripping actually doesn't work because
> stripping FLAT binaries is not supported.
> 
> Fixes:
> 
>   http://autobuild.buildroot.org/results/7d4/7d4e59c96928a06db5091235bf2eacf462ba8a21/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/hdparm/hdparm.mk |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/package/hdparm/hdparm.mk b/package/hdparm/hdparm.mk
> index 1a200fb..0ca3c39 100644
> --- a/package/hdparm/hdparm.mk
> +++ b/package/hdparm/hdparm.mk
> @@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
>  define HDPARM_BUILD_CMDS
>  	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
>  		CFLAGS="$(TARGET_CFLAGS)" \
> -		LDFLAGS="$(TARGET_LDFLAGS)"
> +		LDFLAGS="$(TARGET_LDFLAGS)" \
> +		STRIP=/bin/true

 Perhaps for consistency we should rename $(TARGET_CROSS)strip to
$(TARGET_CROSS)real-strip and symlink $(TARGET_CROSS)strip to /bin/true?

 While looking at this, I also notice that in some cases we _do_ pass the real
strip, e.g. in fltk, qt (but not qt5). I guess that's historical accident?

 Regards,
 Arnout

>  endef
>  
>  define HDPARM_INSTALL_TARGET_CMDS
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 06/11/14 23:03, Peter Korsgaard wrote:

 >> +++ b/package/hdparm/hdparm.mk
 >> @@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
 >> define HDPARM_BUILD_CMDS
 >> $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
 >> CFLAGS="$(TARGET_CFLAGS)" \
 >> -		LDFLAGS="$(TARGET_LDFLAGS)"
 >> +		LDFLAGS="$(TARGET_LDFLAGS)" \
 >> +		STRIP=/bin/true

 >  Perhaps for consistency we should rename $(TARGET_CROSS)strip to
 > $(TARGET_CROSS)real-strip and symlink $(TARGET_CROSS)strip to /bin/true?

Most of these packages presumably default to 'strip' and not
'$(TARGET_CROSS)strip', so it won't help much.

 >  While looking at this, I also notice that in some cases we _do_ pass the real
 > strip, e.g. in fltk, qt (but not qt5). I guess that's historical accident?

I would think so. For fltk atleast it dates back from 2008. I'll take a
look at fixing it up, thanks.

-- 
Bye, Peter Korsgaard 

[Buildroot] [git commit] hdparm: prevent package makefile from stripping the hdparm binary

[Arnout Vandecappelle]

On 06/16/14 09:24, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> 
>  > On 06/11/14 23:03, Peter Korsgaard wrote:
> 
>  >> +++ b/package/hdparm/hdparm.mk
>  >> @@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
>  >> define HDPARM_BUILD_CMDS
>  >> $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
>  >> CFLAGS="$(TARGET_CFLAGS)" \
>  >> -		LDFLAGS="$(TARGET_LDFLAGS)"
>  >> +		LDFLAGS="$(TARGET_LDFLAGS)" \
>  >> +		STRIP=/bin/true
> 
>  >  Perhaps for consistency we should rename $(TARGET_CROSS)strip to
>  > $(TARGET_CROSS)real-strip and symlink $(TARGET_CROSS)strip to /bin/true?
> 
> Most of these packages presumably default to 'strip' and not
> '$(TARGET_CROSS)strip', so it won't help much.

 Well, at least autotools-based packages will use ${ac_tool_prefix}strip so
they'll refer to the proper strip. And for the really broken packages, we can
symlink $(HOST_DIR)/usr/bin/strip as well. Although, on second thought that may
not be such a good idea since we may want to strip host packages.


 Regards,
 Arnout

>  >  While looking at this, I also notice that in some cases we _do_ pass the real
>  > strip, e.g. in fltk, qt (but not qt5). I guess that's historical accident?
> 
> I would think so. For fltk atleast it dates back from 2008. I'll take a
> look at fixing it up, thanks.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F