[Buildroot] [PATCH] bandwidthd: fix static build

[Nathaniel Roach <nroach44@gmail.com>]

On 02/10/14 15:58, Baruch Siach wrote:
> Hi Nathaniel,
> 
> On Thu, Oct 02, 2014 at 03:56:08PM +0800, Nathaniel Roach wrote:
>> On 02/10/14 15:52, Baruch Siach wrote:
>>> Hi Nathaniel,
>>>
>>> On Thu, Oct 02, 2014 at 03:29:18PM +0800, Nathaniel Roach wrote:
>>>> On 02/10/14 14:49, Baruch Siach wrote:
>>>>> Build against libpng requires -lz when built statically. Patch configure.ac to
>>>>> get the needed information from pkg-config.
>>>>>
>>>>> This patch can not be directly upstreamed as it conflicts with upstream
>>>>> changes, but a proper fix would be based on the same idea.
>>>>>
>>>>> Fixes:
>>>>> http://autobuild.buildroot.net/results/e49/e496cc4315c06de61379222d3e842d4cd05b2f71/
>>>>>
>>>>> Cc: Nathaniel Roach <nroach44@gmail.com>
>>>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>>>>> ---
>>>> Hi Baruch, I've already put a patch through [1] that bumps the version
>>>> in BR, which AFAIK fixes the issues that we've had on the autobuilders.
>>>
>>> Well, I should have been aware to this patch since it seems I also commented 
>>> on it, but I forgot. I still think this is the right solution, since it would 
>>> also work if libpng changes its dependencies. Assuming, of course, that 
>>> bandwidthd doesn't use libz directly.
>>>
>>> Note that I also tried to upgrade to -r10, but build fails with this specific 
>>> non-thread defconfig because bandwidthd now requires a toolchain supporting 
>>> -lpthread. So technically this specific configuration is still broken after 
>>> applying http://patchwork.ozlabs.org/patch/381899/.
>>>
>>> baruch
>>>
>>>> I'm not sure what to do in this situation but I thought I'd just note
>>>> this here in case my patch had been forgotten.
>>>>
>>>> [1] http://patchwork.ozlabs.org/patch/381899/
>>
>> I do vaguely remember some issue with -lpthread, could you send me the
>> config?
>>
>> (It was a while ago, but I'm sure I tested the patch with a basic ARM
>> config, and IIRC I had the -lpthread issue once or twice but was never
>> able to reproduce it after my patch)
> 
> Get the config from 
> http://autobuild.buildroot.net/results/e49/e496cc4315c06de61379222d3e842d4cd05b2f71/config.
> 
> baruch
> 

After testing that, you are indeed correct.

I've gone through the emails from a while ago and it's something like this:

Bandwidthd needs libpcap.
If libpcap was compiled with libusb that needs to be checked for/handled.
And if libusb was used apparently /that/ is what needs pthreads, thus
adding an additional dependency on the configure.ac.

I'm not sure why I added a hard pass/fail check for lpthread, as I would
have thought I've done it like I handled like the lpng/zlib issue...

I'll have a play around and see what I can do.

Nathaniel Roach.