Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nathaniel Roach <nroach44@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bandwidthd: fix static build
Date: Fri, 03 Oct 2014 14:35:19 +0800	[thread overview]
Message-ID: <542E43A7.6080003@gmail.com> (raw)
In-Reply-To: <20141002083349.GI3006@sapphire.tkos.co.il>

On 02/10/14 16:33, Baruch Siach wrote:
> Hi Nathaniel,
> 
> On Thu, Oct 02, 2014 at 04:24:41PM +0800, Nathaniel Roach wrote:
>> On 02/10/14 15:58, Baruch Siach wrote:
>>> On Thu, Oct 02, 2014 at 03:56:08PM +0800, Nathaniel Roach wrote:
>>>> I do vaguely remember some issue with -lpthread, could you send me the
>>>> config?
>>>>
>>>> (It was a while ago, but I'm sure I tested the patch with a basic ARM
>>>> config, and IIRC I had the -lpthread issue once or twice but was never
>>>> able to reproduce it after my patch)
>>>
>>> Get the config from 
>>> http://autobuild.buildroot.net/results/e49/e496cc4315c06de61379222d3e842d4cd05b2f71/config.
>>
>> After testing that, you are indeed correct.
>>
>> I've gone through the emails from a while ago and it's something like this:
>>
>> Bandwidthd needs libpcap.
>> If libpcap was compiled with libusb that needs to be checked for/handled.
>> And if libusb was used apparently /that/ is what needs pthreads, thus
>> adding an additional dependency on the configure.ac.
>>
>> I'm not sure why I added a hard pass/fail check for lpthread, as I would
>> have thought I've done it like I handled like the lpng/zlib issue...
>>
>> I'll have a play around and see what I can do.
> 
> The libpcap package provides the helpful pcap-config utility that is more or 
> less equivalent to pkg-config. grep pcap-config in buildroot to see how it is 
> being used to fix static build problems.
> 
> baruch
> 

Hi Baruch, I didn't end up using pcap-config, but could you check git
version 4b07a0b3d3a280cdde582060cb29f3333ba4bf6e for me? It seems to
work in the config you pasted above and I haven't had any issues in my
other tests.

Thanks, Nathaniel

  reply	other threads:[~2014-10-03  6:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02  6:49 [Buildroot] [PATCH] bandwidthd: fix static build Baruch Siach
     [not found] ` <542CFECE.9020103@gmail.com>
2014-10-02  7:52   ` Baruch Siach
2014-10-02  7:56     ` Nathaniel Roach
2014-10-02  7:58       ` Baruch Siach
2014-10-02  8:24         ` Nathaniel Roach
2014-10-02  8:33           ` Baruch Siach
2014-10-03  6:35             ` Nathaniel Roach [this message]
2014-10-05  4:50               ` Baruch Siach
2014-10-05 12:40                 ` Thomas Petazzoni
2014-10-05 13:01                   ` Nathaniel Roach
2014-10-05 13:12                     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542E43A7.6080003@gmail.com \
    --to=nroach44@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox