[Buildroot] [PATCH 0/3] kyua: new package and dependencies

[Buildroot] [PATCH 0/3] kyua: new package and dependencies

[Sebastien Bourdelin]

This patchset introduces the Kyua testing framework with its
dependencies.

https://github.com/jmmv/kyua

Sebastien Bourdelin (3):
  atf: new package
  lutok: new package
  kyua: new package

 package/Config.in       |  3 +++
 package/atf/Config.in   | 11 +++++++++++
 package/atf/atf.hash    |  2 ++
 package/atf/atf.mk      | 21 +++++++++++++++++++++
 package/kyua/Config.in  | 18 ++++++++++++++++++
 package/kyua/kyua.hash  |  2 ++
 package/kyua/kyua.mk    | 26 ++++++++++++++++++++++++++
 package/lutok/Config.in | 11 +++++++++++
 package/lutok/lutok.mk  | 19 +++++++++++++++++++
 9 files changed, 113 insertions(+)
 create mode 100644 package/atf/Config.in
 create mode 100644 package/atf/atf.hash
 create mode 100644 package/atf/atf.mk
 create mode 100644 package/kyua/Config.in
 create mode 100644 package/kyua/kyua.hash
 create mode 100644 package/kyua/kyua.mk
 create mode 100644 package/lutok/Config.in
 create mode 100644 package/lutok/lutok.mk

-- 
2.4.0

[Buildroot] [PATCH 1/3] atf: new package

[Sebastien Bourdelin]

ATF, or Automated Testing Framework, is a collection of libraries to
write test programs in C, C++ and POSIX shell.

https://github.com/jmmv/atf

Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
 package/Config.in     |  1 +
 package/atf/Config.in | 11 +++++++++++
 package/atf/atf.hash  |  2 ++
 package/atf/atf.mk    | 21 +++++++++++++++++++++
 4 files changed, 35 insertions(+)
 create mode 100644 package/atf/Config.in
 create mode 100644 package/atf/atf.hash
 create mode 100644 package/atf/atf.mk

diff --git a/package/Config.in b/package/Config.in
index e0c2e2a..78ed223 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -57,6 +57,7 @@ endif
 endmenu
 
 menu "Debugging, profiling and benchmark"
+	source "package/atf/Config.in"
 	source "package/blktrace/Config.in"
 	source "package/bonnie/Config.in"
 	source "package/cache-calibrator/Config.in"
diff --git a/package/atf/Config.in b/package/atf/Config.in
new file mode 100644
index 0000000..59712ab
--- /dev/null
+++ b/package/atf/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_ATF
+	bool "atf"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  ATF, or Automated Testing Framework, is a collection of
+	  libraries to write test programs in C, C++ and POSIX shell.
+
+	  https://github.com/jmmv/atf
+
+comment "atf needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/atf/atf.hash b/package/atf/atf.hash
new file mode 100644
index 0000000..cd929b8
--- /dev/null
+++ b/package/atf/atf.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 3677cf957d7f574835b8bdd385984ba928d5695b3ff28f958e4227f810483ab7 atf-0.20.tar.gz
diff --git a/package/atf/atf.mk b/package/atf/atf.mk
new file mode 100644
index 0000000..af691f5
--- /dev/null
+++ b/package/atf/atf.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# atf
+#
+################################################################################
+
+ATF_VERSION = 0.20
+ATF_SOURCE = atf-$(ATF_VERSION).tar.gz
+ATF_SITE = https://github.com/jmmv/atf/archive
+ATF_DEPENDENCIES = host-pkgconf
+ATF_AUTORECONF = YES
+ATF_INSTALL_STAGING = YES
+ATF_LICENSE = BSD
+ATF_LICENSE_FILES = COPYING
+ATF_CONF_ENV = \
+	kyua_cv_getopt_plus=yes \
+	kyua_cv_attribute_noreturn=yes \
+	kyua_cv_getcwd_works=yes \
+	ATF_SHELL=/bin/sh # default is /usr/bin/bash
+
+$(eval $(autotools-package))
-- 
2.4.0

[Buildroot] [PATCH 2/3] lutok: new package

[Sebastien Bourdelin]

Lutok is a lightweight C++ API library for Lua.

https://github.com/jmmv/lutok

Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
 package/Config.in       |  1 +
 package/lutok/Config.in | 11 +++++++++++
 package/lutok/lutok.mk  | 19 +++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/lutok/Config.in
 create mode 100644 package/lutok/lutok.mk

diff --git a/package/Config.in b/package/Config.in
index 78ed223..628f36c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -457,6 +457,7 @@ endif
 	source "package/lua/Config.in"
 	source "package/luainterpreter/Config.in"
 	source "package/luajit/Config.in"
+	source "package/lutok/Config.in"
 if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
 # lua modules are dynamically loaded, so not available on static builds
 menu "Lua libraries/modules"
diff --git a/package/lutok/Config.in b/package/lutok/Config.in
new file mode 100644
index 0000000..b94c093
--- /dev/null
+++ b/package/lutok/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LUTOK
+	bool "lutok"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
+	help
+	  Lutok is a lightweight C++ API library for Lua.
+
+	  https://github.com/jmmv/lutok
+
+comment "lutok needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/lutok/lutok.mk b/package/lutok/lutok.mk
new file mode 100644
index 0000000..25f4070
--- /dev/null
+++ b/package/lutok/lutok.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# lutok
+#
+################################################################################
+
+LUTOK_VERSION = 740c34180384520086302f5e107ae0ae37a7e617
+LUTOK_SITE = git://github.com/jmmv/lutok
+LUTOK_AUTORECONF = YES
+LUTOK_INSTALL_STAGING = YES
+LUTOK_DEPENDENCIES = host-pkgconf lua
+LUTOK_LICENSE = BSD
+LUTOK_LICENSE_FILES = COPYING
+
+ifneq ($(BR2_STATIC_LIBS),y)
+LUTOK_MAKE_OPTS = LIBS=-ldl
+endif
+
+$(eval $(autotools-package))
-- 
2.4.0

[Buildroot] [PATCH 3/3] kyua: new package

[Sebastien Bourdelin]

Kyua is a testing framework for infrastructure software, originally
designed to equip BSD-based operating systems with a test suite. This
means that Kyua is lightweight and simple, and that Kyua integrates
well with various build systems and continuous integration frameworks.

https://github.com/jmmv/kyua

Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
---
 package/Config.in      |  1 +
 package/kyua/Config.in | 18 ++++++++++++++++++
 package/kyua/kyua.hash |  2 ++
 package/kyua/kyua.mk   | 26 ++++++++++++++++++++++++++
 4 files changed, 47 insertions(+)
 create mode 100644 package/kyua/Config.in
 create mode 100644 package/kyua/kyua.hash
 create mode 100644 package/kyua/kyua.mk

diff --git a/package/Config.in b/package/Config.in
index 628f36c..3b2a886 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -73,6 +73,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/kexec/Config.in"
 	source "package/kexec-lite/Config.in"
 	source "package/ktap/Config.in"
+	source "package/kyua/Config.in"
 	source "package/latencytop/Config.in"
 	source "package/lmbench/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
diff --git a/package/kyua/Config.in b/package/kyua/Config.in
new file mode 100644
index 0000000..8f86918
--- /dev/null
+++ b/package/kyua/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_KYUA
+	bool "kyua"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
+	select BR2_PACKAGE_ATF
+	select BR2_PACKAGE_LUTOK
+	select BR2_PACKAGE_SQLITE
+	help
+	  Kyua is a testing framework for infrastructure software,
+	  originally designed to equip BSD-based operating systems
+	  with a test suite. This means that Kyua is lightweight
+	  and simple, and that Kyua integrates well with various build
+	  systems and continuous integration frameworks.
+
+	  https://github.com/jmmv/kyua
+
+comment "kyua needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/kyua/kyua.hash b/package/kyua/kyua.hash
new file mode 100644
index 0000000..1c9e055
--- /dev/null
+++ b/package/kyua/kyua.hash
@@ -0,0 +1,2 @@
+# Locally Calculted
+sha256 55a2e1c5ab28748392cfed3b2783ed381ffe2d0247bca9a9ac19ae94fe029172 kyua-0.11.tar.gz
diff --git a/package/kyua/kyua.mk b/package/kyua/kyua.mk
new file mode 100644
index 0000000..e467d99
--- /dev/null
+++ b/package/kyua/kyua.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# kyua
+#
+################################################################################
+
+KYUA_VERSION = 0.11
+KYUA_SOURCE = kyua-$(KYUA_VERSION).tar.gz
+KYUA_SITE = https://github.com/jmmv/kyua/archive
+KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
+KYUA_AUTORECONF = YES
+KYUA_LICENSE = BSD
+KYUA_LICENSE_FILES = COPYING
+KYUA_CONF_ENV = \
+	kyua_cv_attribute_noreturn=yes \
+	kyua_cv_getcwd_dyn=yes \
+	kyua_cv_lchmod_works=no \
+	kyua_cv_getopt_gnu=yes \
+	kyua_cv_getopt_optind_reset_value=0 \
+	kyua_cv_signals_lastno=15
+
+define KYUA_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
+endef
+
+$(eval $(autotools-package))
-- 
2.4.0

[Buildroot] [PATCH 1/3] atf: new package

[Arnout Vandecappelle]

On 06/03/15 20:47, Sebastien Bourdelin wrote:
> ATF, or Automated Testing Framework, is a collection of libraries to
> write test programs in C, C++ and POSIX shell.
> 
> https://github.com/jmmv/atf
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> ---
>  package/Config.in     |  1 +
>  package/atf/Config.in | 11 +++++++++++
>  package/atf/atf.hash  |  2 ++
>  package/atf/atf.mk    | 21 +++++++++++++++++++++
>  4 files changed, 35 insertions(+)
>  create mode 100644 package/atf/Config.in
>  create mode 100644 package/atf/atf.hash
>  create mode 100644 package/atf/atf.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index e0c2e2a..78ed223 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -57,6 +57,7 @@ endif
>  endmenu
>  
>  menu "Debugging, profiling and benchmark"
> +	source "package/atf/Config.in"
>  	source "package/blktrace/Config.in"
>  	source "package/bonnie/Config.in"
>  	source "package/cache-calibrator/Config.in"
> diff --git a/package/atf/Config.in b/package/atf/Config.in
> new file mode 100644
> index 0000000..59712ab
> --- /dev/null
> +++ b/package/atf/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_ATF
> +	bool "atf"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	help
> +	  ATF, or Automated Testing Framework, is a collection of
> +	  libraries to write test programs in C, C++ and POSIX shell.
> +
> +	  https://github.com/jmmv/atf
> +
> +comment "atf needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/atf/atf.hash b/package/atf/atf.hash
> new file mode 100644
> index 0000000..cd929b8
> --- /dev/null
> +++ b/package/atf/atf.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 3677cf957d7f574835b8bdd385984ba928d5695b3ff28f958e4227f810483ab7 atf-0.20.tar.gz
> diff --git a/package/atf/atf.mk b/package/atf/atf.mk
> new file mode 100644
> index 0000000..af691f5
> --- /dev/null
> +++ b/package/atf/atf.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# atf
> +#
> +################################################################################
> +
> +ATF_VERSION = 0.20

 Why not use 0.21? Seems to be bugfixes only.

> +ATF_SOURCE = atf-$(ATF_VERSION).tar.gz
> +ATF_SITE = https://github.com/jmmv/atf/archive

 There's an uploaded archive at
https://github.com/jmmv/atf/releases/download/atf-0.21/atf-0.21.tar.gz
(same for 0.20). Then you don't need to AUTORECONF. Well, except that it has the
unreleased libtool beta which means that our patch doesn't apply so you need to
to autoreconf after all. But anyway, we prefer the uploaded archive.

 I you use the automatic archive (i.e. the URL you gave), then you can't have a
hash file. Also, you should use the github helper.


> +ATF_DEPENDENCIES = host-pkgconf

 As far as I can see, pkg-config is not used at build time, it's just some of
the tests that need it.

> +ATF_AUTORECONF = YES
> +ATF_INSTALL_STAGING = YES
> +ATF_LICENSE = BSD

 BSD-2c, BSD-3c

> +ATF_LICENSE_FILES = COPYING
> +ATF_CONF_ENV = \
> +	kyua_cv_getopt_plus=yes \
> +	kyua_cv_attribute_noreturn=yes \
> +	kyua_cv_getcwd_works=yes \
> +	ATF_SHELL=/bin/sh # default is /usr/bin/bash

 I think the default is actually the first shell it can find in the host path,
which in _your_ case happens to be /usr/bin/bash.

 Anyway, putting a comment at the end of the line is a bit dangerous, so I'd
rather put this above ATF_CONF_ENV:

# ATF_SHELL defaults to the host's bash
ATF_CONF_ENV = \
	...


 Regards,
 Arnout

> +
> +$(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 2/3] lutok: new package

[Arnout Vandecappelle]

On 06/03/15 20:47, Sebastien Bourdelin wrote:
> Lutok is a lightweight C++ API library for Lua.
> 
> https://github.com/jmmv/lutok
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> ---
>  package/Config.in       |  1 +
>  package/lutok/Config.in | 11 +++++++++++
>  package/lutok/lutok.mk  | 19 +++++++++++++++++++
>  3 files changed, 31 insertions(+)
>  create mode 100644 package/lutok/Config.in
>  create mode 100644 package/lutok/lutok.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 78ed223..628f36c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -457,6 +457,7 @@ endif
>  	source "package/lua/Config.in"
>  	source "package/luainterpreter/Config.in"
>  	source "package/luajit/Config.in"
> +	source "package/lutok/Config.in"
>  if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
>  # lua modules are dynamically loaded, so not available on static builds
>  menu "Lua libraries/modules"
> diff --git a/package/lutok/Config.in b/package/lutok/Config.in
> new file mode 100644
> index 0000000..b94c093
> --- /dev/null
> +++ b/package/lutok/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_LUTOK
> +	bool "lutok"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_PACKAGE_HAS_LUAINTERPRETER

 Did you check if it works with luajit as well?

 Have you checked if it works with STATIC?

> +	help
> +	  Lutok is a lightweight C++ API library for Lua.
> +
> +	  https://github.com/jmmv/lutok
> +
> +comment "lutok needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP

 This should also depend on BR2_PACKAGE_HAS_LUAINTERPRETER

> diff --git a/package/lutok/lutok.mk b/package/lutok/lutok.mk
> new file mode 100644
> index 0000000..25f4070
> --- /dev/null
> +++ b/package/lutok/lutok.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# lutok
> +#
> +################################################################################
> +
> +LUTOK_VERSION = 740c34180384520086302f5e107ae0ae37a7e617

 This is the uploaded 0.4 release, so you can use

https://github.com/jmmv/lutok/releases/download/lutok-0.4/lutok-0.4.tar.gz

instead, avoiding AUTORECONF, and making it possible to add a hash file.

> +LUTOK_SITE = git://github.com/jmmv/lutok
> +LUTOK_AUTORECONF = YES
> +LUTOK_INSTALL_STAGING = YES
> +LUTOK_DEPENDENCIES = host-pkgconf lua

 It seems to have an optional dependency on atf as well, so you need something like

ifeq ($(BR2_PACKAGE_ATF),y)
LUTOK_DEPENDENCIES += atf
LUTOK_CONF_OPTS += --with-atf
else
LUTOK_CONF_OPTS += --without-atf
endif

 Also it tries to use doxygen if available, we don't care about documentation so add
LUTOK_CONF_OPTS = --without-doxygen

> +LUTOK_LICENSE = BSD

 BSD-3c

> +LUTOK_LICENSE_FILES = COPYING
> +
> +ifneq ($(BR2_STATIC_LIBS),y)
> +LUTOK_MAKE_OPTS = LIBS=-ldl

 Is this really needed? The configure script should detect that automatically...


 Regards,
 Arnout

> +endif
> +
> +$(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 3/3] kyua: new package

[Arnout Vandecappelle]

On 06/03/15 20:47, Sebastien Bourdelin wrote:
> Kyua is a testing framework for infrastructure software, originally
> designed to equip BSD-based operating systems with a test suite. This
> means that Kyua is lightweight and simple, and that Kyua integrates
> well with various build systems and continuous integration frameworks.
> 
> https://github.com/jmmv/kyua
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> ---
>  package/Config.in      |  1 +
>  package/kyua/Config.in | 18 ++++++++++++++++++
>  package/kyua/kyua.hash |  2 ++
>  package/kyua/kyua.mk   | 26 ++++++++++++++++++++++++++
>  4 files changed, 47 insertions(+)
>  create mode 100644 package/kyua/Config.in
>  create mode 100644 package/kyua/kyua.hash
>  create mode 100644 package/kyua/kyua.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 628f36c..3b2a886 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -73,6 +73,7 @@ menu "Debugging, profiling and benchmark"
>  	source "package/kexec/Config.in"
>  	source "package/kexec-lite/Config.in"
>  	source "package/ktap/Config.in"
> +	source "package/kyua/Config.in"
>  	source "package/latencytop/Config.in"
>  	source "package/lmbench/Config.in"
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> diff --git a/package/kyua/Config.in b/package/kyua/Config.in
> new file mode 100644
> index 0000000..8f86918
> --- /dev/null
> +++ b/package/kyua/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_KYUA
> +	bool "kyua"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
> +	select BR2_PACKAGE_ATF
> +	select BR2_PACKAGE_LUTOK
> +	select BR2_PACKAGE_SQLITE
> +	help
> +	  Kyua is a testing framework for infrastructure software,
> +	  originally designed to equip BSD-based operating systems
> +	  with a test suite. This means that Kyua is lightweight
> +	  and simple, and that Kyua integrates well with various build
> +	  systems and continuous integration frameworks.
> +
> +	  https://github.com/jmmv/kyua
> +
> +comment "kyua needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP

 Repeat depends on BR2_PACKAGE_HAS_LUAINTERPRETER

> diff --git a/package/kyua/kyua.hash b/package/kyua/kyua.hash
> new file mode 100644
> index 0000000..1c9e055
> --- /dev/null
> +++ b/package/kyua/kyua.hash
> @@ -0,0 +1,2 @@
> +# Locally Calculted
> +sha256 55a2e1c5ab28748392cfed3b2783ed381ffe2d0247bca9a9ac19ae94fe029172 kyua-0.11.tar.gz
> diff --git a/package/kyua/kyua.mk b/package/kyua/kyua.mk
> new file mode 100644
> index 0000000..e467d99
> --- /dev/null
> +++ b/package/kyua/kyua.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# kyua
> +#
> +################################################################################
> +
> +KYUA_VERSION = 0.11
> +KYUA_SOURCE = kyua-$(KYUA_VERSION).tar.gz

 This is the default so not needed (actually for the other two packages as well,
forgot to mention).

> +KYUA_SITE = https://github.com/jmmv/kyua/archive

 Again, there's a release tarball for it.

> +KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
> +KYUA_AUTORECONF = YES
> +KYUA_LICENSE = BSD

 BSD-3c

> +KYUA_LICENSE_FILES = COPYING
> +KYUA_CONF_ENV = \
> +	kyua_cv_attribute_noreturn=yes \
> +	kyua_cv_getcwd_dyn=yes \
> +	kyua_cv_lchmod_works=no \
> +	kyua_cv_getopt_gnu=yes \
> +	kyua_cv_getopt_optind_reset_value=0 \
> +	kyua_cv_signals_lastno=15
> +
> +define KYUA_INSTALL_TARGET_CMDS

 So, you spend all this time building and then don't install anything? I guess
you meant to use a POST_INSTALL_HOOK instead?

 Regards,
 Arnout

> +	$(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
> +endef
> +
> +$(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 1/3] atf: new package

[Sebastien Bourdelin]

Hi Arnout.

On 06/03/2015 05:53 PM, Arnout Vandecappelle wrote:
> On 06/03/15 20:47, Sebastien Bourdelin wrote:
>> ATF, or Automated Testing Framework, is a collection of libraries to
>> write test programs in C, C++ and POSIX shell.
>>
>> https://github.com/jmmv/atf
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
>> ---
>>  package/Config.in     |  1 +
>>  package/atf/Config.in | 11 +++++++++++
>>  package/atf/atf.hash  |  2 ++
>>  package/atf/atf.mk    | 21 +++++++++++++++++++++
>>  4 files changed, 35 insertions(+)
>>  create mode 100644 package/atf/Config.in
>>  create mode 100644 package/atf/atf.hash
>>  create mode 100644 package/atf/atf.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index e0c2e2a..78ed223 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -57,6 +57,7 @@ endif
>>  endmenu
>>  
>>  menu "Debugging, profiling and benchmark"
>> +	source "package/atf/Config.in"
>>  	source "package/blktrace/Config.in"
>>  	source "package/bonnie/Config.in"
>>  	source "package/cache-calibrator/Config.in"
>> diff --git a/package/atf/Config.in b/package/atf/Config.in
>> new file mode 100644
>> index 0000000..59712ab
>> --- /dev/null
>> +++ b/package/atf/Config.in
>> @@ -0,0 +1,11 @@
>> +config BR2_PACKAGE_ATF
>> +	bool "atf"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	help
>> +	  ATF, or Automated Testing Framework, is a collection of
>> +	  libraries to write test programs in C, C++ and POSIX shell.
>> +
>> +	  https://github.com/jmmv/atf
>> +
>> +comment "atf needs a toolchain w/ C++"
>> +	depends on !BR2_INSTALL_LIBSTDCPP
>> diff --git a/package/atf/atf.hash b/package/atf/atf.hash
>> new file mode 100644
>> index 0000000..cd929b8
>> --- /dev/null
>> +++ b/package/atf/atf.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed
>> +sha256 3677cf957d7f574835b8bdd385984ba928d5695b3ff28f958e4227f810483ab7 atf-0.20.tar.gz
>> diff --git a/package/atf/atf.mk b/package/atf/atf.mk
>> new file mode 100644
>> index 0000000..af691f5
>> --- /dev/null
>> +++ b/package/atf/atf.mk
>> @@ -0,0 +1,21 @@
>> +################################################################################
>> +#
>> +# atf
>> +#
>> +################################################################################
>> +
>> +ATF_VERSION = 0.20
>  Why not use 0.21? Seems to be bugfixes only.
You are right, thanks!

>> +ATF_SOURCE = atf-$(ATF_VERSION).tar.gz
>> +ATF_SITE = https://github.com/jmmv/atf/archive
>  There's an uploaded archive at
> https://github.com/jmmv/atf/releases/download/atf-0.21/atf-0.21.tar.gz
> (same for 0.20). Then you don't need to AUTORECONF. Well, except that it has the
> unreleased libtool beta which means that our patch doesn't apply so you need to
> to autoreconf after all. But anyway, we prefer the uploaded archive.
>
>  I you use the automatic archive (i.e. the URL you gave), then you can't have a
> hash file. Also, you should use the github helper.
Ok, i will go for the uploaded archive, do you prefer a comment above
the AUTORECONF to explain it's still required and when it could be
remove, a TODO in fact ?

>> +ATF_DEPENDENCIES = host-pkgconf
>  As far as I can see, pkg-config is not used at build time, it's just some of
> the tests that need it.
I think you are right, it seems to work without pkgconf in my buildroot

>> +ATF_AUTORECONF = YES
>> +ATF_INSTALL_STAGING = YES
>> +ATF_LICENSE = BSD
>  BSD-2c, BSD-3c
Ok.

>> +ATF_LICENSE_FILES = COPYING
>> +ATF_CONF_ENV = \
>> +	kyua_cv_getopt_plus=yes \
>> +	kyua_cv_attribute_noreturn=yes \
>> +	kyua_cv_getcwd_works=yes \
>> +	ATF_SHELL=/bin/sh # default is /usr/bin/bash
>  I think the default is actually the first shell it can find in the host path,
> which in _your_ case happens to be /usr/bin/bash.
You are right.

>  Anyway, putting a comment at the end of the line is a bit dangerous, so I'd
> rather put this above ATF_CONF_ENV:
Right again :)

> # ATF_SHELL defaults to the host's bash
> ATF_CONF_ENV = \
> 	...
>
>
>  Regards,
>  Arnout
>
>> +
>> +$(eval $(autotools-package))
>>

Regards,
Sebastien.

[Buildroot] [PATCH 2/3] lutok: new package

[Sebastien Bourdelin]

Hi Arnout,

On 06/03/2015 06:17 PM, Arnout Vandecappelle wrote:
> On 06/03/15 20:47, Sebastien Bourdelin wrote:
>> Lutok is a lightweight C++ API library for Lua.
>>
>> https://github.com/jmmv/lutok
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
>> ---
>>  package/Config.in       |  1 +
>>  package/lutok/Config.in | 11 +++++++++++
>>  package/lutok/lutok.mk  | 19 +++++++++++++++++++
>>  3 files changed, 31 insertions(+)
>>  create mode 100644 package/lutok/Config.in
>>  create mode 100644 package/lutok/lutok.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 78ed223..628f36c 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -457,6 +457,7 @@ endif
>>  	source "package/lua/Config.in"
>>  	source "package/luainterpreter/Config.in"
>>  	source "package/luajit/Config.in"
>> +	source "package/lutok/Config.in"
>>  if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
>>  # lua modules are dynamically loaded, so not available on static builds
>>  menu "Lua libraries/modules"
>> diff --git a/package/lutok/Config.in b/package/lutok/Config.in
>> new file mode 100644
>> index 0000000..b94c093
>> --- /dev/null
>> +++ b/package/lutok/Config.in
>> @@ -0,0 +1,11 @@
>> +config BR2_PACKAGE_LUTOK
>> +	bool "lutok"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
>  Did you check if it works with luajit as well?
I just try now, and it does not, thanks!

>  Have you checked if it works with STATIC?
Yes

>> +	help
>> +	  Lutok is a lightweight C++ API library for Lua.
>> +
>> +	  https://github.com/jmmv/lutok
>> +
>> +comment "lutok needs a toolchain w/ C++"
>> +	depends on !BR2_INSTALL_LIBSTDCPP
>  This should also depend on BR2_PACKAGE_HAS_LUAINTERPRETER
Ok i was thinking you only want toolchain dependencies here.
Is it ok to write something like that:

comment "lutok needs a Lua 5.1 interpreter or above"
    depends on BR2_INSTALL_LIBSTDCPP && \
        (!BR2_PACKAGE_HAS_LUAINTERPRETER || BR2_PACKAGE_LUAJIT)

>> diff --git a/package/lutok/lutok.mk b/package/lutok/lutok.mk
>> new file mode 100644
>> index 0000000..25f4070
>> --- /dev/null
>> +++ b/package/lutok/lutok.mk
>> @@ -0,0 +1,19 @@
>> +################################################################################
>> +#
>> +# lutok
>> +#
>> +################################################################################
>> +
>> +LUTOK_VERSION = 740c34180384520086302f5e107ae0ae37a7e617
>  This is the uploaded 0.4 release, so you can use
>
> https://github.com/jmmv/lutok/releases/download/lutok-0.4/lutok-0.4.tar.gz
>
> instead, avoiding AUTORECONF, and making it possible to add a hash file.
Great thanks!

>> +LUTOK_SITE = git://github.com/jmmv/lutok
>> +LUTOK_AUTORECONF = YES
>> +LUTOK_INSTALL_STAGING = YES
>> +LUTOK_DEPENDENCIES = host-pkgconf lua
>  It seems to have an optional dependency on atf as well, so you need something like
>
> ifeq ($(BR2_PACKAGE_ATF),y)
> LUTOK_DEPENDENCIES += atf
> LUTOK_CONF_OPTS += --with-atf
> else
> LUTOK_CONF_OPTS += --without-atf
> endif
Ok.

>  Also it tries to use doxygen if available, we don't care about documentation so add
> LUTOK_CONF_OPTS = --without-doxygen
>
Ok.

>> +LUTOK_LICENSE = BSD
>  BSD-3c
Ok.

>> +LUTOK_LICENSE_FILES = COPYING
>> +
>> +ifneq ($(BR2_STATIC_LIBS),y)
>> +LUTOK_MAKE_OPTS = LIBS=-ldl
>  Is this really needed? The configure script should detect that automatically...
Doesn't seem to work without.

>  Regards,
>  Arnout
>
>> +endif
>> +
>> +$(eval $(autotools-package))
>>

Regards,
Sebastien.

[Buildroot] [PATCH 3/3] kyua: new package

[Sebastien Bourdelin]

Hi Arnout,

On 06/03/2015 06:28 PM, Arnout Vandecappelle wrote:
> On 06/03/15 20:47, Sebastien Bourdelin wrote:
>> Kyua is a testing framework for infrastructure software, originally
>> designed to equip BSD-based operating systems with a test suite. This
>> means that Kyua is lightweight and simple, and that Kyua integrates
>> well with various build systems and continuous integration frameworks.
>>
>> https://github.com/jmmv/kyua
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
>> ---
>>  package/Config.in      |  1 +
>>  package/kyua/Config.in | 18 ++++++++++++++++++
>>  package/kyua/kyua.hash |  2 ++
>>  package/kyua/kyua.mk   | 26 ++++++++++++++++++++++++++
>>  4 files changed, 47 insertions(+)
>>  create mode 100644 package/kyua/Config.in
>>  create mode 100644 package/kyua/kyua.hash
>>  create mode 100644 package/kyua/kyua.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 628f36c..3b2a886 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -73,6 +73,7 @@ menu "Debugging, profiling and benchmark"
>>  	source "package/kexec/Config.in"
>>  	source "package/kexec-lite/Config.in"
>>  	source "package/ktap/Config.in"
>> +	source "package/kyua/Config.in"
>>  	source "package/latencytop/Config.in"
>>  	source "package/lmbench/Config.in"
>>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>> diff --git a/package/kyua/Config.in b/package/kyua/Config.in
>> new file mode 100644
>> index 0000000..8f86918
>> --- /dev/null
>> +++ b/package/kyua/Config.in
>> @@ -0,0 +1,18 @@
>> +config BR2_PACKAGE_KYUA
>> +	bool "kyua"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
>> +	select BR2_PACKAGE_ATF
>> +	select BR2_PACKAGE_LUTOK
>> +	select BR2_PACKAGE_SQLITE
>> +	help
>> +	  Kyua is a testing framework for infrastructure software,
>> +	  originally designed to equip BSD-based operating systems
>> +	  with a test suite. This means that Kyua is lightweight
>> +	  and simple, and that Kyua integrates well with various build
>> +	  systems and continuous integration frameworks.
>> +
>> +	  https://github.com/jmmv/kyua
>> +
>> +comment "kyua needs a toolchain w/ C++"
>> +	depends on !BR2_INSTALL_LIBSTDCPP
>  Repeat depends on BR2_PACKAGE_HAS_LUAINTERPRETER
Ok.

>> diff --git a/package/kyua/kyua.hash b/package/kyua/kyua.hash
>> new file mode 100644
>> index 0000000..1c9e055
>> --- /dev/null
>> +++ b/package/kyua/kyua.hash
>> @@ -0,0 +1,2 @@
>> +# Locally Calculted
>> +sha256 55a2e1c5ab28748392cfed3b2783ed381ffe2d0247bca9a9ac19ae94fe029172 kyua-0.11.tar.gz
>> diff --git a/package/kyua/kyua.mk b/package/kyua/kyua.mk
>> new file mode 100644
>> index 0000000..e467d99
>> --- /dev/null
>> +++ b/package/kyua/kyua.mk
>> @@ -0,0 +1,26 @@
>> +################################################################################
>> +#
>> +# kyua
>> +#
>> +################################################################################
>> +
>> +KYUA_VERSION = 0.11
>> +KYUA_SOURCE = kyua-$(KYUA_VERSION).tar.gz
>  This is the default so not needed (actually for the other two packages as well,
> forgot to mention).
Ok.

>> +KYUA_SITE = https://github.com/jmmv/kyua/archive
>  Again, there's a release tarball for it.
Thanks!

>> +KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
>> +KYUA_AUTORECONF = YES
>> +KYUA_LICENSE = BSD
>  BSD-3c
Ok.

>> +KYUA_LICENSE_FILES = COPYING
>> +KYUA_CONF_ENV = \
>> +	kyua_cv_attribute_noreturn=yes \
>> +	kyua_cv_getcwd_dyn=yes \
>> +	kyua_cv_lchmod_works=no \
>> +	kyua_cv_getopt_gnu=yes \
>> +	kyua_cv_getopt_optind_reset_value=0 \
>> +	kyua_cv_signals_lastno=15
>> +
>> +define KYUA_INSTALL_TARGET_CMDS
>  So, you spend all this time building and then don't install anything? I guess
> you meant to use a POST_INSTALL_HOOK instead?
My bad, thanks!

>  Regards,
>  Arnout
>
>> +	$(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
>> +endef
>> +
>> +$(eval $(autotools-package))
>>

I will upload a new patchset,

Regards,
Sebastien.

[Buildroot] [PATCH 1/3] atf: new package

[Arnout Vandecappelle]

On 06/04/15 22:29, Sebastien Bourdelin wrote:
> Hi Arnout.
> 
> On 06/03/2015 05:53 PM, Arnout Vandecappelle wrote:
>> On 06/03/15 20:47, Sebastien Bourdelin wrote:
[snip]
>>> +ATF_SITE = https://github.com/jmmv/atf/archive
>>  There's an uploaded archive at
>> https://github.com/jmmv/atf/releases/download/atf-0.21/atf-0.21.tar.gz
>> (same for 0.20). Then you don't need to AUTORECONF. Well, except that it has the
>> unreleased libtool beta which means that our patch doesn't apply so you need to
>> to autoreconf after all. But anyway, we prefer the uploaded archive.
> Ok, i will go for the uploaded archive, do you prefer a comment above
> the AUTORECONF to explain it's still required and when it could be
> remove, a TODO in fact ?

 Yes, please add a comment like lzo:

# Ships a beta libtool version hence our patch doesn't apply.


 Regards,
 Arnout


[snip]
-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F