From: Mason <slash.tmp@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal
Date: Fri, 16 Sep 2016 12:13:14 +0200 [thread overview]
Message-ID: <57DBC5BA.60803@free.fr> (raw)
In-Reply-To: <20160915212015.761725b7@free-electrons.com>
On 15/09/2016 21:20, Thomas Petazzoni wrote:
> On Thu, 15 Sep 2016 18:19:01 +0200, Arnout Vandecappelle wrote:
>
>> I'm sure I had a reason to add the /*, but I can't remember and the commit
>> message isn't helpful. The only difference (except for keeping the directory)
>> that I can think of is that .stamp files are kept, but (a) they should be
>> removed and (b) there aren't any stamp files in that directory...
>
> I don't really see a reason for the /*, and it seems really dangerous :)
In fact, I think "rm -rf $(var)" would fail when var is empty.
And GNU rm errors out for "rm -rf /"
I agree that $(var)/* is rarely useful.
Regards.
prev parent reply other threads:[~2016-09-16 10:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 8:58 [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 10:04 ` Peter Korsgaard
2016-09-15 16:35 ` Arnout Vandecappelle
2016-09-15 20:07 ` Peter Korsgaard
2016-09-15 20:58 ` Arnout Vandecappelle
2016-09-15 21:21 ` Peter Korsgaard
2016-09-16 7:42 ` [Buildroot] CMAKE_SYSROOT issue [was: Re: [PATCH] toolchain-external: fix potential entire root filesystem removal] Arnout Vandecappelle
2016-09-16 8:52 ` Peter Korsgaard
2016-09-21 19:26 ` Yann E. MORIN
2016-09-21 21:55 ` Peter Korsgaard
2016-09-15 19:22 ` [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 20:08 ` Peter Korsgaard
2016-09-15 16:19 ` Arnout Vandecappelle
2016-09-15 19:20 ` Thomas Petazzoni
2016-09-16 10:13 ` Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DBC5BA.60803@free.fr \
--to=slash.tmp@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox