From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] CMAKE_SYSROOT issue [was: Re: [PATCH] toolchain-external: fix potential entire root filesystem removal]
Date: Wed, 21 Sep 2016 23:55:19 +0200 [thread overview]
Message-ID: <87oa3grk8o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160921192659.GD3405@free.fr> (Yann E. MORIN's message of "Wed, 21 Sep 2016 21:26:59 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Hi,
>> >> [02/09 11:17:31] <smartin> cmake seems to split it like this:
>> >> '--sysroot <STAGING_DIR> -I/urs/include' , i guess cmake does it
>> >> because of/based on the CMAKE_SYSROOT.
>> >> [02/09 11:17:57] <smartin> ^^^ is to be confirm with cmake developers
>> >> [02/09 11:18:45] <smartin> but i wonder why it keep '-I/usr/include'
>> >> since it is a standard location that gcc will check anyway
>> >> [02/09 11:19:02] <smartin> ^^^ also, to be figured out with cmake developers
>>
>> Samuel, did you hear back from the cmake devs?
>> From what I recal, there was no issue with our cmake infra as it is now.
> The problem lies in websocketpp's CMakeList.txt which is incorrect and
> forcefully adds /usr/include.
> I even sent a PR upstream to fix the issue:
> https://github.com/zaphoyd/websocketpp/pull/578
> Unfortunately, it seems the websocketpp hasn't had any activity since
> last February: no commit, no PR review, no comment on issues...
> But there is now a patch that Pieter can use when he submits
> websocketpp.
> So, after discussing the issue on IRC with Samuel, I believe this is a
> non-issue in our infra.
Ok, good to hear - Thanks!
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2016-09-21 21:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 8:58 [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 10:04 ` Peter Korsgaard
2016-09-15 16:35 ` Arnout Vandecappelle
2016-09-15 20:07 ` Peter Korsgaard
2016-09-15 20:58 ` Arnout Vandecappelle
2016-09-15 21:21 ` Peter Korsgaard
2016-09-16 7:42 ` [Buildroot] CMAKE_SYSROOT issue [was: Re: [PATCH] toolchain-external: fix potential entire root filesystem removal] Arnout Vandecappelle
2016-09-16 8:52 ` Peter Korsgaard
2016-09-21 19:26 ` Yann E. MORIN
2016-09-21 21:55 ` Peter Korsgaard [this message]
2016-09-15 19:22 ` [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 20:08 ` Peter Korsgaard
2016-09-15 16:19 ` Arnout Vandecappelle
2016-09-15 19:20 ` Thomas Petazzoni
2016-09-16 10:13 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa3grk8o.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox