From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal
Date: Thu, 15 Sep 2016 22:08:25 +0200 [thread overview]
Message-ID: <87twdhc4ee.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160915212233.6ed8f466@free-electrons.com> (Thomas Petazzoni's message of "Thu, 15 Sep 2016 21:22:33 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Thu, 15 Sep 2016 12:04:03 +0200, Peter Korsgaard wrote:
>> > When such conditions are met, Buildroot will run "rm -rf /*" due to
>> > TOOLCHAIN_EXTERNAL_INSTALL_DIR being empty.
>>
>> > This bug does not exist in 2016.05, and appeared in 2016.08 due to
>> > commit a0aa7e0e1750f6ace2879ea8adb1425a41431b79.
>>
>> Gaah - Committed, thanks!
> I hope you did some good review on it. The last patches touching this
> have seen how catastrophic "apparently good looking" patches can be.
Yeah :/
I did try to take a good look at it, but I'll do some more tests before
releasing 2016.08.1
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2016-09-15 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 8:58 [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 10:04 ` Peter Korsgaard
2016-09-15 16:35 ` Arnout Vandecappelle
2016-09-15 20:07 ` Peter Korsgaard
2016-09-15 20:58 ` Arnout Vandecappelle
2016-09-15 21:21 ` Peter Korsgaard
2016-09-16 7:42 ` [Buildroot] CMAKE_SYSROOT issue [was: Re: [PATCH] toolchain-external: fix potential entire root filesystem removal] Arnout Vandecappelle
2016-09-16 8:52 ` Peter Korsgaard
2016-09-21 19:26 ` Yann E. MORIN
2016-09-21 21:55 ` Peter Korsgaard
2016-09-15 19:22 ` [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 20:08 ` Peter Korsgaard [this message]
2016-09-15 16:19 ` Arnout Vandecappelle
2016-09-15 19:20 ` Thomas Petazzoni
2016-09-16 10:13 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twdhc4ee.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox