From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal
Date: Thu, 15 Sep 2016 23:21:06 +0200 [thread overview]
Message-ID: <87lgysdflp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <a4cc525b-c26a-fb0d-23c5-c72482377e95@mind.be> (Arnout Vandecappelle's message of "Thu, 15 Sep 2016 22:58:27 +0200")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
> TBH, I don't think it's worthwhile to include any other patch in 2016.08.1, not
> even the fbterm one. It's just more effort than it's worth.
Yeah, agreed.
>> > But nothing is really screaming that it should be included.
>>
>> Ok. We should probably figure out if we need to revert the CMAKE_SYSROOT
>> addition (e8c3755676) and include that if needed.
> Er, why would we need to revert it? Did I miss something?
I thought it had been discussed on the list, but apparently not. We got
a report on IRC (I unfortunately don't have logs) that builds of custom
packages using cmake were failing with 2016.08. It is apparently caused
by CMAKE_SYSROOT transforming -I$STAGING_DIR/usr/include into --sysroot
$STAGING_DIR -I /usr/include. In 2016.08 we now default
BR2_COMPILER_PARANOID_UNSAFE_PATH to y, so it complains about it.
I don't quite understand how come this doesn't trigger on the
autobuilders and I haven't had time to investigate, but I got a 2nd
report off list with the same problem, so it sounds real.
Samuel, any ideas?
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2016-09-15 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 8:58 [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 10:04 ` Peter Korsgaard
2016-09-15 16:35 ` Arnout Vandecappelle
2016-09-15 20:07 ` Peter Korsgaard
2016-09-15 20:58 ` Arnout Vandecappelle
2016-09-15 21:21 ` Peter Korsgaard [this message]
2016-09-16 7:42 ` [Buildroot] CMAKE_SYSROOT issue [was: Re: [PATCH] toolchain-external: fix potential entire root filesystem removal] Arnout Vandecappelle
2016-09-16 8:52 ` Peter Korsgaard
2016-09-21 19:26 ` Yann E. MORIN
2016-09-21 21:55 ` Peter Korsgaard
2016-09-15 19:22 ` [Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal Thomas Petazzoni
2016-09-15 20:08 ` Peter Korsgaard
2016-09-15 16:19 ` Arnout Vandecappelle
2016-09-15 19:20 ` Thomas Petazzoni
2016-09-16 10:13 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgysdflp.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox