[Buildroot] [git commit] package/avahi: fix libavahi-client handling

[Buildroot] [git commit] package/avahi: fix libavahi-client handling

[Thomas Petazzoni via buildroot]

commit: https://git.buildroot.net/buildroot/commit/?id=f8332fa63d665d69f6f07524f1b320f589e1f23c
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

libavahi-client is built without daemon since bump to version 0.6.32 in
commit 61c056d40bc51f99f8be19b7e77894a5e6565fd6 and
https://github.com/avahi/avahi/commit/54086a11033194e629b6ad7039bcb4fb1628e052

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/avahi/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/avahi/Config.in b/package/avahi/Config.in
index 2484d8ce5c..728bc4fdd1 100644
--- a/package/avahi/Config.in
+++ b/package/avahi/Config.in
@@ -38,7 +38,7 @@ config BR2_PACKAGE_AVAHI_DAEMON
 # more easily determine if it's available or not.
 config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
 	bool
-	default y if BR2_PACKAGE_AVAHI_DAEMON && BR2_PACKAGE_DBUS
+	default y if BR2_PACKAGE_DBUS
 
 config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
 	bool "libdns_sd compatibility (Bonjour)"
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/avahi: fix libavahi-client handling

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=f8332fa63d665d69f6f07524f1b320f589e1f23c
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > libavahi-client is built without daemon since bump to version 0.6.32 in
 > commit 61c056d40bc51f99f8be19b7e77894a5e6565fd6 and
 > https://github.com/avahi/avahi/commit/54086a11033194e629b6ad7039bcb4fb1628e052

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Oddly enough, I didn't receive the original mail from Fabrice, but it is
in the archive, so probably an issue on my side.

Does this change really make sense in the context of Buildroot? Libavahi
is a library to talk to the avahi daemon, so not very useful without the
daemon.

The original commit talks about multilib, E.G. presumably for a use case
where the daemon is built once and the library built both in 32bit and
64bit and used on the same system, but that isn't really a Buildroot use
case.

> ---
 >  package/avahi/Config.in | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/avahi/Config.in b/package/avahi/Config.in
 > index 2484d8ce5c..728bc4fdd1 100644
 > --- a/package/avahi/Config.in
 > +++ b/package/avahi/Config.in
 > @@ -38,7 +38,7 @@ config BR2_PACKAGE_AVAHI_DAEMON
 >  # more easily determine if it's available or not.
 >  config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
 >  	bool
 > -	default y if BR2_PACKAGE_AVAHI_DAEMON && BR2_PACKAGE_DBUS
 > +	default y if BR2_PACKAGE_DBUS
 
 >  config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
 >  	bool "libdns_sd compatibility (Bonjour)"
 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/avahi: fix libavahi-client handling

[Thomas Petazzoni via buildroot]

Hello Peter,

On Sat, 13 Jan 2024 08:52:20 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Does this change really make sense in the context of Buildroot? Libavahi
> is a library to talk to the avahi daemon, so not very useful without the
> daemon.

True. To be honest, I didn't put too much thinking when applying
Fabrice's patch: the daemon was not strictly needed when building the
library, dropping the dependency made sense, so I applied. If there is
a runtime dependency on the daemon, then indeed maybe we should keep
the dependency. No strong feeling about it, and I certainly wouldn't
feel offended if the commit was reverted.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/avahi: fix libavahi-client handling

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello Peter,
 > On Sat, 13 Jan 2024 08:52:20 +0100
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> Does this change really make sense in the context of Buildroot? Libavahi
 >> is a library to talk to the avahi daemon, so not very useful without the
 >> daemon.

 > True. To be honest, I didn't put too much thinking when applying
 > Fabrice's patch: the daemon was not strictly needed when building the
 > library, dropping the dependency made sense, so I applied. If there is
 > a runtime dependency on the daemon, then indeed maybe we should keep
 > the dependency. No strong feeling about it, and I certainly wouldn't
 > feel offended if the commit was reverted.

It is at least my understanding that libavahi doesn't make much sense
without the daemon, unless I am missing something. Fabrice?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/avahi: fix libavahi-client handling

[Fabrice Fontaine]

Hello,

Le sam. 13 janv. 2024 à 20:56, Peter Korsgaard <peter@korsgaard.com> a écrit :
>
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>
>  > Hello Peter,
>  > On Sat, 13 Jan 2024 08:52:20 +0100
>  > Peter Korsgaard <peter@korsgaard.com> wrote:
>
>  >> Does this change really make sense in the context of Buildroot? Libavahi
>  >> is a library to talk to the avahi daemon, so not very useful without the
>  >> daemon.
>
>  > True. To be honest, I didn't put too much thinking when applying
>  > Fabrice's patch: the daemon was not strictly needed when building the
>  > library, dropping the dependency made sense, so I applied. If there is
>  > a runtime dependency on the daemon, then indeed maybe we should keep
>  > the dependency. No strong feeling about it, and I certainly wouldn't
>  > feel offended if the commit was reverted.
>
> It is at least my understanding that libavahi doesn't make much sense
> without the daemon, unless I am missing something. Fabrice?

On debian, libavahi-client3 depends on libavahi-common3 and libdbus.
There is no dependency on avahi-daemon.
However, in the context of buildroot perhaps this doesn't make a lot of sense.

>
> --
> Bye, Peter Korsgaard

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot