* [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x
@ 2024-01-22 22:30 Giulio Benetti
2024-01-23 8:06 ` Dario Binacchi
2024-01-23 21:28 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Giulio Benetti @ 2024-01-22 22:30 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Dario Binacchi, Giulio Benetti
From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
With gcc version >= 13.x stdint.h must be explicitly included according to
[0] so add local patch to explicitly include stdint.h.
[0]: https://gcc.gnu.org/gcc-13/porting_to.html
Fixes:
still not happened
Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 package/uuu/0001-Fix-missing-references.patch
diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
new file mode 100644
index 0000000000..140c9755c7
--- /dev/null
+++ b/package/uuu/0001-Fix-missing-references.patch
@@ -0,0 +1,40 @@
+From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
+From: nixgnauhcuy <nixgnauhcuy@gmail.com>
+Date: Tue, 9 May 2023 14:32:33 +0800
+Subject: [PATCH] Fix missing references
+
+Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
+
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ libuuu/libcomm.h | 1 +
+ uuu/buildincmd.h | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
+index 0afdfa3..38d622d 100644
+--- a/libuuu/libcomm.h
++++ b/libuuu/libcomm.h
+@@ -28,6 +28,7 @@
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ */
++#include <stdint.h>
+ #include <string>
+ #include <stdarg.h>
+ #include <locale>
+diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
+index 9415117..46286cc 100644
+--- a/uuu/buildincmd.h
++++ b/uuu/buildincmd.h
+@@ -31,6 +31,7 @@
+
+ #pragma once
+
++#include <stdint.h>
+ #include <map>
+ #include <string>
+ #include <vector>
+--
+2.34.1
+
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x
2024-01-22 22:30 [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x Giulio Benetti
@ 2024-01-23 8:06 ` Dario Binacchi
2024-01-23 21:28 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Dario Binacchi @ 2024-01-23 8:06 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Giulio Benetti, buildroot
Hi Giulio,
On Mon, Jan 22, 2024 at 11:30 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
>
> With gcc version >= 13.x stdint.h must be explicitly included according to
> [0] so add local patch to explicitly include stdint.h.
>
> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
>
> Fixes:
> still not happened
>
> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 package/uuu/0001-Fix-missing-references.patch
>
> diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
> new file mode 100644
> index 0000000000..140c9755c7
> --- /dev/null
> +++ b/package/uuu/0001-Fix-missing-references.patch
> @@ -0,0 +1,40 @@
> +From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
> +From: nixgnauhcuy <nixgnauhcuy@gmail.com>
> +Date: Tue, 9 May 2023 14:32:33 +0800
> +Subject: [PATCH] Fix missing references
> +
> +Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + libuuu/libcomm.h | 1 +
> + uuu/buildincmd.h | 1 +
> + 2 files changed, 2 insertions(+)
> +
> +diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
> +index 0afdfa3..38d622d 100644
> +--- a/libuuu/libcomm.h
> ++++ b/libuuu/libcomm.h
> +@@ -28,6 +28,7 @@
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + */
> ++#include <stdint.h>
> + #include <string>
> + #include <stdarg.h>
> + #include <locale>
> +diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
> +index 9415117..46286cc 100644
> +--- a/uuu/buildincmd.h
> ++++ b/uuu/buildincmd.h
> +@@ -31,6 +31,7 @@
> +
> + #pragma once
> +
> ++#include <stdint.h>
> + #include <map>
> + #include <string>
> + #include <vector>
> +--
> +2.34.1
> +
> --
> 2.34.1
>
Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Thanks and regards,
Dario
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x
2024-01-22 22:30 [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x Giulio Benetti
2024-01-23 8:06 ` Dario Binacchi
@ 2024-01-23 21:28 ` Yann E. MORIN
2024-02-04 21:40 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2024-01-23 21:28 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Giulio Benetti, Dario Binacchi, buildroot
Giulio, All,
On 2024-01-22 23:30 +0100, Giulio Benetti spake thusly:
> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
>
> With gcc version >= 13.x stdint.h must be explicitly included according to
> [0] so add local patch to explicitly include stdint.h.
When I read "local patch", it is not immediately obvious that this is a
backport, or that the patch has been upstreamd, and I am wary of such
situations.
But here, this is an actual backport, so a better phrasing would have
been "so backport a commit that...", which I have done when applying.
> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
>
> Fixes:
> still not happened
>
> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 package/uuu/0001-Fix-missing-references.patch
>
> diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
> new file mode 100644
> index 0000000000..140c9755c7
> --- /dev/null
> +++ b/package/uuu/0001-Fix-missing-references.patch
> @@ -0,0 +1,40 @@
> +From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
> +From: nixgnauhcuy <nixgnauhcuy@gmail.com>
> +Date: Tue, 9 May 2023 14:32:33 +0800
> +Subject: [PATCH] Fix missing references
> +
> +Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + libuuu/libcomm.h | 1 +
> + uuu/buildincmd.h | 1 +
> + 2 files changed, 2 insertions(+)
> +
> +diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
> +index 0afdfa3..38d622d 100644
> +--- a/libuuu/libcomm.h
> ++++ b/libuuu/libcomm.h
> +@@ -28,6 +28,7 @@
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + */
> ++#include <stdint.h>
> + #include <string>
> + #include <stdarg.h>
> + #include <locale>
> +diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
> +index 9415117..46286cc 100644
> +--- a/uuu/buildincmd.h
> ++++ b/uuu/buildincmd.h
> +@@ -31,6 +31,7 @@
> +
> + #pragma once
> +
> ++#include <stdint.h>
> + #include <map>
> + #include <string>
> + #include <vector>
> +--
> +2.34.1
> +
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x
2024-01-23 21:28 ` Yann E. MORIN
@ 2024-02-04 21:40 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2024-02-04 21:40 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Giulio Benetti, Dario Binacchi, buildroot, Giulio Benetti
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Giulio, All,
> On 2024-01-22 23:30 +0100, Giulio Benetti spake thusly:
>> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
>>
>> With gcc version >= 13.x stdint.h must be explicitly included according to
>> [0] so add local patch to explicitly include stdint.h.
> When I read "local patch", it is not immediately obvious that this is a
> backport, or that the patch has been upstreamd, and I am wary of such
> situations.
> But here, this is an actual backport, so a better phrasing would have
> been "so backport a commit that...", which I have done when applying.
>> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
>>
>> Fixes:
>> still not happened
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Applied to master, thanks.
Committed to 2023.02.x (where it does apply), thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-04 21:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-22 22:30 [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x Giulio Benetti
2024-01-23 8:06 ` Dario Binacchi
2024-01-23 21:28 ` Yann E. MORIN
2024-02-04 21:40 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox