[Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Peter Seiderer]

With upstram commit [1] (since version v0.1.0) the pipeline option 'raspberrypi'
was renamed to 'rpi/vc4'.

Change the buildroot option name from BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
to BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4 (and add Config.in.legacy entry
accordingly) and move handling in Config.in/libcamer.mk to follow alphabetic
ordering.

Fixes:

  .../build/libcamera-v0.1.0/meson.build:3:0: ERROR: Options "raspberrypi" are not in allowed choices: "all, auto, imx8-isi, ipu3, rkisp1, rpi/vc4, simple, uvcvideo, vimc"

[1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=726e9274ea95fa46352556d340c5793a8da51fcd

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 Config.in.legacy               | 10 ++++++++++
 package/libcamera/Config.in    | 16 ++++++++--------
 package/libcamera/libcamera.mk |  6 +++---
 3 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/Config.in.legacy b/Config.in.legacy
index 6fef2318b0..06a40f0b38 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,16 @@ endif
 
 comment "Legacy options removed in 2023.11"
 
+config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
+	bool "libcamera pipeline 'raspberrypi' was renamed to 'rpi/vc4'"
+	depends on BR2_arm || BR2_aarch64
+	depends on BR2_USE_WCHAR
+	select BR2_LEGACY
+	select BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
+	help
+	  Since version ... the libcamera pipeline option 'raspberrypi' was
+	  renamed to 'rpi/vc4'.
+
 config BR2_PACKAGE_OPENJDK_VERSION_11
 	bool "openjdk 11 has been removed"
 	select BR2_LEGACY
diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index 63c06173db..65d5fb37f8 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -40,21 +40,21 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
 	help
 	  Pipeline for Intel IPU3.
 
-config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
-	bool "raspberrypi pipeline"
+config BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1
+	bool "rkisp1 pipeline"
 	depends on BR2_arm || BR2_aarch64
-	depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
-	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
-	  Pipeline for Raspberry Pi devices.
+	  Pipeline for Rockchip ISP1.
 
-config BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1
-	bool "rkisp1 pipeline"
+config BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
+	bool "rpi/vc4 pipeline"
 	depends on BR2_arm || BR2_aarch64
+	depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
+	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
-	  Pipeline for Rockchip ISP1.
+	  Pipeline for Raspberry Pi devices.
 
 config BR2_PACKAGE_LIBCAMERA_PIPELINE_SIMPLE
 	bool "simple pipeline"
diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index 8dce67f60f..c1c8bb7b33 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -51,11 +51,11 @@ LIBCAMERA_CONF_OPTS += -Dv4l2=false
 endif
 
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
-ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI),y)
-LIBCAMERA_PIPELINES-y += raspberrypi
+LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
+ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4),y)
+LIBCAMERA_PIPELINES-y += rpi/vc4
 LIBCAMERA_DEPENDENCIES += boost
 endif
-LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_SIMPLE) += simple
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO) += uvcvideo
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC) += vimc
-- 
2.42.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 2/4] package/libcamera: disable python bindings by default

[Peter Seiderer]

Disable python binding option (introduced with upstream commit [1] (since
version v0.0.1) by default.

[1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=8aa02271fd716ed046970a0b1f89176963303f50

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libcamera/libcamera.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index c1c8bb7b33..8b33b9e708 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -19,6 +19,7 @@ LIBCAMERA_CONF_OPTS = \
 	-Dandroid=disabled \
 	-Ddocumentation=disabled \
 	-Dtest=false \
+	-Dpycamera=disabled \
 	-Dwerror=false
 LIBCAMERA_INSTALL_STAGING = YES
 LIBCAMERA_LICENSE = \
-- 
2.42.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 3/4] package/libcamera: use udev configure option

[Peter Seiderer]

Use the udev configure option introduced with upstream commit [1] (since
version v0.1.0).

[1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=d314d3b98b86dec9a25ce7b829e72a790b7ead1b

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libcamera/libcamera.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index 8b33b9e708..dd31d90e98 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -98,7 +98,10 @@ LIBCAMERA_DEPENDENCIES += tiff
 endif
 
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+LIBCAMERA_CONF_OPTS += -Dudev=enabled
 LIBCAMERA_DEPENDENCIES += udev
+else
+LIBCAMERA_CONF_OPTS += -Dudev=disabled
 endif
 
 ifeq ($(BR2_PACKAGE_LTTNG_LIBUST),y)
-- 
2.42.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 4/4] package/libcamera: add i.MX8 ISI pipeline option

[Peter Seiderer]

Add i.MX8 ISI pipeline option (introduced with upstream commit [1] (since
version v0.0.1).

[1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=0ec982d210861cc6aaebb5d6e8f1a755a16c9792

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libcamera/Config.in    | 7 +++++++
 package/libcamera/libcamera.mk | 1 +
 2 files changed, 8 insertions(+)

diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index 65d5fb37f8..ccb5281b4b 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -33,6 +33,13 @@ config BR2_PACKAGE_LIBCAMERA_V4L2
 config BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	bool
 
+config BR2_PACKAGE_LIBCAMERA_PIPELINE_IMX8_ISI
+	bool "imx8-isi pipeline"
+	depends on BR2_arm || BR2_aarch64
+	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
+	help
+	  Pipeline for i.MX8 SoC ISI capture interface.
+
 config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
 	bool "ipu3 pipeline"
 	depends on BR2_i386 || BR2_x86_64
diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index dd31d90e98..c9af90f35f 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -51,6 +51,7 @@ else
 LIBCAMERA_CONF_OPTS += -Dv4l2=false
 endif
 
+LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IMX8_ISI) += imx8-isi
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
 ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4),y)
-- 
2.42.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Yann E. MORIN]

Peter, All,

On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
> With upstram commit [1] (since version v0.1.0) the pipeline option 'raspberrypi'
> was renamed to 'rpi/vc4'.
> 
> Change the buildroot option name from BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> to BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4 (and add Config.in.legacy entry
> accordingly) and move handling in Config.in/libcamer.mk to follow alphabetic
> ordering.
> 
> Fixes:
> 
>   .../build/libcamera-v0.1.0/meson.build:3:0: ERROR: Options "raspberrypi" are not in allowed choices: "all, auto, imx8-isi, ipu3, rkisp1, rpi/vc4, simple, uvcvideo, vimc"
> 
> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=726e9274ea95fa46352556d340c5793a8da51fcd
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  Config.in.legacy               | 10 ++++++++++
>  package/libcamera/Config.in    | 16 ++++++++--------
>  package/libcamera/libcamera.mk |  6 +++---
>  3 files changed, 21 insertions(+), 11 deletions(-)
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 6fef2318b0..06a40f0b38 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,16 @@ endif
>  
>  comment "Legacy options removed in 2023.11"
>  
> +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> +	bool "libcamera pipeline 'raspberrypi' was renamed to 'rpi/vc4'"
> +	depends on BR2_arm || BR2_aarch64
> +	depends on BR2_USE_WCHAR
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
> +	help
> +	  Since version ... the libcamera pipeline option 'raspberrypi' was
> +	  renamed to 'rpi/vc4'.
> +
>  config BR2_PACKAGE_OPENJDK_VERSION_11
>  	bool "openjdk 11 has been removed"
>  	select BR2_LEGACY
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index 63c06173db..65d5fb37f8 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -40,21 +40,21 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
>  	help
>  	  Pipeline for Intel IPU3.
>  
> -config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> -	bool "raspberrypi pipeline"
> +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1
> +	bool "rkisp1 pipeline"
>  	depends on BR2_arm || BR2_aarch64
> -	depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
> -	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
>  	help
> -	  Pipeline for Raspberry Pi devices.
> +	  Pipeline for Rockchip ISP1.
>  
> -config BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1
> -	bool "rkisp1 pipeline"
> +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
> +	bool "rpi/vc4 pipeline"
>  	depends on BR2_arm || BR2_aarch64
> +	depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
> +	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
>  	help
> -	  Pipeline for Rockchip ISP1.
> +	  Pipeline for Raspberry Pi devices.
>  
>  config BR2_PACKAGE_LIBCAMERA_PIPELINE_SIMPLE
>  	bool "simple pipeline"
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index 8dce67f60f..c1c8bb7b33 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -51,11 +51,11 @@ LIBCAMERA_CONF_OPTS += -Dv4l2=false
>  endif
>  
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
> -ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI),y)
> -LIBCAMERA_PIPELINES-y += raspberrypi
> +LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
> +ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4),y)
> +LIBCAMERA_PIPELINES-y += rpi/vc4
>  LIBCAMERA_DEPENDENCIES += boost
>  endif
> -LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_SIMPLE) += simple
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO) += uvcvideo
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC) += vimc
> -- 
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Yann E. MORIN]

Peter, All,

On 2023-12-27 23:16 +0100, Yann E. MORIN spake thusly:
> On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
> > With upstram commit [1] (since version v0.1.0) the pipeline option 'raspberrypi'
> > was renamed to 'rpi/vc4'.
> > 
> > Change the buildroot option name from BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> > to BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4 (and add Config.in.legacy entry
> > accordingly) and move handling in Config.in/libcamer.mk to follow alphabetic
> > ordering.
> > 
> > Fixes:
> > 
> >   .../build/libcamera-v0.1.0/meson.build:3:0: ERROR: Options "raspberrypi" are not in allowed choices: "all, auto, imx8-isi, ipu3, rkisp1, rpi/vc4, simple, uvcvideo, vimc"
> > 
> > [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=726e9274ea95fa46352556d340c5793a8da51fcd
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> Applied to master, thanks.
[--SNIP--]
> > diff --git a/Config.in.legacy b/Config.in.legacy
> > index 6fef2318b0..06a40f0b38 100644
> > --- a/Config.in.legacy
> > +++ b/Config.in.legacy
> > @@ -146,6 +146,16 @@ endif
> >  
> >  comment "Legacy options removed in 2023.11"
> >  
> > +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> > +	bool "libcamera pipeline 'raspberrypi' was renamed to 'rpi/vc4'"
> > +	depends on BR2_arm || BR2_aarch64
> > +	depends on BR2_USE_WCHAR
> > +	select BR2_LEGACY
> > +	select BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
> > +	help
> > +	  Since version ... the libcamera pipeline option 'raspberrypi' was

    $ ./utils/docker-run make check-pacakge
    Config.in.legacy:156: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

I had it fixed locally, but forgot to commit before pushing, so I pushed
a follow-up fix.

I also replaced the '...' with the actual version you talked about ion
the commit log: 0.1.0.

Regards,
Yann E. MORIN.

> > +	  renamed to 'rpi/vc4'.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 2/4] package/libcamera: disable python bindings by default

[Yann E. MORIN]

Peter, All,

On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
> Disable python binding option (introduced with upstream commit [1] (since
> version v0.0.1) by default.

Since there i s no way to enabled them with this change, they are not
"disabled *by default*"; they are just "disabled".

So I dropped the "y default" part of the title and the commit log.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=8aa02271fd716ed046970a0b1f89176963303f50
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/libcamera/libcamera.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index c1c8bb7b33..8b33b9e708 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -19,6 +19,7 @@ LIBCAMERA_CONF_OPTS = \
>  	-Dandroid=disabled \
>  	-Ddocumentation=disabled \
>  	-Dtest=false \
> +	-Dpycamera=disabled \
>  	-Dwerror=false
>  LIBCAMERA_INSTALL_STAGING = YES
>  LIBCAMERA_LICENSE = \
> -- 
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 3/4] package/libcamera: use udev configure option

[Yann E. MORIN]

Peter, All,

On 2023-11-09 22:29 +0100, Peter Seiderer spake thusly:
> Use the udev configure option introduced with upstream commit [1] (since
> version v0.1.0).
> 
> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=d314d3b98b86dec9a25ce7b829e72a790b7ead1b
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libcamera/libcamera.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index 8b33b9e708..dd31d90e98 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -98,7 +98,10 @@ LIBCAMERA_DEPENDENCIES += tiff
>  endif
>  
>  ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> +LIBCAMERA_CONF_OPTS += -Dudev=enabled
>  LIBCAMERA_DEPENDENCIES += udev
> +else
> +LIBCAMERA_CONF_OPTS += -Dudev=disabled
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LTTNG_LIBUST),y)
> -- 
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 4/4] package/libcamera: add i.MX8 ISI pipeline option

[Yann E. MORIN]

Peter, All,

On 2023-11-09 22:29 +0100, Peter Seiderer spake thusly:
> Add i.MX8 ISI pipeline option (introduced with upstream commit [1] (since
> version v0.0.1).
> 
> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=0ec982d210861cc6aaebb5d6e8f1a755a16c9792
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libcamera/Config.in    | 7 +++++++
>  package/libcamera/libcamera.mk | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index 65d5fb37f8..ccb5281b4b 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -33,6 +33,13 @@ config BR2_PACKAGE_LIBCAMERA_V4L2
>  config BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
>  	bool
>  
> +config BR2_PACKAGE_LIBCAMERA_PIPELINE_IMX8_ISI
> +	bool "imx8-isi pipeline"
> +	depends on BR2_arm || BR2_aarch64
> +	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
> +	help
> +	  Pipeline for i.MX8 SoC ISI capture interface.
> +
>  config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
>  	bool "ipu3 pipeline"
>  	depends on BR2_i386 || BR2_x86_64
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index dd31d90e98..c9af90f35f 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -51,6 +51,7 @@ else
>  LIBCAMERA_CONF_OPTS += -Dv4l2=false
>  endif
>  
> +LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IMX8_ISI) += imx8-isi
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
>  ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4),y)
> -- 
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
 >> With upstram commit [1] (since version v0.1.0) the pipeline option 'raspberrypi'
 >> was renamed to 'rpi/vc4'.
 >> 
 >> Change the buildroot option name from BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
 >> to BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4 (and add Config.in.legacy entry
 >> accordingly) and move handling in Config.in/libcamer.mk to follow alphabetic
 >> ordering.
 >> 
 >> Fixes:
 >> 
 >> .../build/libcamera-v0.1.0/meson.build:3:0: ERROR: Options
 >> "raspberrypi" are not in allowed choices: "all, auto, imx8-isi,
 >> ipu3, rkisp1, rpi/vc4, simple, uvcvideo, vimc"
 >> 
 >> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=726e9274ea95fa46352556d340c5793a8da51fcd
 >> 
 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

 > Applied to master, thanks.

 > Regards,
 > Yann E. MORIN.

 >> ---
 >> Config.in.legacy               | 10 ++++++++++
 >> package/libcamera/Config.in    | 16 ++++++++--------
 >> package/libcamera/libcamera.mk |  6 +++---
 >> 3 files changed, 21 insertions(+), 11 deletions(-)
 >> 
 >> diff --git a/Config.in.legacy b/Config.in.legacy
 >> index 6fef2318b0..06a40f0b38 100644
 >> --- a/Config.in.legacy
 >> +++ b/Config.in.legacy
 >> @@ -146,6 +146,16 @@ endif
 >> 
 >> comment "Legacy options removed in 2023.11"
 >> 
 >> +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
 >> +	bool "libcamera pipeline 'raspberrypi' was renamed to 'rpi/vc4'"
 >> +	depends on BR2_arm || BR2_aarch64
 >> +	depends on BR2_USE_WCHAR
 >> +	select BR2_LEGACY
 >> +	select BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
 >> +	help
 >> +	  Since version ... the libcamera pipeline option 'raspberrypi' was

I guess ... should have been 0.1.0:

git describe --contains 726e9274e
v0.1.0~78

check-package also complains about too long help line:

Config.in.legacy:156: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Committed to 2023.11.x after fixing those issues, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 >> > +	  Since version ... the libcamera pipeline option 'raspberrypi' was

 >     $ ./utils/docker-run make check-pacakge
 >     Config.in.legacy:156: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

 > I had it fixed locally, but forgot to commit before pushing, so I pushed
 > a follow-up fix.

 > I also replaced the '...' with the actual version you talked about ion
 > the commit log: 0.1.0.

Ahh ;)

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 2/4] package/libcamera: disable python bindings by default

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
 >> Disable python binding option (introduced with upstream commit [1] (since
 >> version v0.0.1) by default.

 > Since there i s no way to enabled them with this change, they are not
 > "disabled *by default*"; they are just "disabled".

 > So I dropped the "y default" part of the title and the commit log.

 > Applied to master, thanks.

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 3/4] package/libcamera: use udev configure option

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-11-09 22:29 +0100, Peter Seiderer spake thusly:
 >> Use the udev configure option introduced with upstream commit [1] (since
 >> version v0.1.0).
 >> 
 >> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=d314d3b98b86dec9a25ce7b829e72a790b7ead1b
 >> 
 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

 > Applied to master, thanks.

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 4/4] package/libcamera: add i.MX8 ISI pipeline option

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-11-09 22:29 +0100, Peter Seiderer spake thusly:
 >> Add i.MX8 ISI pipeline option (introduced with upstream commit [1] (since
 >> version v0.0.1).
 >> 
 >> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=0ec982d210861cc6aaebb5d6e8f1a755a16c9792
 >> 
 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

 > Applied to master, thanks.

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot