From: Juri Lelli <juri.lelli@redhat.com>
To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Cc: "Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"Waiman Long" <longman@redhat.com>, "Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Qais Yousef" <qyousef@layalina.io>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Swapnil Sapkal" <swapnil.sapkal@amd.com>,
"Shrikanth Hegde" <sshegde@linux.ibm.com>,
"Phil Auld" <pauld@redhat.com>,
luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it,
"Jon Hunter" <jonathanh@nvidia.com>
Subject: [PATCH v3 1/8] sched/deadline: Ignore special tasks when rebuilding domains
Date: Mon, 10 Mar 2025 10:19:28 +0100 [thread overview]
Message-ID: <20250310091935.22923-2-juri.lelli@redhat.com> (raw)
In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com>
SCHED_DEADLINE special tasks get a fake bandwidth that is only used to
make sure sleeping and priority inheritance 'work', but it is ignored
for runtime enforcement and admission control.
Be consistent with it also when rebuilding root domains.
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for hotplug")
Tested-by: Waiman Long <longman@redhat.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index ff4df16b5186..1a041c1fc0d1 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2956,7 +2956,7 @@ void dl_add_task_root_domain(struct task_struct *p)
struct dl_bw *dl_b;
raw_spin_lock_irqsave(&p->pi_lock, rf.flags);
- if (!dl_task(p)) {
+ if (!dl_task(p) || dl_entity_is_special(&p->dl)) {
raw_spin_unlock_irqrestore(&p->pi_lock, rf.flags);
return;
}
--
2.48.1
next prev parent reply other threads:[~2025-03-10 9:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 9:19 [PATCH v3 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Juri Lelli
2025-03-10 9:19 ` Juri Lelli [this message]
2025-03-12 13:32 ` [PATCH v3 1/8] sched/deadline: Ignore special tasks when rebuilding domains Valentin Schneider
2025-03-10 9:33 ` [PATCH v3 2/8] sched/topology: Wrappers for sched_domains_mutex Juri Lelli
2025-03-12 13:32 ` Valentin Schneider
2025-03-10 9:35 ` [PATCH v3 3/8] sched/deadline: Generalize unique visiting of root domains Juri Lelli
2025-03-12 13:32 ` Valentin Schneider
2025-03-10 9:37 ` [PATCH v3 4/8] sched/deadline: Rebuild root domain accounting after every update Juri Lelli
2025-03-10 18:54 ` Dietmar Eggemann
2025-03-10 19:18 ` Waiman Long
2025-03-11 0:16 ` Waiman Long
2025-03-11 11:59 ` Juri Lelli
2025-03-11 12:34 ` Waiman Long
2025-03-11 13:29 ` Dietmar Eggemann
2025-03-11 14:51 ` Waiman Long
2025-03-12 9:53 ` Dietmar Eggemann
2025-03-12 10:09 ` Juri Lelli
2025-03-12 13:55 ` Waiman Long
2025-03-12 14:11 ` Juri Lelli
2025-03-12 16:29 ` Dietmar Eggemann
2025-03-12 16:51 ` Juri Lelli
2025-03-13 9:09 ` Dietmar Eggemann
2025-03-10 9:38 ` [PATCH v3 5/8] sched/topology: Remove redundant dl_clear_root_domain call Juri Lelli
2025-03-12 13:32 ` Valentin Schneider
2025-03-10 9:39 ` [PATCH v3 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Juri Lelli
2025-03-12 13:32 ` Valentin Schneider
2025-03-10 9:40 ` [PATCH v3 7/8] sched/topology: Stop exposing partition_sched_domains_locked Juri Lelli
2025-03-12 13:32 ` Valentin Schneider
2025-03-10 9:40 ` [PATCH v3 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Juri Lelli
2025-03-12 13:32 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310091935.22923-2-juri.lelli@redhat.com \
--to=juri.lelli@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=swapnil.sapkal@amd.com \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox