Linux cgroups development
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: "Waiman Long" <llong@redhat.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	"Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
	"Valentin Schneider" <vschneid@redhat.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Qais Yousef" <qyousef@layalina.io>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Swapnil Sapkal" <swapnil.sapkal@amd.com>,
	"Shrikanth Hegde" <sshegde@linux.ibm.com>,
	"Phil Auld" <pauld@redhat.com>,
	luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it,
	"Jon Hunter" <jonathanh@nvidia.com>
Subject: Re: [PATCH v3 4/8] sched/deadline: Rebuild root domain accounting after every update
Date: Wed, 12 Mar 2025 11:09:29 +0100	[thread overview]
Message-ID: <Z9FdWZsiI9riBImL@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <724e00ea-eb27-46f1-acc3-465c04ffc84d@arm.com>

On 12/03/25 10:53, Dietmar Eggemann wrote:
> On 11/03/2025 15:51, Waiman Long wrote:

...

> > You are right. cpuhp_tasks_frozen will be set in the suspend/resume
> > case. In that case, we do need to add a cpuset helper to acquire the
> > cpuset_mutex. A test patch as follows (no testing done yet):

...

> This seems to work.

Thanks for testing!

Waiman, how do you like to proceed. Separate patch (in this case can you
please send me that with changelog etc.) or incorporate your changes
into my original patch and possibly, if you like, add Co-authored-by?

> But what about a !CONFIG_CPUSETS build. In this case we won't have
> this DL accounting update during suspend/resume since
> dl_rebuild_rd_accounting() is empty.

I unfortunately very much suspect !CPUSETS accounting is broken. But if
that is indeed the case, it has been broken for a while. :(

Will need to double check that, but I would probably do it later on
separated from this set that at least seems to cure the most common
cases. What do people think?

Thanks,
Juri


  reply	other threads:[~2025-03-12 10:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10  9:19 [PATCH v3 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Juri Lelli
2025-03-10  9:19 ` [PATCH v3 1/8] sched/deadline: Ignore special tasks when rebuilding domains Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:33 ` [PATCH v3 2/8] sched/topology: Wrappers for sched_domains_mutex Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:35 ` [PATCH v3 3/8] sched/deadline: Generalize unique visiting of root domains Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:37 ` [PATCH v3 4/8] sched/deadline: Rebuild root domain accounting after every update Juri Lelli
2025-03-10 18:54   ` Dietmar Eggemann
2025-03-10 19:18     ` Waiman Long
2025-03-11  0:16       ` Waiman Long
2025-03-11 11:59         ` Juri Lelli
2025-03-11 12:34           ` Waiman Long
2025-03-11 13:29             ` Dietmar Eggemann
2025-03-11 14:51               ` Waiman Long
2025-03-12  9:53                 ` Dietmar Eggemann
2025-03-12 10:09                   ` Juri Lelli [this message]
2025-03-12 13:55                     ` Waiman Long
2025-03-12 14:11                       ` Juri Lelli
2025-03-12 16:29                         ` Dietmar Eggemann
2025-03-12 16:51                           ` Juri Lelli
2025-03-13  9:09                             ` Dietmar Eggemann
2025-03-10  9:38 ` [PATCH v3 5/8] sched/topology: Remove redundant dl_clear_root_domain call Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:39 ` [PATCH v3 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:40 ` [PATCH v3 7/8] sched/topology: Stop exposing partition_sched_domains_locked Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:40 ` [PATCH v3 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Juri Lelli
2025-03-12 13:32   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9FdWZsiI9riBImL@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=luca.abeni@santannapisa.it \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=swapnil.sapkal@amd.com \
    --cc=tj@kernel.org \
    --cc=tommaso.cucinotta@santannapisa.it \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox