Linux cgroups development
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Cc: "Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
	"Valentin Schneider" <vschneid@redhat.com>,
	"Waiman Long" <longman@redhat.com>, "Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Qais Yousef" <qyousef@layalina.io>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Swapnil Sapkal" <swapnil.sapkal@amd.com>,
	"Shrikanth Hegde" <sshegde@linux.ibm.com>,
	"Phil Auld" <pauld@redhat.com>,
	luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it,
	"Jon Hunter" <jonathanh@nvidia.com>
Subject: [PATCH v3 7/8] sched/topology: Stop exposing partition_sched_domains_locked
Date: Mon, 10 Mar 2025 10:40:02 +0100	[thread overview]
Message-ID: <Z86zci-kj6kNBl8I@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com>

The are no callers of partition_sched_domains_locked() outside
topology.c.

Stop exposing such function.

Suggested-by: Waiman Long <llong@redhat.com>
Tested-by: Waiman Long <longman@redhat.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
---
 include/linux/sched/topology.h | 10 ----------
 kernel/sched/topology.c        |  2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h
index 1622232bd08b..96e69bfc3c8a 100644
--- a/include/linux/sched/topology.h
+++ b/include/linux/sched/topology.h
@@ -168,10 +168,6 @@ static inline struct cpumask *sched_domain_span(struct sched_domain *sd)
 
 extern void dl_rebuild_rd_accounting(void);
 
-extern void partition_sched_domains_locked(int ndoms_new,
-					   cpumask_var_t doms_new[],
-					   struct sched_domain_attr *dattr_new);
-
 extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
 				    struct sched_domain_attr *dattr_new);
 
@@ -212,12 +208,6 @@ extern void __init set_sched_topology(struct sched_domain_topology_level *tl);
 
 struct sched_domain_attr;
 
-static inline void
-partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[],
-			       struct sched_domain_attr *dattr_new)
-{
-}
-
 static inline void
 partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
 			struct sched_domain_attr *dattr_new)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index df2d94a57e84..95bde793651c 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -2688,7 +2688,7 @@ static int dattrs_equal(struct sched_domain_attr *cur, int idx_cur,
  *
  * Call with hotplug lock and sched_domains_mutex held
  */
-void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[],
+static void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[],
 				    struct sched_domain_attr *dattr_new)
 {
 	bool __maybe_unused has_eas = false;
-- 
2.48.1


  parent reply	other threads:[~2025-03-10  9:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10  9:19 [PATCH v3 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Juri Lelli
2025-03-10  9:19 ` [PATCH v3 1/8] sched/deadline: Ignore special tasks when rebuilding domains Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:33 ` [PATCH v3 2/8] sched/topology: Wrappers for sched_domains_mutex Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:35 ` [PATCH v3 3/8] sched/deadline: Generalize unique visiting of root domains Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:37 ` [PATCH v3 4/8] sched/deadline: Rebuild root domain accounting after every update Juri Lelli
2025-03-10 18:54   ` Dietmar Eggemann
2025-03-10 19:18     ` Waiman Long
2025-03-11  0:16       ` Waiman Long
2025-03-11 11:59         ` Juri Lelli
2025-03-11 12:34           ` Waiman Long
2025-03-11 13:29             ` Dietmar Eggemann
2025-03-11 14:51               ` Waiman Long
2025-03-12  9:53                 ` Dietmar Eggemann
2025-03-12 10:09                   ` Juri Lelli
2025-03-12 13:55                     ` Waiman Long
2025-03-12 14:11                       ` Juri Lelli
2025-03-12 16:29                         ` Dietmar Eggemann
2025-03-12 16:51                           ` Juri Lelli
2025-03-13  9:09                             ` Dietmar Eggemann
2025-03-10  9:38 ` [PATCH v3 5/8] sched/topology: Remove redundant dl_clear_root_domain call Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:39 ` [PATCH v3 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Juri Lelli
2025-03-12 13:32   ` Valentin Schneider
2025-03-10  9:40 ` Juri Lelli [this message]
2025-03-12 13:32   ` [PATCH v3 7/8] sched/topology: Stop exposing partition_sched_domains_locked Valentin Schneider
2025-03-10  9:40 ` [PATCH v3 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Juri Lelli
2025-03-12 13:32   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z86zci-kj6kNBl8I@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=luca.abeni@santannapisa.it \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=swapnil.sapkal@amd.com \
    --cc=tj@kernel.org \
    --cc=tommaso.cucinotta@santannapisa.it \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox