Re: [RFC PATCH 02/16] mm/damon/core: ask apply_probes() ops callback to set sampling address

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Malformed kernel-doc syntax and typos in the `apply_probes` documentation.
--

commit 2691e8480612ea2e98837a8db1eb30da170cf383
Author: SJ Park <sj@kernel.org>

mm/damon/core: ask apply_probes() ops callback to set sampling address

This patch updates the apply_probes() callback in struct damon_operations
by adding a set_samples argument. It allows apply_probes() to directly set
the sampling address for each region, minimizing unnecessary iterations.

> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 257a4769296ab..7c82cd0c2f29d 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -646,7 +646,8 @@ enum damon_ops_id {
>   * It should also return max number of observed accesses that made as a result
>   * of its update.  The value will be used for regions adjustment threshold.
>   * @apply_probes should apply the data attribute probes to each region and
> - * accordingly update the probe hits counter of the region.
> + * accordingly update the probe hits counter of the region.  It should also
> + * &set sampling_addr or each region if &set_samples is true.

[Severity: Low]
This isn't a bug, but there appear to be a few typos and kernel-doc syntax
issues in this documentation update.

Did you mean "for each" instead of "or each"?

Additionally, parameter references in kernel-doc typically use @set_samples
rather than &set_samples, and the &set prefix seems unintended here.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705205743.98656-1-sj@kernel.org?part=2