Re: [RFC PATCH 14/16] Docs/mm/damon/design: document attrs-only monitoring

[SJ Park <sj@kernel.org>]

On Sun, 05 Jul 2026 21:05:19 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Spelling mistakes in the newly added documentation: 'deeecided' and 'mechaanism'.
> --
> 
> commit 802f6df741c5d3bfcb1ed21eadbf33ebee4db496
> Author: SJ Park <sj@kernel.org>
> 
> Docs/mm/damon/design: document attrs-only monitoring
> 
> This commit updates the DAMON design document to include a section
> describing the data attributes-only monitoring mode.
> 
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > index 457d6e8bc7878..67398e2133036 100644
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> 
> [ ... ]
> 
> > @@ -316,6 +316,26 @@ Another way to do this for higher accuracy is using :ref:`DAMOS filter
> >  information in page level.  But, because it is operated in page level, the
> >  overhead is proportional to the size of the memory.
> >  
> > +Data Attributes-only Monitoring
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +Data access is the primary monitoring information for DAMON.  Hence it
> > +:ref:`adjusts <damon_design_data_attrs_monitoring>` regions using the access
> > +:ref:`counter <damon_design_region_based_sampling>` (``nr_accesses``).  In some
> > +use cases, however, users may want some of :ref:`attributes
> > +<damon_design_data_attrs_monitoring>` to be the primary information.
> > +
> > +Data attributes-only monitoring mode supports this use case.  For the mode,
> > +each attribute probe has their priority weight value.  Users can describe by
> > +what combination of the attributes the primary information is deeecided, by
> 
> [Severity: Low]
> This isn't a bug, but there is a typo here: "deeecided" should be "decided".

Good finding.  I will fix this in the next revision.

> 
> > +setting the priority weight value.  If the total sum of the weights is not
> > +zero, the mode is enabled.  The regions adjustment mechaanism uses the weighted
> 
> [Severity: Low]
> This isn't a bug, but there is another typo here: "mechaanism" should be
> "mechanism".

Ditto.

> 
> > +sum of the :ref:`probe hit counts <damon_design_data_attrs_monitoring>` instead
> > +of ``nr_accesses`` in the case.  When the mode is enabled, access monitoring is
> > +automatically turned off.  The access counter (``nr_accesses``) will always be
> > +zero and not updated.  Hence the mode is called Data Attributes "only"
> > +monitoring.
> > +
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260705205743.98656-1-sj@kernel.org?part=14


Thanks,
SJ