Re: [RFC PATCH 01/16] mm/damon/core: introduce damon_probe->weight

[SJ Park <sj@kernel.org>]

On Sun, 05 Jul 2026 21:04:53 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing kernel-doc description for the new `weight` field in `struct damon_probe`.
> --
> 
> commit 4be82423c8a2e9beb3264e298ab3af6bd580eea9
> Author: SJ Park <sj@kernel.org>
> 
> mm/damon/core: introduce damon_probe->weight
> 
> This commit adds a new weight field to the damon_probe structure. The field
> is used to specify the degree of the API caller's interest in the data
> attribute of the probe.
> 
> > diff --git a/include/linux/damon.h b/include/linux/damon.h
> > index 616bdf0954b52..257a4769296ab 100644
> > --- a/include/linux/damon.h
> > +++ b/include/linux/damon.h
> > @@ -763,6 +763,7 @@ struct damon_filter {
> >   * @list:	Siblings list.
> >   */
> >  struct damon_probe {
> > +	unsigned int weight;
> 
> [Severity: Low]
> Should the kernel-doc comment block above struct damon_probe be updated to
> include a description for the new weight field? Without it, running
> scripts/kernel-doc might emit a warning about the undocumented field.

Good catch.  I will add the comment on the next revision.

> 
> >  	struct list_head filters;
> >  	struct list_head list;
> >  };
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260705205743.98656-1-sj@kernel.org?part=1


Thanks,
SJ