Linux Device Mapper development
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: christophe.varoqui@opensvc.com,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: multipath: change the DEFAULT_MINIO for the request based multipath
Date: Fri, 21 Jan 2011 09:12:05 -0500	[thread overview]
Message-ID: <20110121141204.GE30411@redhat.com> (raw)
In-Reply-To: <1295599627.23625.16.camel@zezette>

On Fri, Jan 21 2011 at  3:47am -0500,
Christophe Varoqui <christophe.varoqui@gmail.com> wrote:

> 
> > 
> > Fortunately, the target version of multipath was also bumped
> > in 2.6.31, from 1.0.5 to 1.1.0 by this commit:
> > 
> > af4874e v2.6.31-rc1 dm target:s introduce iterate devices fn
> > 
> Fortunate indeed.
> 
> Should the 'minio' be a tunable in the request-based multipath context,
> or should we hardcode its value to '1' ?

As my earlier response indicated: I'm not convinced _always_ using 1 for
request-based is appropriate/best.
 
> If we keep it a tunable, I guess we'll have to introduce a different
> 'minio' configuration parameter ('rr_min_io_rq' for example) to permit
> vendors to set their defaults for distributions shipping a rq-capable
> kernel or not. This change would be pretty invasive.

I'm not following why we'd need a different configuration parameter.
It is just that the default rr_min_io that would be used would be
conditional on the multipath target version being >= 1.1.0.

Mike

  reply	other threads:[~2011-01-21 14:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 21:30 [PATCH] [RFC] multipath: change the DEFAULT_MINIO for the request based multipath Malahal Naineni
2011-01-20  7:32 ` Hannes Reinecke
2011-01-20 16:07   ` Mike Snitzer
2011-01-21  7:03     ` Jun'ichi Nomura
2011-01-21  8:47       ` Christophe Varoqui
2011-01-21 14:12         ` Mike Snitzer [this message]
2011-01-21 14:46           ` Christophe Varoqui
2011-01-21 17:39             ` Malahal Naineni
2011-01-25  8:56               ` Jun'ichi Nomura
2011-01-26  2:23                 ` Malahal Naineni
2011-01-26 17:27                   ` nishant mungse
2011-01-27 15:16                     ` nishant mungse
2011-01-31 23:53                   ` Christophe Varoqui
2011-02-01  2:21                     ` Malahal Naineni
2011-02-01  3:13                       ` Mike Snitzer
2011-02-01  8:14                         ` Malahal Naineni
2011-02-01  8:13                     ` Malahal Naineni
2011-02-01  9:00                       ` Christophe Varoqui
2011-02-01  9:51                         ` Malahal Naineni
2011-01-21 13:26       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110121141204.GE30411@redhat.com \
    --to=snitzer@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox