Re: multipath: change the DEFAULT_MINIO for the request based multipath

[Malahal Naineni <malahal@us.ibm.com>]

Christophe Varoqui [christophe.varoqui@gmail.com] wrote:
> That's because there are /etc/multipath.conf in the wild right now,
> created with non rq capable kernels. rr_min_io meant something then. It
> seems not fair to change the meaning of that tunable upon upgrade.
> People do cut-and-paste from old docs (corp or googled) and from peers
> systems ... this approach minimize the risk of killing the perf by
> accident. And I don't see downsides.

Agreed.

>  dm_drv_get_rq (void)
>  {
>         unsigned int minv_dmrq[3] = {1, 1, 0};
> -       unsigned int *v;
> -
> -       v = zalloc(3);
> -       if (!v)
> -               return 0;
> +       unsigned int version[3] = {0, 0, 0};
> +        unsigned int * v = version;

You could just say 'unsigned int v[3] = {0, 0, 0};' and remove the extra
pointer variable.

> +       unsigned int version[3] = {0, 0, 0};
> +        unsigned int * v = version;

Same as above.

Looks good. Thank you.

--Malahal.