Linux Device Mapper development
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH 05/21] libmultipath/checkers: directio: use message id
Date: Fri, 12 Oct 2018 00:26:51 +0200	[thread overview]
Message-ID: <20181011222707.3631-6-mwilck@suse.com> (raw)
In-Reply-To: <20181011222707.3631-1-mwilck@suse.com>

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 libmultipath/checkers/directio.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/libmultipath/checkers/directio.c b/libmultipath/checkers/directio.c
index a80848d4..c4a0712e 100644
--- a/libmultipath/checkers/directio.c
+++ b/libmultipath/checkers/directio.c
@@ -18,10 +18,19 @@
 #include "checkers.h"
 #include "../libmultipath/debug.h"
 
-#define MSG_DIRECTIO_UNKNOWN	"directio checker is not available"
-#define MSG_DIRECTIO_UP		"directio checker reports path is up"
-#define MSG_DIRECTIO_DOWN	"directio checker reports path is down"
-#define MSG_DIRECTIO_PENDING	"directio checker is waiting on aio"
+enum {
+	MSG_DIRECTIO_UNKNOWN = CHECKER_FIRST_MSGID,
+	MSG_DIRECTIO_PENDING,
+	MSG_DIRECTIO_BLOCKSIZE,
+};
+
+#define _IDX(x) (MSG_DIRECTIO_##x - CHECKER_FIRST_MSGID)
+const char *libcheck_msgtable[] = {
+	[_IDX(UNKNOWN)] = " is not available",
+	[_IDX(PENDING)] = " is waiting on aio",
+	[_IDX(BLOCKSIZE)] = " cannot get blocksize, set default",
+	NULL,
+};
 
 #define LOG(prio, fmt, args...) condlog(prio, "directio: " fmt, ##args)
 
@@ -54,7 +63,7 @@ int libcheck_init (struct checker * c)
 	}
 
 	if (ioctl(c->fd, BLKBSZGET, &ct->blksize) < 0) {
-		MSG(c, "cannot get blocksize, set default");
+		c->msgid = MSG_DIRECTIO_BLOCKSIZE;
 		ct->blksize = 512;
 	}
 	if (ct->blksize > 4096) {
@@ -198,16 +207,16 @@ int libcheck_check (struct checker * c)
 	switch (ret)
 	{
 	case PATH_UNCHECKED:
-		MSG(c, MSG_DIRECTIO_UNKNOWN);
+		c->msgid = MSG_DIRECTIO_UNKNOWN;
 		break;
 	case PATH_DOWN:
-		MSG(c, MSG_DIRECTIO_DOWN);
+		c->msgid = CHECKER_MSGID_DOWN;
 		break;
 	case PATH_UP:
-		MSG(c, MSG_DIRECTIO_UP);
+		c->msgid = CHECKER_MSGID_UP;
 		break;
 	case PATH_PENDING:
-		MSG(c, MSG_DIRECTIO_PENDING);
+		c->msgid = MSG_DIRECTIO_PENDING;
 		break;
 	default:
 		break;
-- 
2.19.0

  parent reply	other threads:[~2018-10-11 22:26 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 22:26 [PATCH 00/21] libmultipath: checkers overhaul Martin Wilck
2018-10-11 22:26 ` [PATCH 01/21] libmultipath: fix use of uninitialized memory in write() Martin Wilck
2018-10-25 20:31   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 02/21] libmultipath: fix memory leaks from scandir() use Martin Wilck
2018-10-25 20:31   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 03/21] libmultipath/checkers: replace message by msgid Martin Wilck
2018-10-25 20:57   ` Benjamin Marzinski
2018-10-25 21:36     ` Martin Wilck
2018-10-11 22:26 ` [PATCH 04/21] libmultipath/checkers: cciss_tur: use message id Martin Wilck
2018-10-25 20:57   ` Benjamin Marzinski
2018-10-11 22:26 ` Martin Wilck [this message]
2018-10-25 20:58   ` [PATCH 05/21] libmultipath/checkers: directio: " Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 06/21] libmultipath/checkers: emc_clariion: " Martin Wilck
2018-10-25 20:58   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 07/21] libmultipath/checkers: hp_sw: " Martin Wilck
2018-10-25 20:58   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 08/21] libmultipath/checkers: rdac: " Martin Wilck
2018-10-25 20:59   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 09/21] libmultipath/checkers: readsector0: " Martin Wilck
2018-10-25 21:02   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 10/21] libmultipath/checkers: tur: " Martin Wilck
2018-10-25 21:32   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 11/21] multipathd: improve checker message logging Martin Wilck
2018-10-25 21:32   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 12/21] libmultipath/checkers: support unsupported paths Martin Wilck
2018-10-25 21:33   ` Benjamin Marzinski
2018-10-11 22:26 ` [PATCH 13/21] libmultipath: clariion checker: leave unsupported paths alone Martin Wilck
2018-10-25 21:41   ` Benjamin Marzinski
2018-10-26  9:01     ` Martin Wilck
2018-10-11 22:27 ` [PATCH 14/21] libmultipath: hp_sw " Martin Wilck
2018-10-25 21:42   ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 15/21] libmultipath: rdac " Martin Wilck
2018-10-25 21:42   ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 16/21] libmultipath: tur " Martin Wilck
2018-10-25 21:42   ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 17/21] libmultipath: pathinfo: don't blank wwid if checker fails Martin Wilck
2018-10-25 21:50   ` Benjamin Marzinski
2018-10-26  9:16     ` Martin Wilck
2018-10-26 15:11       ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 18/21] multipathd: check_path: improve logging for "unusable path" case Martin Wilck
2018-10-25 21:50   ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 19/21] libmultipath: coalesce_paths: improve logging of orphaned paths Martin Wilck
2018-10-25 21:50   ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 20/21] libmultipath: sync_map_state: log failing paths Martin Wilck
2018-10-25 21:52   ` Benjamin Marzinski
2018-10-11 22:27 ` [PATCH 21/21] libmultipath/checkers: cleanup class/instance model Martin Wilck
2018-10-25 21:52   ` Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011222707.3631-6-mwilck@suse.com \
    --to=mwilck@suse.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox