[PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[Vladimir Zapolskiy]

After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
64bit access") two branches under macro conditional become identical,
thus the code can be simplified without any functional change.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 drivers/dma/dw-edma/dw-edma-v0-core.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index 33bc1e6c4cf2..c73b9ed1ce74 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -414,19 +414,11 @@ void dw_edma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
 		SET_CH_32(dw, chan->dir, chan->id, ch_control1,
 			  (DW_EDMA_V0_CCS | DW_EDMA_V0_LLE));
 		/* Linked list */
-
-		#ifdef CONFIG_64BIT
 		/* llp is not aligned on 64bit -> keep 32bit accesses */
 		SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
 			  lower_32_bits(chunk->ll_region.paddr));
 		SET_CH_32(dw, chan->dir, chan->id, llp.msb,
 			  upper_32_bits(chunk->ll_region.paddr));
-		#else /* CONFIG_64BIT */
-		SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
-			  lower_32_bits(chunk->ll_region.paddr));
-		SET_CH_32(dw, chan->dir, chan->id, llp.msb,
-			  upper_32_bits(chunk->ll_region.paddr));
-		#endif /* CONFIG_64BIT */
 	}
 	/* Doorbell */
 	SET_RW_32(dw, chan->dir, doorbell,
-- 
2.33.0

Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[Herve Codina]

On Fri, 10 Jun 2022 13:07:00 +0300
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> wrote:

> After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> 64bit access") two branches under macro conditional become identical,
> thus the code can be simplified without any functional change.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  drivers/dma/dw-edma/dw-edma-v0-core.c | 8 --------
>  1 file changed, 8 deletions(-)

Sure,
My first thought was to clearly identify the 64bit case but
I am fully agree, on this simple piece of code, it is not
necessary.

Acked-by: Herve Codina <herve.codina@bootlin.com>

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[Vinod Koul]

On 10-06-22, 13:07, Vladimir Zapolskiy wrote:
> After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> 64bit access") two branches under macro conditional become identical,
> thus the code can be simplified without any functional change.

Applied, thanks

-- 
~Vinod

Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[Frank Li]

On Fri, Jun 10, 2022 at 05:49:36PM +0530, Vinod Koul wrote:
> On 10-06-22, 13:07, Vladimir Zapolskiy wrote:
> > After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> > 64bit access") two branches under macro conditional become identical,
> > thus the code can be simplified without any functional change.
> 
> Applied, thanks

@vinod:
	I am very strang!
	why you pick this patch, not pick one this one
	https://www.spinics.net/lists/dmaengine/msg29735.html
	
	both patch do the exactly the same works.

	Any no any feedback about patches 
	https://www.spinics.net/lists/dmaengine/msg29913.html.
	which already review 12 round and test at three difference platform.
	And at least 3 person working on these patches. 

	At least https://www.spinics.net/lists/dmaengine/msg29914.html is cleanup
	And only two lines change.

	At begin, I think you don't care dw_edma at all. 
	But you pick this patch. 

	I am quite confused.

best regards
Frank Li

> 
> -- 
> ~Vinod
> 

Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[Vinod Koul]

On 15-06-22, 08:36, Frank Li wrote:
> On Fri, Jun 10, 2022 at 05:49:36PM +0530, Vinod Koul wrote:
> > On 10-06-22, 13:07, Vladimir Zapolskiy wrote:
> > > After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> > > 64bit access") two branches under macro conditional become identical,
> > > thus the code can be simplified without any functional change.
> > 
> > Applied, thanks
> 
> @vinod:
> 	I am very strang!
> 	why you pick this patch, not pick one this one
> 	https://www.spinics.net/lists/dmaengine/msg29735.html

Maybe it was on top of the queue for me..

> 	
> 	both patch do the exactly the same works.
> 
> 	Any no any feedback about patches 
> 	https://www.spinics.net/lists/dmaengine/msg29913.html.
> 	which already review 12 round and test at three difference platform.
> 	And at least 3 person working on these patches. 

People can be busy, due to travel/work etc, pls have patience with
reviews. FWIW, I have picked this already

> 
> 	At least https://www.spinics.net/lists/dmaengine/msg29914.html is cleanup
> 	And only two lines change.
> 
> 	At begin, I think you don't care dw_edma at all. 
> 	But you pick this patch. 

Based on my bandwidth, I will pick patches, I dont pick during or before
merge window... It is unfair to say I dont care about a specific driver.
Smaller changes are quick to review and do the needful, larger ones need
more time for review...

-- 
~Vinod