public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: iommu@lists.linux.dev, dmaengine@vger.kernel.org
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF
Date: Thu,  9 Mar 2023 10:56:36 +0800	[thread overview]
Message-ID: <20230309025639.26109-3-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20230309025639.26109-1-baolu.lu@linux.intel.com>

Currently enabling SVA requires IOPF support from the IOMMU and device
PCI PRI. However, some devices can handle IOPF by itself without ever
sending PCI page requests nor advertising PRI capability.

Allow SVA support with IOPF handled either by IOMMU (PCI PRI) or device
driver (device-specific IOPF). As long as IOPF could be handled, SVA
should continue to work.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/iommu.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 7c2f4bd33582..d2fcab9d8f61 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4650,7 +4650,18 @@ static int intel_iommu_enable_sva(struct device *dev)
 	if (!(iommu->flags & VTD_FLAG_SVM_CAPABLE))
 		return -ENODEV;
 
-	if (!info->pasid_enabled || !info->pri_enabled || !info->ats_enabled)
+	if (!info->pasid_enabled)
+		return -EINVAL;
+
+	/*
+	 * Devices having device-specific I/O fault handling should not
+	 * support PCI/PRI.
+	 */
+	if (!info->pri_supported)
+		return 0;
+
+	/* Devices supporting ATS/PRI should have it enabled. */
+	if (!info->pri_enabled || !info->ats_enabled)
 		return -EINVAL;
 
 	ret = iopf_queue_add_device(iommu->iopf_queue, dev);
-- 
2.34.1


  parent reply	other threads:[~2023-03-09  2:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  2:56 [PATCH v2 0/5] Refactor code for non-PRI IOPF Lu Baolu
2023-03-09  2:56 ` [PATCH v2 1/5] dmaengine: idxd: Add enable/disable device IOPF feature Lu Baolu
2023-03-09  3:51   ` Fenghua Yu
2023-03-16  7:08   ` Tian, Kevin
2023-03-09  2:56 ` Lu Baolu [this message]
2023-03-16  7:09   ` [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF Tian, Kevin
2023-03-16  7:31     ` Baolu Lu
2023-03-20 16:00   ` Jacob Pan
2023-03-21  5:43     ` Baolu Lu
2023-03-09  2:56 ` [PATCH v2 3/5] iommu/vt-d: Move iopf code from SVA to IOPF enabling path Lu Baolu
2023-03-16  7:10   ` Tian, Kevin
2023-03-09  2:56 ` [PATCH v2 4/5] iommu/vt-d: Move pfsid and ats_qdep calculation to device probe path Lu Baolu
2023-03-16  7:10   ` Tian, Kevin
2023-03-20 16:11   ` Jacob Pan
2023-03-09  2:56 ` [PATCH v2 5/5] iommu/vt-d: Move PRI handling to IOPF feature path Lu Baolu
2023-03-16  7:17   ` Tian, Kevin
2023-03-16  8:17     ` Baolu Lu
2023-03-17  0:06       ` Tian, Kevin
2023-03-17  0:47         ` Baolu Lu
2023-03-20 16:28   ` Jacob Pan
2023-03-09  3:01 ` [PATCH v2 0/5] Refactor code for non-PRI IOPF Baolu Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230309025639.26109-3-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox