From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
Vinod Koul <vkoul@kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF
Date: Thu, 16 Mar 2023 15:31:19 +0800 [thread overview]
Message-ID: <9cd8f9b8-2362-2145-6f5d-edf47087aca3@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB5276F50D86F8DA507CC18AF18CBC9@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2023/3/16 15:09, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Thursday, March 9, 2023 10:57 AM
>>
>> @@ -4650,7 +4650,18 @@ static int intel_iommu_enable_sva(struct device
>> *dev)
>> if (!(iommu->flags & VTD_FLAG_SVM_CAPABLE))
>> return -ENODEV;
>>
>> - if (!info->pasid_enabled || !info->pri_enabled || !info->ats_enabled)
>> + if (!info->pasid_enabled)
>> + return -EINVAL;
>> +
>
> I think you still want to check ats_enabled even for device specific IOPF.
Yeah! Updated.
Best regards,
baolu
next prev parent reply other threads:[~2023-03-16 7:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 2:56 [PATCH v2 0/5] Refactor code for non-PRI IOPF Lu Baolu
2023-03-09 2:56 ` [PATCH v2 1/5] dmaengine: idxd: Add enable/disable device IOPF feature Lu Baolu
2023-03-09 3:51 ` Fenghua Yu
2023-03-16 7:08 ` Tian, Kevin
2023-03-09 2:56 ` [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF Lu Baolu
2023-03-16 7:09 ` Tian, Kevin
2023-03-16 7:31 ` Baolu Lu [this message]
2023-03-20 16:00 ` Jacob Pan
2023-03-21 5:43 ` Baolu Lu
2023-03-09 2:56 ` [PATCH v2 3/5] iommu/vt-d: Move iopf code from SVA to IOPF enabling path Lu Baolu
2023-03-16 7:10 ` Tian, Kevin
2023-03-09 2:56 ` [PATCH v2 4/5] iommu/vt-d: Move pfsid and ats_qdep calculation to device probe path Lu Baolu
2023-03-16 7:10 ` Tian, Kevin
2023-03-20 16:11 ` Jacob Pan
2023-03-09 2:56 ` [PATCH v2 5/5] iommu/vt-d: Move PRI handling to IOPF feature path Lu Baolu
2023-03-16 7:17 ` Tian, Kevin
2023-03-16 8:17 ` Baolu Lu
2023-03-17 0:06 ` Tian, Kevin
2023-03-17 0:47 ` Baolu Lu
2023-03-20 16:28 ` Jacob Pan
2023-03-09 3:01 ` [PATCH v2 0/5] Refactor code for non-PRI IOPF Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd8f9b8-2362-2145-6f5d-edf47087aca3@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox