From: Fenghua Yu <fenghua.yu@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
<dmaengine@vger.kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] dmaengine: idxd: Add enable/disable device IOPF feature
Date: Wed, 8 Mar 2023 19:51:36 -0800 [thread overview]
Message-ID: <d00b97ed-2d25-c58b-f844-be4f4f159335@intel.com> (raw)
In-Reply-To: <20230309025639.26109-2-baolu.lu@linux.intel.com>
On 3/8/23 18:56, Lu Baolu wrote:
> The iommu subsystem requires IOMMU_DEV_FEAT_IOPF must be enabled before
> and disabled after IOMMU_DEV_FEAT_SVA, if device's I/O page faults rely
> on the IOMMU. Add explicit IOMMU_DEV_FEAT_IOPF enabling/disabling in this
> driver.
>
> At present, missing IOPF enabling/disabling doesn't cause any real issue,
> because the IOMMU driver places the IOPF enabling/disabling in the path
> of SVA feature handling. But this may change.
>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Thanks.
-Fenghua
next prev parent reply other threads:[~2023-03-09 3:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 2:56 [PATCH v2 0/5] Refactor code for non-PRI IOPF Lu Baolu
2023-03-09 2:56 ` [PATCH v2 1/5] dmaengine: idxd: Add enable/disable device IOPF feature Lu Baolu
2023-03-09 3:51 ` Fenghua Yu [this message]
2023-03-16 7:08 ` Tian, Kevin
2023-03-09 2:56 ` [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF Lu Baolu
2023-03-16 7:09 ` Tian, Kevin
2023-03-16 7:31 ` Baolu Lu
2023-03-20 16:00 ` Jacob Pan
2023-03-21 5:43 ` Baolu Lu
2023-03-09 2:56 ` [PATCH v2 3/5] iommu/vt-d: Move iopf code from SVA to IOPF enabling path Lu Baolu
2023-03-16 7:10 ` Tian, Kevin
2023-03-09 2:56 ` [PATCH v2 4/5] iommu/vt-d: Move pfsid and ats_qdep calculation to device probe path Lu Baolu
2023-03-16 7:10 ` Tian, Kevin
2023-03-20 16:11 ` Jacob Pan
2023-03-09 2:56 ` [PATCH v2 5/5] iommu/vt-d: Move PRI handling to IOPF feature path Lu Baolu
2023-03-16 7:17 ` Tian, Kevin
2023-03-16 8:17 ` Baolu Lu
2023-03-17 0:06 ` Tian, Kevin
2023-03-17 0:47 ` Baolu Lu
2023-03-20 16:28 ` Jacob Pan
2023-03-09 3:01 ` [PATCH v2 0/5] Refactor code for non-PRI IOPF Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d00b97ed-2d25-c58b-f844-be4f4f159335@intel.com \
--to=fenghua.yu@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox