DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zaiyu Wang" <zaiyuwang@trustnetic.com>
To: "'Zhang Tengfei'" <zhtfdev@gmail.com>,
	"'Jiawen Wu'" <jiawenwu@trustnetic.com>, <dev@dpdk.org>,
	"'Jiawen Wu'" <jiawenwu@trustnetic.com>, <dev@dpdk.org>
Cc: <stephen@networkplumber.org>
Subject: RE: [PATCH 0/3] net/txgbe: fix FDIR Rx packet buffer handling
Date: Mon, 19 Oct 2026 18:35:54 +0800	[thread overview]
Message-ID: <005101dd5fb5$9e9e80d0$dbdb8270$@trustnetic.com> (raw)
In-Reply-To: <54095ca6-afe3-4c28-bfce-4456d9e30e4b@gmail.com>

> v2 is out. I do not have a txgbe NIC, so it is compile-tested only.
> Would you be able to test it on a txgbe NIC?
> 
> With the port started: create and delete one FDIR rule ten times, then check that PBRXSIZE(0) (0x19020) does not keep shrinking and that
> FDIRCTL (0x19500) is 0 after delete.
> flow validate must not change either register. A rule with an out-of-range queue must fail and leave them unchanged. flow flush must restore
> PBRXSIZE(0). SP and AML if you have both.
> 

Hi Tengfei,

Thanks for the series, and for taking the time to fix these in the txgbe driver.  

I have tested the v2 series on both SP and AML hardware, and it behaves as you described

No further comments from my side. Thanks again.

Acked-by: Zaiyu Wang <zaiyuwang@trustnetic.com>


  reply	other threads:[~2026-10-19 10:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 14:00 [PATCH 0/3] net/txgbe: fix FDIR Rx packet buffer handling Zhang Tengfei
2026-10-13 14:00 ` [PATCH 1/3] net/txgbe: fix Rx packet buffer size with flow director Zhang Tengfei
2026-10-13 14:00 ` [PATCH 2/3] net/txgbe: do not enable flow director on flow validate Zhang Tengfei
2026-10-13 14:00 ` [PATCH 3/3] net/txgbe: disable flow director when no rule is left Zhang Tengfei
2026-10-13 14:45 ` [PATCH 0/3] net/txgbe: fix FDIR Rx packet buffer handling Stephen Hemminger
2026-10-14 16:45   ` Zhang Tengfei
2026-10-20 15:11     ` Stephen Hemminger
2026-10-14  1:39 ` Jiawen Wu
2026-10-14 16:47   ` Zhang Tengfei
2026-10-19 10:35     ` Zaiyu Wang [this message]
2026-10-14 16:39 ` [PATCH v2 " Zhang Tengfei
2026-10-14 16:39   ` [PATCH v2 1/3] net/txgbe: fix Rx packet buffer size with flow director Zhang Tengfei
2026-10-14 16:39   ` [PATCH v2 2/3] net/txgbe: do not enable flow director on flow validate Zhang Tengfei
2026-10-14 16:39   ` [PATCH v2 3/3] net/txgbe: disable flow director when no rule is left Zhang Tengfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005101dd5fb5$9e9e80d0$dbdb8270$@trustnetic.com' \
    --to=zaiyuwang@trustnetic.com \
    --cc=dev@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=stephen@networkplumber.org \
    --cc=zhtfdev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox