* [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces
@ 2014-10-13 10:21 Thierry Reding
2014-10-13 10:21 ` [PATCH 03/14] gpu: host1x: Fix typo in comment Thierry Reding
` (10 more replies)
0 siblings, 11 replies; 15+ messages in thread
From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw)
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Sean Paul, linux-tegra-u79uwXL29TY76Z2rM5mHXA
From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Rather than cast to a u32 use the struct host1x_bo pointers directly.
This avoid annoying warnings for 64-bit builds.
Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
drivers/gpu/host1x/hw/channel_hw.c | 12 ++++++++----
include/trace/events/host1x.h | 27 +++++++++++++++------------
2 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/host1x/hw/channel_hw.c b/drivers/gpu/host1x/hw/channel_hw.c
index 4608257ab656..946c332c3906 100644
--- a/drivers/gpu/host1x/hw/channel_hw.c
+++ b/drivers/gpu/host1x/hw/channel_hw.c
@@ -32,6 +32,7 @@
static void trace_write_gather(struct host1x_cdma *cdma, struct host1x_bo *bo,
u32 offset, u32 words)
{
+ struct device *dev = cdma_to_channel(cdma)->dev;
void *mem = NULL;
if (host1x_debug_trace_cmdbuf)
@@ -44,11 +45,14 @@ static void trace_write_gather(struct host1x_cdma *cdma, struct host1x_bo *bo,
* of how much you can output to ftrace at once.
*/
for (i = 0; i < words; i += TRACE_MAX_LENGTH) {
- trace_host1x_cdma_push_gather(
- dev_name(cdma_to_channel(cdma)->dev),
- (u32)bo, min(words - i, TRACE_MAX_LENGTH),
- offset + i * sizeof(u32), mem);
+ u32 num_words = min(words - i, TRACE_MAX_LENGTH);
+ offset += i * sizeof(u32);
+
+ trace_host1x_cdma_push_gather(dev_name(dev), bo,
+ num_words, offset,
+ mem);
}
+
host1x_bo_munmap(bo, mem);
}
}
diff --git a/include/trace/events/host1x.h b/include/trace/events/host1x.h
index 94db6a2c3540..63116362543c 100644
--- a/include/trace/events/host1x.h
+++ b/include/trace/events/host1x.h
@@ -29,6 +29,8 @@
#include <linux/ktime.h>
#include <linux/tracepoint.h>
+struct host1x_bo;
+
DECLARE_EVENT_CLASS(host1x,
TP_PROTO(const char *name),
TP_ARGS(name),
@@ -79,14 +81,14 @@ TRACE_EVENT(host1x_cdma_push,
);
TRACE_EVENT(host1x_cdma_push_gather,
- TP_PROTO(const char *name, u32 mem_id,
+ TP_PROTO(const char *name, struct host1x_bo *bo,
u32 words, u32 offset, void *cmdbuf),
- TP_ARGS(name, mem_id, words, offset, cmdbuf),
+ TP_ARGS(name, bo, words, offset, cmdbuf),
TP_STRUCT__entry(
__field(const char *, name)
- __field(u32, mem_id)
+ __field(struct host1x_bo *, bo)
__field(u32, words)
__field(u32, offset)
__field(bool, cmdbuf)
@@ -100,13 +102,13 @@ TRACE_EVENT(host1x_cdma_push_gather,
}
__entry->cmdbuf = cmdbuf;
__entry->name = name;
- __entry->mem_id = mem_id;
+ __entry->bo = bo;
__entry->words = words;
__entry->offset = offset;
),
- TP_printk("name=%s, mem_id=%08x, words=%u, offset=%d, contents=[%s]",
- __entry->name, __entry->mem_id,
+ TP_printk("name=%s, bo=%p, words=%u, offset=%d, contents=[%s]",
+ __entry->name, __entry->bo,
__entry->words, __entry->offset,
__print_hex(__get_dynamic_array(cmdbuf),
__entry->cmdbuf ? __entry->words * 4 : 0))
@@ -221,12 +223,13 @@ TRACE_EVENT(host1x_syncpt_load_min,
);
TRACE_EVENT(host1x_syncpt_wait_check,
- TP_PROTO(void *mem_id, u32 offset, u32 syncpt_id, u32 thresh, u32 min),
+ TP_PROTO(struct host1x_bo *bo, u32 offset, u32 syncpt_id, u32 thresh,
+ u32 min),
- TP_ARGS(mem_id, offset, syncpt_id, thresh, min),
+ TP_ARGS(bo, offset, syncpt_id, thresh, min),
TP_STRUCT__entry(
- __field(void *, mem_id)
+ __field(struct host1x_bo *, bo)
__field(u32, offset)
__field(u32, syncpt_id)
__field(u32, thresh)
@@ -234,15 +237,15 @@ TRACE_EVENT(host1x_syncpt_wait_check,
),
TP_fast_assign(
- __entry->mem_id = mem_id;
+ __entry->bo = bo;
__entry->offset = offset;
__entry->syncpt_id = syncpt_id;
__entry->thresh = thresh;
__entry->min = min;
),
- TP_printk("mem_id=%p, offset=%05x, id=%d, thresh=%d, current=%d",
- __entry->mem_id, __entry->offset,
+ TP_printk("bo=%p, offset=%05x, id=%d, thresh=%d, current=%d",
+ __entry->bo, __entry->offset,
__entry->syncpt_id, __entry->thresh,
__entry->min)
);
--
2.1.2
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 03/14] gpu: host1x: Fix typo in comment 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 04/14] gpu: host1x: Print address/offset pairs consistently Thierry Reding ` (9 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Thierry Reding <treding@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/host1x/hw/cdma_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/hw/cdma_hw.c b/drivers/gpu/host1x/hw/cdma_hw.c index a1197c40a454..072d8209c06c 100644 --- a/drivers/gpu/host1x/hw/cdma_hw.c +++ b/drivers/gpu/host1x/hw/cdma_hw.c @@ -26,7 +26,7 @@ #include "../debug.h" /* - * Put the restart at the end of pushbuffer memor + * Put the restart at the end of pushbuffer memory */ static void push_buffer_init(struct push_buffer *pb) { -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 04/14] gpu: host1x: Print address/offset pairs consistently 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding 2014-10-13 10:21 ` [PATCH 03/14] gpu: host1x: Fix typo in comment Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 05/14] gpu: host1x: Make gather offsets unsigned Thierry Reding ` (8 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Thierry Reding <treding@nvidia.com> Consistently use a format of %pad+%#x to print address/offset in debug messages. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/host1x/hw/cdma_hw.c | 4 ++-- drivers/gpu/host1x/hw/debug_hw.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/host1x/hw/cdma_hw.c b/drivers/gpu/host1x/hw/cdma_hw.c index 072d8209c06c..305ea8f3382d 100644 --- a/drivers/gpu/host1x/hw/cdma_hw.c +++ b/drivers/gpu/host1x/hw/cdma_hw.c @@ -54,8 +54,8 @@ static void cdma_timeout_cpu_incr(struct host1x_cdma *cdma, u32 getptr, u32 *p = (u32 *)(pb->mapped + getptr); *(p++) = HOST1X_OPCODE_NOP; *(p++) = HOST1X_OPCODE_NOP; - dev_dbg(host1x->dev, "%s: NOP at %#llx\n", __func__, - (u64)pb->phys + getptr); + dev_dbg(host1x->dev, "%s: NOP at %pad+%#x\n", __func__, + &pb->phys, getptr); getptr = (getptr + 8) & (pb->size_bytes - 1); } wmb(); diff --git a/drivers/gpu/host1x/hw/debug_hw.c b/drivers/gpu/host1x/hw/debug_hw.c index f72c873eff81..791de9351eeb 100644 --- a/drivers/gpu/host1x/hw/debug_hw.c +++ b/drivers/gpu/host1x/hw/debug_hw.c @@ -163,8 +163,8 @@ static void show_channel_gathers(struct output *o, struct host1x_cdma *cdma) continue; } - host1x_debug_output(o, " GATHER at %#llx+%04x, %d words\n", - (u64)g->base, g->offset, g->words); + host1x_debug_output(o, " GATHER at %pad+%#x, %d words\n", + &g->base, g->offset, g->words); show_gather(o, g->base + g->offset, g->words, cdma, g->base, mapped); -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 05/14] gpu: host1x: Make gather offsets unsigned 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding 2014-10-13 10:21 ` [PATCH 03/14] gpu: host1x: Fix typo in comment Thierry Reding 2014-10-13 10:21 ` [PATCH 04/14] gpu: host1x: Print address/offset pairs consistently Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding [not found] ` <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ` (7 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Thierry Reding <treding@nvidia.com> Use the u32 type for the offset in the host1x_job_gather structure for consistentcy with other structures. Negative offsets don't make sense in this context. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/host1x/job.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/job.h b/drivers/gpu/host1x/job.h index 33a697d6dcef..8b3c15df0660 100644 --- a/drivers/gpu/host1x/job.h +++ b/drivers/gpu/host1x/job.h @@ -23,7 +23,7 @@ struct host1x_job_gather { u32 words; dma_addr_t base; struct host1x_bo *bo; - int offset; + u32 offset; bool handled; }; -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH 02/14] gpu: host1x: Make mapped field of push buffers void * [not found] ` <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 06/14] gpu: host1x: mipi: Registers are 32 bits wide Thierry Reding 2014-10-13 10:21 ` [PATCH 11/14] drm/tegra: Do not enable output on .mode_set() Thierry Reding 2 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Sean Paul, linux-tegra-u79uwXL29TY76Z2rM5mHXA From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> This reduces the amount of casting that needs to be done to get rid of annoying warnings on 64-bit builds. Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- drivers/gpu/host1x/cdma.c | 2 +- drivers/gpu/host1x/cdma.h | 2 +- drivers/gpu/host1x/hw/cdma_hw.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c index 3995255b16c7..5a8c8d55317a 100644 --- a/drivers/gpu/host1x/cdma.c +++ b/drivers/gpu/host1x/cdma.c @@ -97,7 +97,7 @@ fail: static void host1x_pushbuffer_push(struct push_buffer *pb, u32 op1, u32 op2) { u32 pos = pb->pos; - u32 *p = (u32 *)((u32)pb->mapped + pos); + u32 *p = (u32 *)((void *)pb->mapped + pos); WARN_ON(pos == pb->fence); *(p++) = op1; *(p++) = op2; diff --git a/drivers/gpu/host1x/cdma.h b/drivers/gpu/host1x/cdma.h index 313c4b784348..470087af8fe5 100644 --- a/drivers/gpu/host1x/cdma.h +++ b/drivers/gpu/host1x/cdma.h @@ -42,7 +42,7 @@ struct host1x_job; */ struct push_buffer { - u32 *mapped; /* mapped pushbuffer memory */ + void *mapped; /* mapped pushbuffer memory */ dma_addr_t phys; /* physical address of pushbuffer */ u32 fence; /* index we've written */ u32 pos; /* index to write to */ diff --git a/drivers/gpu/host1x/hw/cdma_hw.c b/drivers/gpu/host1x/hw/cdma_hw.c index 6b09b71940c2..a1197c40a454 100644 --- a/drivers/gpu/host1x/hw/cdma_hw.c +++ b/drivers/gpu/host1x/hw/cdma_hw.c @@ -30,7 +30,7 @@ */ static void push_buffer_init(struct push_buffer *pb) { - *(pb->mapped + (pb->size_bytes >> 2)) = host1x_opcode_restart(0); + *(u32 *)(pb->mapped + pb->size_bytes) = host1x_opcode_restart(0); } /* @@ -51,7 +51,7 @@ static void cdma_timeout_cpu_incr(struct host1x_cdma *cdma, u32 getptr, /* NOP all the PB slots */ while (nr_slots--) { - u32 *p = (u32 *)((u32)pb->mapped + getptr); + u32 *p = (u32 *)(pb->mapped + getptr); *(p++) = HOST1X_OPCODE_NOP; *(p++) = HOST1X_OPCODE_NOP; dev_dbg(host1x->dev, "%s: NOP at %#llx\n", __func__, -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 06/14] gpu: host1x: mipi: Registers are 32 bits wide [not found] ` <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-10-13 10:21 ` [PATCH 02/14] gpu: host1x: Make mapped field of push buffers void * Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 11/14] drm/tegra: Do not enable output on .mode_set() Thierry Reding 2 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Sean Paul, linux-tegra-u79uwXL29TY76Z2rM5mHXA From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> On 64-bit platforms an unsigned long would be 64 bit and cause unnecessary casting when being passed to writel() or returned from readl(). Make register values 32 bits wide to avoid that. Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- drivers/gpu/host1x/mipi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index 9882ea122024..a3e215a0116f 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -90,16 +90,16 @@ struct tegra_mipi_device { unsigned long pads; }; -static inline unsigned long tegra_mipi_readl(struct tegra_mipi *mipi, - unsigned long reg) +static inline u32 tegra_mipi_readl(struct tegra_mipi *mipi, + unsigned long offset) { - return readl(mipi->regs + (reg << 2)); + return readl(mipi->regs + (offset << 2)); } -static inline void tegra_mipi_writel(struct tegra_mipi *mipi, - unsigned long value, unsigned long reg) +static inline void tegra_mipi_writel(struct tegra_mipi *mipi, u32 value, + unsigned long offset) { - writel(value, mipi->regs + (reg << 2)); + writel(value, mipi->regs + (offset << 2)); } struct tegra_mipi_device *tegra_mipi_request(struct device *device) @@ -161,7 +161,7 @@ EXPORT_SYMBOL(tegra_mipi_free); static int tegra_mipi_wait(struct tegra_mipi *mipi) { unsigned long timeout = jiffies + msecs_to_jiffies(250); - unsigned long value; + u32 value; while (time_before(jiffies, timeout)) { value = tegra_mipi_readl(mipi, MIPI_CAL_STATUS); @@ -177,8 +177,8 @@ static int tegra_mipi_wait(struct tegra_mipi *mipi) int tegra_mipi_calibrate(struct tegra_mipi_device *device) { - unsigned long value; unsigned int i; + u32 value; int err; err = clk_enable(device->mipi->clk); -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 11/14] drm/tegra: Do not enable output on .mode_set() [not found] ` <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-10-13 10:21 ` [PATCH 02/14] gpu: host1x: Make mapped field of push buffers void * Thierry Reding 2014-10-13 10:21 ` [PATCH 06/14] gpu: host1x: mipi: Registers are 32 bits wide Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Sean Paul, linux-tegra-u79uwXL29TY76Z2rM5mHXA From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> The output is already enabled in .dpms(), doing it in .mode_set() too can cause noticable flicker. Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- drivers/gpu/drm/tegra/output.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index 0c67d7eebc94..6b393cfbb5e7 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -167,12 +167,6 @@ static void tegra_encoder_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode, struct drm_display_mode *adjusted) { - struct tegra_output *output = encoder_to_output(encoder); - int err; - - err = tegra_output_enable(output); - if (err < 0) - dev_err(encoder->dev->dev, "tegra_output_enable(): %d\n", err); } static const struct drm_encoder_helper_funcs encoder_helper_funcs = { -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 07/14] gpu: host1x: mipi: Preserve the contents of MIPI_CAL_CTRL 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (3 preceding siblings ...) [not found] ` <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 08/14] gpu: host1x: mipi: Calibrate clock lanes Thierry Reding ` (5 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Sean Paul <seanpaul@chromium.org> By paving the CTRL reg value, the current code changes MIPI_CAL_PRESCALE ("Auto-cal calibration step prescale") from 1us to 0.1us (val=0). In the description for PHY's noise filter (MIPI_CAL_NOISE_FLT), the TRM states that if the value of the prescale is 0 (or 0.1us), the filter should be set between 2-5. However, the current code sets it to 0. For now, let's keep the prescale and filter values as-is, which is most likely the power-on-reset values of 0x2 and 0xa, respectively. Signed-off-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/host1x/mipi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index a3e215a0116f..0d8c3ae8db6a 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -208,7 +208,9 @@ int tegra_mipi_calibrate(struct tegra_mipi_device *device) tegra_mipi_writel(device->mipi, value, modules[i].reg); } - tegra_mipi_writel(device->mipi, MIPI_CAL_CTRL_START, MIPI_CAL_CTRL); + value = tegra_mipi_readl(device->mipi, MIPI_CAL_CTRL); + value |= MIPI_CAL_CTRL_START; + tegra_mipi_writel(device->mipi, value, MIPI_CAL_CTRL); err = tegra_mipi_wait(device->mipi); -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 08/14] gpu: host1x: mipi: Calibrate clock lanes 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (4 preceding siblings ...) 2014-10-13 10:21 ` [PATCH 07/14] gpu: host1x: mipi: Preserve the contents of MIPI_CAL_CTRL Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 09/14] gpu: host1x: mipi: Set MIPI_CAL_BIAS_PAD_CFG1 register Thierry Reding ` (4 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Sean Paul <seanpaul@chromium.org> Include the clock lanes when calibrating the MIPI PHY on Tegra124 compatible devices. Signed-off-by: Sean Paul <seanpaul@chromium.org> [treding@nvidia.com: bikeshedding] Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/host1x/mipi.c | 124 ++++++++++++++++++++++++++++++++++------------ 1 file changed, 92 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index 0d8c3ae8db6a..22e20c2399c5 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -49,11 +49,24 @@ #define MIPI_CAL_CONFIG_DSIC 0x10 #define MIPI_CAL_CONFIG_DSID 0x11 +#define MIPI_CAL_CONFIG_DSIAB_CLK 0x19 +#define MIPI_CAL_CONFIG_DSICD_CLK 0x1a +#define MIPI_CAL_CONFIG_CSIAB_CLK 0x1b +#define MIPI_CAL_CONFIG_CSICD_CLK 0x1c +#define MIPI_CAL_CONFIG_CSIE_CLK 0x1d + +/* for data and clock lanes */ #define MIPI_CAL_CONFIG_SELECT (1 << 21) + +/* for data lanes */ #define MIPI_CAL_CONFIG_HSPDOS(x) (((x) & 0x1f) << 16) #define MIPI_CAL_CONFIG_HSPUOS(x) (((x) & 0x1f) << 8) #define MIPI_CAL_CONFIG_TERMOS(x) (((x) & 0x1f) << 0) +/* for clock lanes */ +#define MIPI_CAL_CONFIG_HSCLKPDOSD(x) (((x) & 0x1f) << 8) +#define MIPI_CAL_CONFIG_HSCLKPUOSD(x) (((x) & 0x1f) << 0) + #define MIPI_CAL_BIAS_PAD_CFG0 0x16 #define MIPI_CAL_BIAS_PAD_PDVCLAMP (1 << 1) #define MIPI_CAL_BIAS_PAD_E_VCLAMP_REF (1 << 0) @@ -63,21 +76,19 @@ #define MIPI_CAL_BIAS_PAD_CFG2 0x18 #define MIPI_CAL_BIAS_PAD_PDVREG (1 << 1) -static const struct module { - unsigned long reg; -} modules[] = { - { .reg = MIPI_CAL_CONFIG_CSIA }, - { .reg = MIPI_CAL_CONFIG_CSIB }, - { .reg = MIPI_CAL_CONFIG_CSIC }, - { .reg = MIPI_CAL_CONFIG_CSID }, - { .reg = MIPI_CAL_CONFIG_CSIE }, - { .reg = MIPI_CAL_CONFIG_DSIA }, - { .reg = MIPI_CAL_CONFIG_DSIB }, - { .reg = MIPI_CAL_CONFIG_DSIC }, - { .reg = MIPI_CAL_CONFIG_DSID }, +struct tegra_mipi_pad { + unsigned long data; + unsigned long clk; +}; + +struct tegra_mipi_soc { + bool has_clk_lane; + const struct tegra_mipi_pad *pads; + unsigned int num_pads; }; struct tegra_mipi { + const struct tegra_mipi_soc *soc; void __iomem *regs; struct mutex lock; struct clk *clk; @@ -117,36 +128,35 @@ struct tegra_mipi_device *tegra_mipi_request(struct device *device) dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (!dev) { - of_node_put(args.np); err = -ENOMEM; goto out; } dev->pdev = of_find_device_by_node(args.np); if (!dev->pdev) { - of_node_put(args.np); err = -ENODEV; goto free; } - of_node_put(args.np); - dev->mipi = platform_get_drvdata(dev->pdev); if (!dev->mipi) { err = -EPROBE_DEFER; - goto pdev_put; + goto put; } + of_node_put(args.np); + dev->pads = args.args[0]; dev->device = device; return dev; -pdev_put: +put: platform_device_put(dev->pdev); free: kfree(dev); out: + of_node_put(args.np); return ERR_PTR(err); } EXPORT_SYMBOL(tegra_mipi_request); @@ -177,6 +187,7 @@ static int tegra_mipi_wait(struct tegra_mipi *mipi) int tegra_mipi_calibrate(struct tegra_mipi_device *device) { + const struct tegra_mipi_soc *soc = device->mipi->soc; unsigned int i; u32 value; int err; @@ -196,16 +207,23 @@ int tegra_mipi_calibrate(struct tegra_mipi_device *device) value &= ~MIPI_CAL_BIAS_PAD_PDVREG; tegra_mipi_writel(device->mipi, value, MIPI_CAL_BIAS_PAD_CFG2); - for (i = 0; i < ARRAY_SIZE(modules); i++) { - if (device->pads & BIT(i)) - value = MIPI_CAL_CONFIG_SELECT | - MIPI_CAL_CONFIG_HSPDOS(0) | - MIPI_CAL_CONFIG_HSPUOS(4) | - MIPI_CAL_CONFIG_TERMOS(5); - else - value = 0; + for (i = 0; i < soc->num_pads; i++) { + u32 clk = 0, data = 0; + + if (device->pads & BIT(i)) { + data = MIPI_CAL_CONFIG_SELECT | + MIPI_CAL_CONFIG_HSPDOS(0) | + MIPI_CAL_CONFIG_HSPUOS(4) | + MIPI_CAL_CONFIG_TERMOS(5); + clk = MIPI_CAL_CONFIG_SELECT | + MIPI_CAL_CONFIG_HSCLKPDOSD(0) | + MIPI_CAL_CONFIG_HSCLKPUOSD(4); + } + + tegra_mipi_writel(device->mipi, data, soc->pads[i].data); - tegra_mipi_writel(device->mipi, value, modules[i].reg); + if (soc->has_clk_lane) + tegra_mipi_writel(device->mipi, clk, soc->pads[i].clk); } value = tegra_mipi_readl(device->mipi, MIPI_CAL_CTRL); @@ -221,16 +239,63 @@ int tegra_mipi_calibrate(struct tegra_mipi_device *device) } EXPORT_SYMBOL(tegra_mipi_calibrate); +static const struct tegra_mipi_pad tegra114_mipi_pads[] = { + { .data = MIPI_CAL_CONFIG_CSIA }, + { .data = MIPI_CAL_CONFIG_CSIB }, + { .data = MIPI_CAL_CONFIG_CSIC }, + { .data = MIPI_CAL_CONFIG_CSID }, + { .data = MIPI_CAL_CONFIG_CSIE }, + { .data = MIPI_CAL_CONFIG_DSIA }, + { .data = MIPI_CAL_CONFIG_DSIB }, + { .data = MIPI_CAL_CONFIG_DSIC }, + { .data = MIPI_CAL_CONFIG_DSID }, +}; + +static const struct tegra_mipi_soc tegra114_mipi_soc = { + .has_clk_lane = false, + .pads = tegra114_mipi_pads, + .num_pads = ARRAY_SIZE(tegra114_mipi_pads), +}; + +static const struct tegra_mipi_pad tegra124_mipi_pads[] = { + { .data = MIPI_CAL_CONFIG_CSIA, .clk = MIPI_CAL_CONFIG_CSIAB_CLK }, + { .data = MIPI_CAL_CONFIG_CSIB, .clk = MIPI_CAL_CONFIG_CSIAB_CLK }, + { .data = MIPI_CAL_CONFIG_CSIC, .clk = MIPI_CAL_CONFIG_CSICD_CLK }, + { .data = MIPI_CAL_CONFIG_CSID, .clk = MIPI_CAL_CONFIG_CSICD_CLK }, + { .data = MIPI_CAL_CONFIG_CSIE, .clk = MIPI_CAL_CONFIG_CSIE_CLK }, + { .data = MIPI_CAL_CONFIG_DSIA, .clk = MIPI_CAL_CONFIG_DSIAB_CLK }, + { .data = MIPI_CAL_CONFIG_DSIB, .clk = MIPI_CAL_CONFIG_DSIAB_CLK }, +}; + +static const struct tegra_mipi_soc tegra124_mipi_soc = { + .has_clk_lane = true, + .pads = tegra124_mipi_pads, + .num_pads = ARRAY_SIZE(tegra124_mipi_pads), +}; + +static struct of_device_id tegra_mipi_of_match[] = { + { .compatible = "nvidia,tegra114-mipi", .data = &tegra114_mipi_soc }, + { .compatible = "nvidia,tegra124-mipi", .data = &tegra124_mipi_soc }, + { }, +}; + static int tegra_mipi_probe(struct platform_device *pdev) { + const struct of_device_id *match; struct tegra_mipi *mipi; struct resource *res; int err; + match = of_match_node(tegra_mipi_of_match, pdev->dev.of_node); + if (!match) + return -ENODEV; + mipi = devm_kzalloc(&pdev->dev, sizeof(*mipi), GFP_KERNEL); if (!mipi) return -ENOMEM; + mipi->soc = match->data; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mipi->regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(mipi->regs)) @@ -262,11 +327,6 @@ static int tegra_mipi_remove(struct platform_device *pdev) return 0; } -static struct of_device_id tegra_mipi_of_match[] = { - { .compatible = "nvidia,tegra114-mipi", }, - { }, -}; - struct platform_driver tegra_mipi_driver = { .driver = { .name = "tegra-mipi", -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 09/14] gpu: host1x: mipi: Set MIPI_CAL_BIAS_PAD_CFG1 register 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (5 preceding siblings ...) 2014-10-13 10:21 ` [PATCH 08/14] gpu: host1x: mipi: Calibrate clock lanes Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 10/14] drm/tegra: dc: Add powergate support Thierry Reding ` (3 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Sean Paul <seanpaul@chromium.org> During calibration, sets the "internal reference level for drive pull- down" to the value specified in the Tegra TRM. Signed-off-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/host1x/mipi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index 22e20c2399c5..fbc6ee6ca337 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -72,6 +72,7 @@ #define MIPI_CAL_BIAS_PAD_E_VCLAMP_REF (1 << 0) #define MIPI_CAL_BIAS_PAD_CFG1 0x17 +#define MIPI_CAL_BIAS_PAD_DRV_DN_REF(x) (((x) & 0x7) << 16) #define MIPI_CAL_BIAS_PAD_CFG2 0x18 #define MIPI_CAL_BIAS_PAD_PDVREG (1 << 1) @@ -203,6 +204,9 @@ int tegra_mipi_calibrate(struct tegra_mipi_device *device) value |= MIPI_CAL_BIAS_PAD_E_VCLAMP_REF; tegra_mipi_writel(device->mipi, value, MIPI_CAL_BIAS_PAD_CFG0); + tegra_mipi_writel(device->mipi, MIPI_CAL_BIAS_PAD_DRV_DN_REF(2), + MIPI_CAL_BIAS_PAD_CFG1); + value = tegra_mipi_readl(device->mipi, MIPI_CAL_BIAS_PAD_CFG2); value &= ~MIPI_CAL_BIAS_PAD_PDVREG; tegra_mipi_writel(device->mipi, value, MIPI_CAL_BIAS_PAD_CFG2); -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 10/14] drm/tegra: dc: Add powergate support 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (6 preceding siblings ...) 2014-10-13 10:21 ` [PATCH 09/14] gpu: host1x: mipi: Set MIPI_CAL_BIAS_PAD_CFG1 register Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 12/14] drm/tegra: dsi: Make FIFO depths host parameters Thierry Reding ` (2 subsequent siblings) 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Thierry Reding <treding@nvidia.com> Both display controllers are in their own power partition. Currently the driver relies on the assumption that these partitions are on (which is the hardware default). However some bootloaders may disable them, so the driver must make sure to turn them back on to avoid hangs. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/drm/tegra/dc.c | 45 ++++++++++++++++++++++++++++++++++++++++++--- drivers/gpu/drm/tegra/drm.h | 1 + 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 6553fd238685..4a015232e2e8 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -11,6 +11,8 @@ #include <linux/debugfs.h> #include <linux/reset.h> +#include <soc/tegra/pmc.h> + #include "dc.h" #include "drm.h" #include "gem.h" @@ -20,6 +22,7 @@ struct tegra_dc_soc_info { bool supports_cursor; bool supports_block_linear; unsigned int pitch_align; + bool has_powergate; }; struct tegra_plane { @@ -1357,6 +1360,7 @@ static const struct tegra_dc_soc_info tegra20_dc_soc_info = { .supports_cursor = false, .supports_block_linear = false, .pitch_align = 8, + .has_powergate = false, }; static const struct tegra_dc_soc_info tegra30_dc_soc_info = { @@ -1364,6 +1368,7 @@ static const struct tegra_dc_soc_info tegra30_dc_soc_info = { .supports_cursor = false, .supports_block_linear = false, .pitch_align = 8, + .has_powergate = false, }; static const struct tegra_dc_soc_info tegra114_dc_soc_info = { @@ -1371,6 +1376,7 @@ static const struct tegra_dc_soc_info tegra114_dc_soc_info = { .supports_cursor = false, .supports_block_linear = false, .pitch_align = 64, + .has_powergate = true, }; static const struct tegra_dc_soc_info tegra124_dc_soc_info = { @@ -1378,6 +1384,7 @@ static const struct tegra_dc_soc_info tegra124_dc_soc_info = { .supports_cursor = true, .supports_block_linear = true, .pitch_align = 64, + .has_powergate = true, }; static const struct of_device_id tegra_dc_of_match[] = { @@ -1385,6 +1392,9 @@ static const struct of_device_id tegra_dc_of_match[] = { .compatible = "nvidia,tegra124-dc", .data = &tegra124_dc_soc_info, }, { + .compatible = "nvidia,tegra114-dc", + .data = &tegra114_dc_soc_info, + }, { .compatible = "nvidia,tegra30-dc", .data = &tegra30_dc_soc_info, }, { @@ -1467,9 +1477,34 @@ static int tegra_dc_probe(struct platform_device *pdev) return PTR_ERR(dc->rst); } - err = clk_prepare_enable(dc->clk); - if (err < 0) - return err; + if (dc->soc->has_powergate) { + if (dc->pipe == 0) + dc->powergate = TEGRA_POWERGATE_DIS; + else + dc->powergate = TEGRA_POWERGATE_DISB; + + err = tegra_powergate_sequence_power_up(dc->powergate, dc->clk, + dc->rst); + if (err < 0) { + dev_err(&pdev->dev, "failed to power partition: %d\n", + err); + return err; + } + } else { + err = clk_prepare_enable(dc->clk); + if (err < 0) { + dev_err(&pdev->dev, "failed to enable clock: %d\n", + err); + return err; + } + + err = reset_control_deassert(dc->rst); + if (err < 0) { + dev_err(&pdev->dev, "failed to deassert reset: %d\n", + err); + return err; + } + } regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); dc->regs = devm_ioremap_resource(&pdev->dev, regs); @@ -1523,6 +1558,10 @@ static int tegra_dc_remove(struct platform_device *pdev) } reset_control_assert(dc->rst); + + if (dc->soc->has_powergate) + tegra_powergate_power_off(dc->powergate); + clk_disable_unprepare(dc->clk); return 0; diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h index e89c70fa82d5..b994c017971d 100644 --- a/drivers/gpu/drm/tegra/drm.h +++ b/drivers/gpu/drm/tegra/drm.h @@ -101,6 +101,7 @@ struct tegra_dc { spinlock_t lock; struct drm_crtc base; + int powergate; int pipe; struct clk *clk; -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 12/14] drm/tegra: dsi: Make FIFO depths host parameters 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (7 preceding siblings ...) 2014-10-13 10:21 ` [PATCH 10/14] drm/tegra: dc: Add powergate support Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 2014-10-13 10:21 ` [PATCH 13/14] drm/tegra: dsi: Add ganged mode support Thierry Reding 2014-10-13 10:21 ` [PATCH 14/14] drm/tegra: dsi: Set up PHY_TIMING & BTA_TIMING registers earlier Thierry Reding 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Thierry Reding <treding@nvidia.com> Rather than hardcoding them as macros, make the host and video FIFO depths parameters so that they can be more easily adjusted if a new generation of the Tegra SoC changes them. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/drm/tegra/dsi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index f7874458926a..584b771d8b2f 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -26,9 +26,6 @@ #include "dsi.h" #include "mipi-phy.h" -#define DSI_VIDEO_FIFO_DEPTH (1920 / 4) -#define DSI_HOST_FIFO_DEPTH 64 - struct tegra_dsi { struct host1x_client client; struct tegra_output output; @@ -54,6 +51,9 @@ struct tegra_dsi { struct regulator *vdd; bool enabled; + + unsigned int video_fifo_depth; + unsigned int host_fifo_depth; }; static inline struct tegra_dsi * @@ -467,7 +467,7 @@ static int tegra_output_dsi_enable(struct tegra_output *output) DSI_CONTROL_SOURCE(dc->pipe); tegra_dsi_writel(dsi, value, DSI_CONTROL); - tegra_dsi_writel(dsi, DSI_VIDEO_FIFO_DEPTH, DSI_MAX_THRESHOLD); + tegra_dsi_writel(dsi, dsi->video_fifo_depth, DSI_MAX_THRESHOLD); value = DSI_HOST_CONTROL_HS | DSI_HOST_CONTROL_CS | DSI_HOST_CONTROL_ECC; @@ -843,6 +843,8 @@ static int tegra_dsi_probe(struct platform_device *pdev) return -ENOMEM; dsi->output.dev = dsi->dev = &pdev->dev; + dsi->video_fifo_depth = 1920; + dsi->host_fifo_depth = 64; err = tegra_output_probe(&dsi->output); if (err < 0) -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 13/14] drm/tegra: dsi: Add ganged mode support 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (8 preceding siblings ...) 2014-10-13 10:21 ` [PATCH 12/14] drm/tegra: dsi: Make FIFO depths host parameters Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding [not found] ` <1413195715-4719-13-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-10-13 10:21 ` [PATCH 14/14] drm/tegra: dsi: Set up PHY_TIMING & BTA_TIMING registers earlier Thierry Reding 10 siblings, 1 reply; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Thierry Reding <treding@nvidia.com> Implement ganged mode support for the Tegra DSI driver. The DSI host controller to gang up with is specified via a phandle in the device tree and the resolved DSI host controller used for the programming of the ganged-mode registers. Signed-off-by: Thierry Reding <treding@nvidia.com> --- .../bindings/gpu/nvidia,tegra20-host1x.txt | 2 + drivers/gpu/drm/tegra/dsi.c | 767 +++++++++++++++++---- drivers/gpu/drm/tegra/dsi.h | 14 +- 3 files changed, 666 insertions(+), 117 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt index b48f4ef31d93..4c32ef0b7db8 100644 --- a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt +++ b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt @@ -191,6 +191,8 @@ of the following host1x client modules: - nvidia,hpd-gpio: specifies a GPIO used for hotplug detection - nvidia,edid: supplies a binary EDID blob - nvidia,panel: phandle of a display panel + - nvidia,ganged-mode: contains a phandle to a second DSI controller to gang + up with in order to support up to 8 data lanes - sor: serial output resource diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 584b771d8b2f..b7b205496e8c 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -11,6 +11,7 @@ #include <linux/host1x.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/reset.h> @@ -54,6 +55,10 @@ struct tegra_dsi { unsigned int video_fifo_depth; unsigned int host_fifo_depth; + + /* for ganged-mode support */ + struct tegra_dsi *master; + struct tegra_dsi *slave; }; static inline struct tegra_dsi * @@ -318,6 +323,21 @@ static const u32 pkt_seq_video_non_burst_sync_events[NUM_PKT_SEQ] = { [11] = PKT_ID0(MIPI_DSI_BLANKING_PACKET) | PKT_LEN0(4), }; +static const u32 pkt_seq_command_mode[NUM_PKT_SEQ] = { + [ 0] = 0, + [ 1] = 0, + [ 2] = 0, + [ 3] = 0, + [ 4] = 0, + [ 5] = 0, + [ 6] = PKT_ID0(MIPI_DSI_DCS_LONG_WRITE) | PKT_LEN0(3) | PKT_LP, + [ 7] = 0, + [ 8] = 0, + [ 9] = 0, + [10] = PKT_ID0(MIPI_DSI_DCS_LONG_WRITE) | PKT_LEN0(5) | PKT_LP, + [11] = 0, +}; + static int tegra_dsi_set_phy_timing(struct tegra_dsi *dsi) { struct mipi_dphy_timing timing; @@ -329,7 +349,7 @@ static int tegra_dsi_set_phy_timing(struct tegra_dsi *dsi) if (rate < 0) return rate; - period = DIV_ROUND_CLOSEST(1000000000UL, rate * 2); + period = DIV_ROUND_CLOSEST(NSEC_PER_SEC, rate * 2); err = mipi_dphy_timing_get_default(&timing, period); if (err < 0) @@ -426,26 +446,59 @@ static int tegra_dsi_get_format(enum mipi_dsi_pixel_format format, return 0; } -static int tegra_output_dsi_enable(struct tegra_output *output) +static void tegra_dsi_ganged_enable(struct tegra_dsi *dsi, unsigned int start, + unsigned int size) +{ + u32 value; + + tegra_dsi_writel(dsi, start, DSI_GANGED_MODE_START); + tegra_dsi_writel(dsi, size << 16 | size, DSI_GANGED_MODE_SIZE); + + value = DSI_GANGED_MODE_CONTROL_ENABLE; + tegra_dsi_writel(dsi, value, DSI_GANGED_MODE_CONTROL); +} + +static void tegra_dsi_enable(struct tegra_dsi *dsi) +{ + u32 value; + + value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); + value |= DSI_POWER_CONTROL_ENABLE; + tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); + + if (dsi->slave) + tegra_dsi_enable(dsi->slave); +} + +static unsigned int tegra_dsi_get_lanes(struct tegra_dsi *dsi) +{ + if (dsi->master) + return dsi->master->lanes + dsi->lanes; + + if (dsi->slave) + return dsi->lanes + dsi->slave->lanes; + + return dsi->lanes; +} + +static int tegra_dsi_configure(struct tegra_dsi *dsi, unsigned int pipe, + const struct drm_display_mode *mode) { - struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); - struct drm_display_mode *mode = &dc->base.mode; unsigned int hact, hsw, hbp, hfp, i, mul, div; - struct tegra_dsi *dsi = to_dsi(output); enum tegra_dsi_format format; - unsigned long value; const u32 *pkt_seq; + u32 value; int err; - if (dsi->enabled) - return 0; - if (dsi->flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) { DRM_DEBUG_KMS("Non-burst video mode with sync pulses\n"); pkt_seq = pkt_seq_video_non_burst_sync_pulses; - } else { + } else if (dsi->flags & MIPI_DSI_MODE_VIDEO) { DRM_DEBUG_KMS("Non-burst video mode with sync events\n"); pkt_seq = pkt_seq_video_non_burst_sync_events; + } else { + DRM_DEBUG_KMS("Command mode\n"); + pkt_seq = pkt_seq_command_mode; } err = tegra_dsi_get_muldiv(dsi->format, &mul, &div); @@ -456,28 +509,29 @@ static int tegra_output_dsi_enable(struct tegra_output *output) if (err < 0) return err; - err = clk_enable(dsi->clk); - if (err < 0) - return err; - - reset_control_deassert(dsi->rst); - value = DSI_CONTROL_CHANNEL(0) | DSI_CONTROL_FORMAT(format) | DSI_CONTROL_LANES(dsi->lanes - 1) | - DSI_CONTROL_SOURCE(dc->pipe); + DSI_CONTROL_SOURCE(pipe); tegra_dsi_writel(dsi, value, DSI_CONTROL); tegra_dsi_writel(dsi, dsi->video_fifo_depth, DSI_MAX_THRESHOLD); - value = DSI_HOST_CONTROL_HS | DSI_HOST_CONTROL_CS | - DSI_HOST_CONTROL_ECC; + value = DSI_HOST_CONTROL_HS; tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); value = tegra_dsi_readl(dsi, DSI_CONTROL); + if (dsi->flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) value |= DSI_CONTROL_HS_CLK_CTRL; + value &= ~DSI_CONTROL_TX_TRIG(3); - value &= ~DSI_CONTROL_DCS_ENABLE; + + /* enable DCS commands for command mode */ + if (dsi->flags & MIPI_DSI_MODE_VIDEO) + value &= ~DSI_CONTROL_DCS_ENABLE; + else + value |= DSI_CONTROL_DCS_ENABLE; + value |= DSI_CONTROL_VIDEO_ENABLE; value &= ~DSI_CONTROL_HOST_ENABLE; tegra_dsi_writel(dsi, value, DSI_CONTROL); @@ -489,28 +543,106 @@ static int tegra_output_dsi_enable(struct tegra_output *output) for (i = 0; i < NUM_PKT_SEQ; i++) tegra_dsi_writel(dsi, pkt_seq[i], DSI_PKT_SEQ_0_LO + i); - /* horizontal active pixels */ - hact = mode->hdisplay * mul / div; + if (dsi->flags & MIPI_DSI_MODE_VIDEO) { + /* horizontal active pixels */ + hact = mode->hdisplay * mul / div; - /* horizontal sync width */ - hsw = (mode->hsync_end - mode->hsync_start) * mul / div; - hsw -= 10; + /* horizontal sync width */ + hsw = (mode->hsync_end - mode->hsync_start) * mul / div; + hsw -= 10; - /* horizontal back porch */ - hbp = (mode->htotal - mode->hsync_end) * mul / div; - hbp -= 14; + /* horizontal back porch */ + hbp = (mode->htotal - mode->hsync_end) * mul / div; + hbp -= 14; - /* horizontal front porch */ - hfp = (mode->hsync_start - mode->hdisplay) * mul / div; - hfp -= 8; + /* horizontal front porch */ + hfp = (mode->hsync_start - mode->hdisplay) * mul / div; + hfp -= 8; + + tegra_dsi_writel(dsi, hsw << 16 | 0, DSI_PKT_LEN_0_1); + tegra_dsi_writel(dsi, hact << 16 | hbp, DSI_PKT_LEN_2_3); + tegra_dsi_writel(dsi, hfp, DSI_PKT_LEN_4_5); + tegra_dsi_writel(dsi, 0x0f0f << 16, DSI_PKT_LEN_6_7); + + /* set SOL delay (for non-burst mode only) */ + tegra_dsi_writel(dsi, 8 * mul / div, DSI_SOL_DELAY); + + /* TODO: implement ganged mode */ + } else { + u16 bytes; + + if (dsi->master || dsi->slave) { + /* + * For ganged mode, assume symmetric left-right mode. + */ + bytes = 1 + (mode->hdisplay / 2) * mul / div; + } else { + /* 1 byte (DCS command) + pixel data */ + bytes = 1 + mode->hdisplay * mul / div; + } + + tegra_dsi_writel(dsi, 0, DSI_PKT_LEN_0_1); + tegra_dsi_writel(dsi, bytes << 16, DSI_PKT_LEN_2_3); + tegra_dsi_writel(dsi, bytes << 16, DSI_PKT_LEN_4_5); + tegra_dsi_writel(dsi, 0, DSI_PKT_LEN_6_7); + + value = MIPI_DCS_WRITE_MEMORY_START << 8 | + MIPI_DCS_WRITE_MEMORY_CONTINUE; + tegra_dsi_writel(dsi, value, DSI_DCS_CMDS); + + /* set SOL delay */ + if (dsi->master || dsi->slave) { + unsigned int lanes = tegra_dsi_get_lanes(dsi); + unsigned long delay, bclk, bclk_ganged; + + /* SOL to valid, valid to FIFO and FIFO write delay */ + delay = 4 + 4 + 2; + delay = DIV_ROUND_UP(delay * mul, div * lanes); + /* FIFO read delay */ + delay = delay + 6; + + bclk = DIV_ROUND_UP(mode->htotal * mul, div * lanes); + bclk_ganged = DIV_ROUND_UP(bclk * lanes / 2, lanes); + value = bclk - bclk_ganged + delay + 20; + } else { + /* TODO: revisit for non-ganged mode */ + value = 8 * mul / div; + } + + tegra_dsi_writel(dsi, value, DSI_SOL_DELAY); + } + + if (dsi->slave) { + err = tegra_dsi_configure(dsi->slave, pipe, mode); + if (err < 0) + return err; + + /* + * TODO: Support modes other than symmetrical left-right + * split. + */ + tegra_dsi_ganged_enable(dsi, 0, mode->hdisplay / 2); + tegra_dsi_ganged_enable(dsi->slave, mode->hdisplay / 2, + mode->hdisplay / 2); + } + + return 0; +} + +static int tegra_output_dsi_enable(struct tegra_output *output) +{ + struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); + const struct drm_display_mode *mode = &dc->base.mode; + struct tegra_dsi *dsi = to_dsi(output); + u32 value; + int err; - tegra_dsi_writel(dsi, hsw << 16 | 0, DSI_PKT_LEN_0_1); - tegra_dsi_writel(dsi, hact << 16 | hbp, DSI_PKT_LEN_2_3); - tegra_dsi_writel(dsi, hfp, DSI_PKT_LEN_4_5); - tegra_dsi_writel(dsi, 0x0f0f << 16, DSI_PKT_LEN_6_7); + if (dsi->enabled) + return 0; - /* set SOL delay */ - tegra_dsi_writel(dsi, 8 * mul / div, DSI_SOL_DELAY); + err = tegra_dsi_configure(dsi, dc->pipe, mode); + if (err < 0) + return err; /* enable display controller */ value = tegra_dc_readl(dc, DC_DISP_DISP_WIN_OPTIONS); @@ -531,28 +663,79 @@ static int tegra_output_dsi_enable(struct tegra_output *output) tegra_dc_writel(dc, GENERAL_ACT_REQ, DC_CMD_STATE_CONTROL); /* enable DSI controller */ - value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); - value |= DSI_POWER_CONTROL_ENABLE; - tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); + tegra_dsi_enable(dsi); dsi->enabled = true; return 0; } +static int tegra_dsi_wait_idle(struct tegra_dsi *dsi, unsigned long timeout) +{ + u32 value; + + timeout = jiffies + msecs_to_jiffies(timeout); + + while (time_before(jiffies, timeout)) { + value = tegra_dsi_readl(dsi, DSI_STATUS); + if (value & DSI_STATUS_IDLE) + return 0; + + usleep_range(1000, 2000); + } + + return -ETIMEDOUT; +} + +static void tegra_dsi_video_disable(struct tegra_dsi *dsi) +{ + u32 value; + + value = tegra_dsi_readl(dsi, DSI_CONTROL); + value &= ~DSI_CONTROL_VIDEO_ENABLE; + tegra_dsi_writel(dsi, value, DSI_CONTROL); + + if (dsi->slave) + tegra_dsi_video_disable(dsi->slave); +} + +static void tegra_dsi_ganged_disable(struct tegra_dsi *dsi) +{ + tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_START); + tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_SIZE); + tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_CONTROL); +} + +static void tegra_dsi_disable(struct tegra_dsi *dsi) +{ + u32 value; + + if (dsi->slave) { + tegra_dsi_ganged_disable(dsi->slave); + tegra_dsi_ganged_disable(dsi); + } + + value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); + value &= ~DSI_POWER_CONTROL_ENABLE; + tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); + + if (dsi->slave) + tegra_dsi_disable(dsi->slave); + + usleep_range(5000, 10000); +} + static int tegra_output_dsi_disable(struct tegra_output *output) { struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); struct tegra_dsi *dsi = to_dsi(output); unsigned long value; + int err; if (!dsi->enabled) return 0; - /* disable DSI controller */ - value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); - value &= ~DSI_POWER_CONTROL_ENABLE; - tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); + tegra_dsi_video_disable(dsi); /* * The following accesses registers of the display controller, so make @@ -576,39 +759,68 @@ static int tegra_output_dsi_disable(struct tegra_output *output) tegra_dc_writel(dc, GENERAL_ACT_REQ, DC_CMD_STATE_CONTROL); } - clk_disable(dsi->clk); + err = tegra_dsi_wait_idle(dsi, 100); + if (err < 0) + dev_dbg(dsi->dev, "failed to idle DSI: %d\n", err); + + tegra_dsi_disable(dsi); dsi->enabled = false; return 0; } +static void tegra_dsi_set_timeout(struct tegra_dsi *dsi, unsigned long bclk, + unsigned int vrefresh) +{ + unsigned int timeout; + u32 value; + + /* one frame high-speed transmission timeout */ + timeout = (bclk / vrefresh) / 512; + value = DSI_TIMEOUT_LRX(0x2000) | DSI_TIMEOUT_HTX(timeout); + tegra_dsi_writel(dsi, value, DSI_TIMEOUT_0); + + /* 2 ms peripheral timeout for panel */ + timeout = 2 * bclk / 512 * 1000; + value = DSI_TIMEOUT_PR(timeout) | DSI_TIMEOUT_TA(0x2000); + tegra_dsi_writel(dsi, value, DSI_TIMEOUT_1); + + value = DSI_TALLY_TA(0) | DSI_TALLY_LRX(0) | DSI_TALLY_HTX(0); + tegra_dsi_writel(dsi, value, DSI_TO_TALLY); + + if (dsi->slave) + tegra_dsi_set_timeout(dsi->slave, bclk, vrefresh); +} + static int tegra_output_dsi_setup_clock(struct tegra_output *output, struct clk *clk, unsigned long pclk, unsigned int *divp) { struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); struct drm_display_mode *mode = &dc->base.mode; - unsigned int timeout, mul, div, vrefresh; struct tegra_dsi *dsi = to_dsi(output); - unsigned long bclk, plld, value; + unsigned int mul, div, vrefresh, lanes; + unsigned long bclk, plld; int err; + lanes = tegra_dsi_get_lanes(dsi); + err = tegra_dsi_get_muldiv(dsi->format, &mul, &div); if (err < 0) return err; - DRM_DEBUG_KMS("mul: %u, div: %u, lanes: %u\n", mul, div, dsi->lanes); + DRM_DEBUG_KMS("mul: %u, div: %u, lanes: %u\n", mul, div, lanes); vrefresh = drm_mode_vrefresh(mode); DRM_DEBUG_KMS("vrefresh: %u\n", vrefresh); /* compute byte clock */ - bclk = (pclk * mul) / (div * dsi->lanes); + bclk = (pclk * mul) / (div * lanes); /* * Compute bit clock and round up to the next MHz. */ - plld = DIV_ROUND_UP(bclk * 8, 1000000) * 1000000; + plld = DIV_ROUND_UP(bclk * 8, USEC_PER_SEC) * USEC_PER_SEC; /* * We divide the frequency by two here, but we make up for that by @@ -640,25 +852,13 @@ static int tegra_output_dsi_setup_clock(struct tegra_output *output, * not working properly otherwise. Perhaps the PLLs cannot generate * frequencies sufficiently high. */ - *divp = ((8 * mul) / (div * dsi->lanes)) - 2; + *divp = ((8 * mul) / (div * lanes)) - 2; /* * XXX: Move the below somewhere else so that we don't need to have * access to the vrefresh in this function? */ - - /* one frame high-speed transmission timeout */ - timeout = (bclk / vrefresh) / 512; - value = DSI_TIMEOUT_LRX(0x2000) | DSI_TIMEOUT_HTX(timeout); - tegra_dsi_writel(dsi, value, DSI_TIMEOUT_0); - - /* 2 ms peripheral timeout for panel */ - timeout = 2 * bclk / 512 * 1000; - value = DSI_TIMEOUT_PR(timeout) | DSI_TIMEOUT_TA(0x2000); - tegra_dsi_writel(dsi, value, DSI_TIMEOUT_1); - - value = DSI_TALLY_TA(0) | DSI_TALLY_LRX(0) | DSI_TALLY_HTX(0); - tegra_dsi_writel(dsi, value, DSI_TO_TALLY); + tegra_dsi_set_timeout(dsi, bclk, vrefresh); return 0; } @@ -695,7 +895,7 @@ static int tegra_dsi_pad_enable(struct tegra_dsi *dsi) static int tegra_dsi_pad_calibrate(struct tegra_dsi *dsi) { - unsigned long value; + u32 value; tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_0); tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_1); @@ -720,14 +920,17 @@ static int tegra_dsi_init(struct host1x_client *client) struct tegra_dsi *dsi = host1x_client_to_dsi(client); int err; - dsi->output.type = TEGRA_OUTPUT_DSI; - dsi->output.dev = client->dev; - dsi->output.ops = &dsi_ops; - - err = tegra_output_init(drm, &dsi->output); - if (err < 0) { - dev_err(client->dev, "output setup failed: %d\n", err); - return err; + /* Gangsters must not register their own outputs. */ + if (!dsi->master) { + dsi->output.type = TEGRA_OUTPUT_DSI; + dsi->output.dev = client->dev; + dsi->output.ops = &dsi_ops; + + err = tegra_output_init(drm, &dsi->output); + if (err < 0) { + dev_err(client->dev, "output setup failed: %d\n", err); + return err; + } } if (IS_ENABLED(CONFIG_DEBUG_FS)) { @@ -736,12 +939,6 @@ static int tegra_dsi_init(struct host1x_client *client) dev_err(dsi->dev, "debugfs setup failed: %d\n", err); } - err = tegra_dsi_pad_calibrate(dsi); - if (err < 0) { - dev_err(dsi->dev, "MIPI calibration failed: %d\n", err); - return err; - } - return 0; } @@ -756,16 +953,20 @@ static int tegra_dsi_exit(struct host1x_client *client) dev_err(dsi->dev, "debugfs cleanup failed: %d\n", err); } - err = tegra_output_disable(&dsi->output); - if (err < 0) { - dev_err(client->dev, "output failed to disable: %d\n", err); - return err; - } - - err = tegra_output_exit(&dsi->output); - if (err < 0) { - dev_err(client->dev, "output cleanup failed: %d\n", err); - return err; + if (!dsi->master) { + err = tegra_output_disable(&dsi->output); + if (err < 0) { + dev_err(client->dev, "output failed to disable: %d\n", + err); + return err; + } + + err = tegra_output_exit(&dsi->output); + if (err < 0) { + dev_err(client->dev, "output cleanup failed: %d\n", + err); + return err; + } } return 0; @@ -792,20 +993,299 @@ static int tegra_dsi_setup_clocks(struct tegra_dsi *dsi) return 0; } +static const char * const error_report[16] = { + "SoT Error", + "SoT Sync Error", + "EoT Sync Error", + "Escape Mode Entry Command Error", + "Low-Power Transmit Sync Error", + "Peripheral Timeout Error", + "False Control Error", + "Contention Detected", + "ECC Error, single-bit", + "ECC Error, multi-bit", + "Checksum Error", + "DSI Data Type Not Recognized", + "DSI VC ID Invalid", + "Invalid Transmission Length", + "Reserved", + "DSI Protocol Violation", +}; + +static int tegra_dsi_read_response(struct tegra_dsi *dsi, + const struct mipi_dsi_msg *msg, + unsigned int count) +{ + u8 *rx = msg->rx_buf; + unsigned int i, j, k; + size_t size = 0; + u16 errors; + u32 value; + + /* read and parse packet header */ + value = tegra_dsi_readl(dsi, DSI_RD_DATA); + + switch (value & 0x3f) { + case MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT: + errors = (value >> 8) & 0xffff; + dev_dbg(dsi->dev, "Acknowledge and error report: %04x\n", + errors); + for (i = 0; i < ARRAY_SIZE(error_report); i++) + if (errors & BIT(i)) + dev_dbg(dsi->dev, " %2u: %s\n", i, + error_report[i]); + break; + + case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_1BYTE: + rx[0] = (value >> 8) & 0xff; + break; + + case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_2BYTE: + rx[0] = (value >> 8) & 0xff; + rx[1] = (value >> 16) & 0xff; + break; + + case MIPI_DSI_RX_DCS_LONG_READ_RESPONSE: + size = ((value >> 8) & 0xff00) | ((value >> 8) & 0xff); + break; + + case MIPI_DSI_RX_GENERIC_LONG_READ_RESPONSE: + size = ((value >> 8) & 0xff00) | ((value >> 8) & 0xff); + break; + + default: + dev_err(dsi->dev, "unhandled response type: %02x\n", + value & 0x3f); + break; + } + + size = min(size, msg->rx_len); + + if (msg->rx_buf && size > 0) { + for (i = 0, j = 0; i < count - 1; i++, j += 4) { + u8 *rx = msg->rx_buf + j; + + value = tegra_dsi_readl(dsi, DSI_RD_DATA); + + for (k = 0; k < 4 && (j + k) < msg->rx_len; k++) + rx[j + k] = (value >> (k << 3)) & 0xff; + } + } + + return 0; +} + +static int tegra_dsi_transmit(struct tegra_dsi *dsi, unsigned long timeout) +{ + tegra_dsi_writel(dsi, DSI_TRIGGER_HOST, DSI_TRIGGER); + + timeout = jiffies + msecs_to_jiffies(timeout); + + while (time_before(jiffies, timeout)) { + u32 value = tegra_dsi_readl(dsi, DSI_TRIGGER); + if ((value & DSI_TRIGGER_HOST) == 0) + return 0; + + usleep_range(1000, 2000); + } + + DRM_DEBUG_KMS("timeout waiting for transmission to complete\n"); + return -ETIMEDOUT; +} + +static int tegra_dsi_wait_for_response(struct tegra_dsi *dsi, + unsigned long timeout) +{ + timeout = jiffies + msecs_to_jiffies(250); + + while (time_before(jiffies, timeout)) { + u32 value = tegra_dsi_readl(dsi, DSI_STATUS); + u8 count = value & 0x1f; + + if (count > 0) + return count; + + usleep_range(1000, 2000); + } + + DRM_DEBUG_KMS("peripheral returned no data\n"); + return -ETIMEDOUT; +} + +static ssize_t tegra_dsi_host_transfer(struct mipi_dsi_host *host, + const struct mipi_dsi_msg *msg) +{ + struct tegra_dsi *dsi = host_to_tegra(host); + const u8 *tx = msg->tx_buf; + unsigned int count, i, j; + u32 value; + int err; + + /* maximum FIFO depth is 1920 words */ + if (msg->tx_len > dsi->video_fifo_depth * 4) + return -ENOSPC; + + /* reset underflow/overflow flags */ + value = tegra_dsi_readl(dsi, DSI_STATUS); + if (value & (DSI_STATUS_UNDERFLOW | DSI_STATUS_OVERFLOW)) { + value = DSI_HOST_CONTROL_FIFO_RESET; + tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); + usleep_range(10, 20); + } + + value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); + value |= DSI_POWER_CONTROL_ENABLE; + tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); + + usleep_range(5000, 10000); + + value = DSI_HOST_CONTROL_CRC_RESET | DSI_HOST_CONTROL_TX_TRIG_HOST | + DSI_HOST_CONTROL_CS | DSI_HOST_CONTROL_ECC; + + if ((msg->flags & MIPI_DSI_MSG_USE_LPM) == 0) + value |= DSI_HOST_CONTROL_HS; + + /* + * The host FIFO has a maximum of 64 words, so larger transmissions + * need to use the video FIFO. + */ + if (msg->tx_len > dsi->host_fifo_depth * 4) + value |= DSI_HOST_CONTROL_FIFO_SEL; + + tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); + + /* + * For reads and messages with explicitly requested ACK, generate a + * BTA sequence after the transmission of the packet. + */ + if ((msg->flags & MIPI_DSI_MSG_REQ_ACK) || + (msg->rx_buf && msg->rx_len > 0)) { + value = tegra_dsi_readl(dsi, DSI_HOST_CONTROL); + value |= DSI_HOST_CONTROL_PKT_BTA; + tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); + } + + value = DSI_CONTROL_LANES(0) | DSI_CONTROL_HOST_ENABLE; + tegra_dsi_writel(dsi, value, DSI_CONTROL); + + /* write packet header */ + value = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f); + + if (tx && msg->tx_len > 0) + value |= tx[0] << 8; + + if (tx && msg->tx_len > 1) + value |= tx[1] << 16; + + tegra_dsi_writel(dsi, value, DSI_WR_DATA); + + /* write payload (if any) */ + if (msg->tx_len > 2) { + for (j = 2; j < msg->tx_len; j += 4) { + value = 0; + + for (i = 0; i < 4 && j + i < msg->tx_len; i++) + value |= tx[j + i] << (i << 3); + + tegra_dsi_writel(dsi, value, DSI_WR_DATA); + } + } + + err = tegra_dsi_transmit(dsi, 250); + if (err < 0) + return err; + + if ((msg->flags & MIPI_DSI_MSG_REQ_ACK) || + (msg->rx_buf && msg->rx_len > 0)) { + err = tegra_dsi_wait_for_response(dsi, 250); + if (err < 0) + return err; + + count = err; + + value = tegra_dsi_readl(dsi, DSI_RD_DATA); + switch (value) { + case 0x84: + /* + dev_dbg(dsi->dev, "ACK\n"); + */ + break; + + case 0x87: + /* + dev_dbg(dsi->dev, "ESCAPE\n"); + */ + break; + + default: + dev_err(dsi->dev, "unknown status: %08x\n", value); + break; + } + + if (count > 1) { + err = tegra_dsi_read_response(dsi, msg, count); + if (err < 0) + dev_err(dsi->dev, + "failed to parse response: %d\n", + err); + } + } + + return 0; +} + +static int tegra_dsi_ganged_setup(struct tegra_dsi *dsi) +{ + struct clk *parent; + int err; + + /* make sure both DSI controllers share the same PLL */ + parent = clk_get_parent(dsi->slave->clk); + if (!parent) + return -EINVAL; + + err = clk_set_parent(parent, dsi->clk_parent); + if (err < 0) + return err; + + return 0; +} + static int tegra_dsi_host_attach(struct mipi_dsi_host *host, struct mipi_dsi_device *device) { struct tegra_dsi *dsi = host_to_tegra(host); - struct tegra_output *output = &dsi->output; dsi->flags = device->mode_flags; dsi->format = device->format; dsi->lanes = device->lanes; - output->panel = of_drm_find_panel(device->dev.of_node); - if (output->panel) { - if (output->connector.dev) + if (dsi->slave) { + int err; + + dev_dbg(dsi->dev, "attaching dual-channel device %s\n", + dev_name(&device->dev)); + + err = tegra_dsi_ganged_setup(dsi); + if (err < 0) { + dev_err(dsi->dev, "failed to set up ganged mode: %d\n", + err); + return err; + } + } + + /* + * Slaves don't have a panel associated with them, so they provide + * merely the second channel. + */ + if (!dsi->master) { + struct tegra_output *output = &dsi->output; + + output->panel = of_drm_find_panel(device->dev.of_node); + if (output->panel && output->connector.dev) { + drm_panel_attach(output->panel, &output->connector); drm_helper_hpd_irq_event(output->connector.dev); + } } return 0; @@ -818,10 +1298,10 @@ static int tegra_dsi_host_detach(struct mipi_dsi_host *host, struct tegra_output *output = &dsi->output; if (output->panel && &device->dev == output->panel->dev) { + output->panel = NULL; + if (output->connector.dev) drm_helper_hpd_irq_event(output->connector.dev); - - output->panel = NULL; } return 0; @@ -830,8 +1310,29 @@ static int tegra_dsi_host_detach(struct mipi_dsi_host *host, static const struct mipi_dsi_host_ops tegra_dsi_host_ops = { .attach = tegra_dsi_host_attach, .detach = tegra_dsi_host_detach, + .transfer = tegra_dsi_host_transfer, }; +static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi) +{ + struct device_node *np; + + np = of_parse_phandle(dsi->dev->of_node, "nvidia,ganged-mode", 0); + if (np) { + struct platform_device *gangster = of_find_device_by_node(np); + + dsi->slave = platform_get_drvdata(gangster); + of_node_put(np); + + if (!dsi->slave) + return -EPROBE_DEFER; + + dsi->slave->master = dsi; + } + + return 0; +} + static int tegra_dsi_probe(struct platform_device *pdev) { struct tegra_dsi *dsi; @@ -846,10 +1347,16 @@ static int tegra_dsi_probe(struct platform_device *pdev) dsi->video_fifo_depth = 1920; dsi->host_fifo_depth = 64; + err = tegra_dsi_ganged_probe(dsi); + if (err < 0) + return err; + err = tegra_output_probe(&dsi->output); if (err < 0) return err; + dsi->output.connector.polled = DRM_CONNECTOR_POLL_HPD; + /* * Assume these values by default. When a DSI peripheral driver * attaches to the DSI host, the parameters will be taken from @@ -863,68 +1370,83 @@ static int tegra_dsi_probe(struct platform_device *pdev) if (IS_ERR(dsi->rst)) return PTR_ERR(dsi->rst); + err = reset_control_deassert(dsi->rst); + if (err < 0) { + dev_err(&pdev->dev, "failed to bring DSI out of reset: %d\n", + err); + return err; + } + dsi->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(dsi->clk)) { dev_err(&pdev->dev, "cannot get DSI clock\n"); - return PTR_ERR(dsi->clk); + err = PTR_ERR(dsi->clk); + goto reset; } err = clk_prepare_enable(dsi->clk); if (err < 0) { dev_err(&pdev->dev, "cannot enable DSI clock\n"); - return err; + goto reset; } dsi->clk_lp = devm_clk_get(&pdev->dev, "lp"); if (IS_ERR(dsi->clk_lp)) { dev_err(&pdev->dev, "cannot get low-power clock\n"); - return PTR_ERR(dsi->clk_lp); + err = PTR_ERR(dsi->clk_lp); + goto disable_clk; } err = clk_prepare_enable(dsi->clk_lp); if (err < 0) { dev_err(&pdev->dev, "cannot enable low-power clock\n"); - return err; + goto disable_clk; } dsi->clk_parent = devm_clk_get(&pdev->dev, "parent"); if (IS_ERR(dsi->clk_parent)) { dev_err(&pdev->dev, "cannot get parent clock\n"); - return PTR_ERR(dsi->clk_parent); - } - - err = clk_prepare_enable(dsi->clk_parent); - if (err < 0) { - dev_err(&pdev->dev, "cannot enable parent clock\n"); - return err; + err = PTR_ERR(dsi->clk_parent); + goto disable_clk_lp; } dsi->vdd = devm_regulator_get(&pdev->dev, "avdd-dsi-csi"); if (IS_ERR(dsi->vdd)) { dev_err(&pdev->dev, "cannot get VDD supply\n"); - return PTR_ERR(dsi->vdd); + err = PTR_ERR(dsi->vdd); + goto disable_clk_lp; } err = regulator_enable(dsi->vdd); if (err < 0) { dev_err(&pdev->dev, "cannot enable VDD supply\n"); - return err; + goto disable_clk_lp; } err = tegra_dsi_setup_clocks(dsi); if (err < 0) { dev_err(&pdev->dev, "cannot setup clocks\n"); - return err; + goto disable_vdd; } regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); dsi->regs = devm_ioremap_resource(&pdev->dev, regs); - if (IS_ERR(dsi->regs)) - return PTR_ERR(dsi->regs); + if (IS_ERR(dsi->regs)) { + err = PTR_ERR(dsi->regs); + goto disable_vdd; + } dsi->mipi = tegra_mipi_request(&pdev->dev); - if (IS_ERR(dsi->mipi)) - return PTR_ERR(dsi->mipi); + if (IS_ERR(dsi->mipi)) { + err = PTR_ERR(dsi->mipi); + goto disable_vdd; + } + + err = tegra_dsi_pad_calibrate(dsi); + if (err < 0) { + dev_err(dsi->dev, "MIPI calibration failed: %d\n", err); + goto mipi_free; + } dsi->host.ops = &tegra_dsi_host_ops; dsi->host.dev = &pdev->dev; @@ -932,7 +1454,7 @@ static int tegra_dsi_probe(struct platform_device *pdev) err = mipi_dsi_host_register(&dsi->host); if (err < 0) { dev_err(&pdev->dev, "failed to register DSI host: %d\n", err); - return err; + goto mipi_free; } INIT_LIST_HEAD(&dsi->client.list); @@ -943,12 +1465,26 @@ static int tegra_dsi_probe(struct platform_device *pdev) if (err < 0) { dev_err(&pdev->dev, "failed to register host1x client: %d\n", err); - return err; + goto unregister; } platform_set_drvdata(pdev, dsi); return 0; + +unregister: + mipi_dsi_host_unregister(&dsi->host); +mipi_free: + tegra_mipi_free(dsi->mipi); +disable_vdd: + regulator_disable(dsi->vdd); +disable_clk_lp: + clk_disable_unprepare(dsi->clk_lp); +disable_clk: + clk_disable_unprepare(dsi->clk); +reset: + reset_control_assert(dsi->rst); + return err; } static int tegra_dsi_remove(struct platform_device *pdev) @@ -967,7 +1503,6 @@ static int tegra_dsi_remove(struct platform_device *pdev) tegra_mipi_free(dsi->mipi); regulator_disable(dsi->vdd); - clk_disable_unprepare(dsi->clk_parent); clk_disable_unprepare(dsi->clk_lp); clk_disable_unprepare(dsi->clk); reset_control_assert(dsi->rst); diff --git a/drivers/gpu/drm/tegra/dsi.h b/drivers/gpu/drm/tegra/dsi.h index 5ce610d08d77..bad1006a5150 100644 --- a/drivers/gpu/drm/tegra/dsi.h +++ b/drivers/gpu/drm/tegra/dsi.h @@ -21,9 +21,16 @@ #define DSI_INT_STATUS 0x0d #define DSI_INT_MASK 0x0e #define DSI_HOST_CONTROL 0x0f +#define DSI_HOST_CONTROL_FIFO_RESET (1 << 21) +#define DSI_HOST_CONTROL_CRC_RESET (1 << 20) +#define DSI_HOST_CONTROL_TX_TRIG_SOL (0 << 12) +#define DSI_HOST_CONTROL_TX_TRIG_FIFO (1 << 12) +#define DSI_HOST_CONTROL_TX_TRIG_HOST (2 << 12) #define DSI_HOST_CONTROL_RAW (1 << 6) #define DSI_HOST_CONTROL_HS (1 << 5) -#define DSI_HOST_CONTROL_BTA (1 << 2) +#define DSI_HOST_CONTROL_FIFO_SEL (1 << 4) +#define DSI_HOST_CONTROL_IMM_BTA (1 << 3) +#define DSI_HOST_CONTROL_PKT_BTA (1 << 2) #define DSI_HOST_CONTROL_CS (1 << 1) #define DSI_HOST_CONTROL_ECC (1 << 0) #define DSI_CONTROL 0x10 @@ -39,9 +46,13 @@ #define DSI_SOL_DELAY 0x11 #define DSI_MAX_THRESHOLD 0x12 #define DSI_TRIGGER 0x13 +#define DSI_TRIGGER_HOST (1 << 1) +#define DSI_TRIGGER_VIDEO (1 << 0) #define DSI_TX_CRC 0x14 #define DSI_STATUS 0x15 #define DSI_STATUS_IDLE (1 << 10) +#define DSI_STATUS_UNDERFLOW (1 << 9) +#define DSI_STATUS_OVERFLOW (1 << 8) #define DSI_INIT_SEQ_CONTROL 0x1a #define DSI_INIT_SEQ_DATA_0 0x1b #define DSI_INIT_SEQ_DATA_1 0x1c @@ -104,6 +115,7 @@ #define DSI_PAD_CONTROL_3 0x51 #define DSI_PAD_CONTROL_4 0x52 #define DSI_GANGED_MODE_CONTROL 0x53 +#define DSI_GANGED_MODE_CONTROL_ENABLE (1 << 0) #define DSI_GANGED_MODE_START 0x54 #define DSI_GANGED_MODE_SIZE 0x55 #define DSI_RAW_DATA_BYTE_COUNT 0x56 -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1413195715-4719-13-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 13/14] drm/tegra: dsi: Add ganged mode support [not found] ` <1413195715-4719-13-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-10-14 14:51 ` Sean Paul 0 siblings, 0 replies; 15+ messages in thread From: Sean Paul @ 2014-10-14 14:51 UTC (permalink / raw) To: Thierry Reding Cc: dri-devel, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Mon, Oct 13, 2014 at 6:21 AM, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > Implement ganged mode support for the Tegra DSI driver. The DSI host > controller to gang up with is specified via a phandle in the device tree > and the resolved DSI host controller used for the programming of the > ganged-mode registers. > > Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > --- > .../bindings/gpu/nvidia,tegra20-host1x.txt | 2 + > drivers/gpu/drm/tegra/dsi.c | 767 +++++++++++++++++---- > drivers/gpu/drm/tegra/dsi.h | 14 +- > 3 files changed, 666 insertions(+), 117 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt > index b48f4ef31d93..4c32ef0b7db8 100644 > --- a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt > +++ b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt > @@ -191,6 +191,8 @@ of the following host1x client modules: > - nvidia,hpd-gpio: specifies a GPIO used for hotplug detection > - nvidia,edid: supplies a binary EDID blob > - nvidia,panel: phandle of a display panel > + - nvidia,ganged-mode: contains a phandle to a second DSI controller to gang > + up with in order to support up to 8 data lanes > > - sor: serial output resource > > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c > index 584b771d8b2f..b7b205496e8c 100644 > --- a/drivers/gpu/drm/tegra/dsi.c > +++ b/drivers/gpu/drm/tegra/dsi.c > @@ -11,6 +11,7 @@ > #include <linux/host1x.h> > #include <linux/module.h> > #include <linux/of.h> > +#include <linux/of_platform.h> > #include <linux/platform_device.h> > #include <linux/reset.h> > > @@ -54,6 +55,10 @@ struct tegra_dsi { > > unsigned int video_fifo_depth; > unsigned int host_fifo_depth; > + > + /* for ganged-mode support */ > + struct tegra_dsi *master; > + struct tegra_dsi *slave; > }; > > static inline struct tegra_dsi * > @@ -318,6 +323,21 @@ static const u32 pkt_seq_video_non_burst_sync_events[NUM_PKT_SEQ] = { > [11] = PKT_ID0(MIPI_DSI_BLANKING_PACKET) | PKT_LEN0(4), > }; > > +static const u32 pkt_seq_command_mode[NUM_PKT_SEQ] = { > + [ 0] = 0, > + [ 1] = 0, > + [ 2] = 0, > + [ 3] = 0, > + [ 4] = 0, > + [ 5] = 0, > + [ 6] = PKT_ID0(MIPI_DSI_DCS_LONG_WRITE) | PKT_LEN0(3) | PKT_LP, > + [ 7] = 0, > + [ 8] = 0, > + [ 9] = 0, > + [10] = PKT_ID0(MIPI_DSI_DCS_LONG_WRITE) | PKT_LEN0(5) | PKT_LP, > + [11] = 0, > +}; > + > static int tegra_dsi_set_phy_timing(struct tegra_dsi *dsi) > { > struct mipi_dphy_timing timing; > @@ -329,7 +349,7 @@ static int tegra_dsi_set_phy_timing(struct tegra_dsi *dsi) > if (rate < 0) > return rate; > > - period = DIV_ROUND_CLOSEST(1000000000UL, rate * 2); > + period = DIV_ROUND_CLOSEST(NSEC_PER_SEC, rate * 2); > > err = mipi_dphy_timing_get_default(&timing, period); > if (err < 0) > @@ -426,26 +446,59 @@ static int tegra_dsi_get_format(enum mipi_dsi_pixel_format format, > return 0; > } > > -static int tegra_output_dsi_enable(struct tegra_output *output) > +static void tegra_dsi_ganged_enable(struct tegra_dsi *dsi, unsigned int start, > + unsigned int size) > +{ > + u32 value; > + > + tegra_dsi_writel(dsi, start, DSI_GANGED_MODE_START); > + tegra_dsi_writel(dsi, size << 16 | size, DSI_GANGED_MODE_SIZE); > + > + value = DSI_GANGED_MODE_CONTROL_ENABLE; > + tegra_dsi_writel(dsi, value, DSI_GANGED_MODE_CONTROL); > +} > + > +static void tegra_dsi_enable(struct tegra_dsi *dsi) > +{ > + u32 value; > + > + value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); > + value |= DSI_POWER_CONTROL_ENABLE; > + tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); > + > + if (dsi->slave) > + tegra_dsi_enable(dsi->slave); > +} > + > +static unsigned int tegra_dsi_get_lanes(struct tegra_dsi *dsi) > +{ > + if (dsi->master) > + return dsi->master->lanes + dsi->lanes; > + > + if (dsi->slave) > + return dsi->lanes + dsi->slave->lanes; > + > + return dsi->lanes; > +} > + > +static int tegra_dsi_configure(struct tegra_dsi *dsi, unsigned int pipe, > + const struct drm_display_mode *mode) > { > - struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); > - struct drm_display_mode *mode = &dc->base.mode; > unsigned int hact, hsw, hbp, hfp, i, mul, div; > - struct tegra_dsi *dsi = to_dsi(output); > enum tegra_dsi_format format; > - unsigned long value; > const u32 *pkt_seq; > + u32 value; > int err; > > - if (dsi->enabled) > - return 0; > - > if (dsi->flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) { > DRM_DEBUG_KMS("Non-burst video mode with sync pulses\n"); > pkt_seq = pkt_seq_video_non_burst_sync_pulses; > - } else { > + } else if (dsi->flags & MIPI_DSI_MODE_VIDEO) { > DRM_DEBUG_KMS("Non-burst video mode with sync events\n"); > pkt_seq = pkt_seq_video_non_burst_sync_events; > + } else { > + DRM_DEBUG_KMS("Command mode\n"); > + pkt_seq = pkt_seq_command_mode; > } > > err = tegra_dsi_get_muldiv(dsi->format, &mul, &div); > @@ -456,28 +509,29 @@ static int tegra_output_dsi_enable(struct tegra_output *output) > if (err < 0) > return err; > > - err = clk_enable(dsi->clk); > - if (err < 0) > - return err; > - > - reset_control_deassert(dsi->rst); > - > value = DSI_CONTROL_CHANNEL(0) | DSI_CONTROL_FORMAT(format) | > DSI_CONTROL_LANES(dsi->lanes - 1) | > - DSI_CONTROL_SOURCE(dc->pipe); > + DSI_CONTROL_SOURCE(pipe); > tegra_dsi_writel(dsi, value, DSI_CONTROL); > > tegra_dsi_writel(dsi, dsi->video_fifo_depth, DSI_MAX_THRESHOLD); > > - value = DSI_HOST_CONTROL_HS | DSI_HOST_CONTROL_CS | > - DSI_HOST_CONTROL_ECC; > + value = DSI_HOST_CONTROL_HS; > tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); > > value = tegra_dsi_readl(dsi, DSI_CONTROL); > + > if (dsi->flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) > value |= DSI_CONTROL_HS_CLK_CTRL; > + > value &= ~DSI_CONTROL_TX_TRIG(3); > - value &= ~DSI_CONTROL_DCS_ENABLE; > + > + /* enable DCS commands for command mode */ > + if (dsi->flags & MIPI_DSI_MODE_VIDEO) > + value &= ~DSI_CONTROL_DCS_ENABLE; > + else > + value |= DSI_CONTROL_DCS_ENABLE; > + > value |= DSI_CONTROL_VIDEO_ENABLE; > value &= ~DSI_CONTROL_HOST_ENABLE; > tegra_dsi_writel(dsi, value, DSI_CONTROL); > @@ -489,28 +543,106 @@ static int tegra_output_dsi_enable(struct tegra_output *output) > for (i = 0; i < NUM_PKT_SEQ; i++) > tegra_dsi_writel(dsi, pkt_seq[i], DSI_PKT_SEQ_0_LO + i); > > - /* horizontal active pixels */ > - hact = mode->hdisplay * mul / div; > + if (dsi->flags & MIPI_DSI_MODE_VIDEO) { > + /* horizontal active pixels */ > + hact = mode->hdisplay * mul / div; > > - /* horizontal sync width */ > - hsw = (mode->hsync_end - mode->hsync_start) * mul / div; > - hsw -= 10; > + /* horizontal sync width */ > + hsw = (mode->hsync_end - mode->hsync_start) * mul / div; > + hsw -= 10; > > - /* horizontal back porch */ > - hbp = (mode->htotal - mode->hsync_end) * mul / div; > - hbp -= 14; > + /* horizontal back porch */ > + hbp = (mode->htotal - mode->hsync_end) * mul / div; > + hbp -= 14; > > - /* horizontal front porch */ > - hfp = (mode->hsync_start - mode->hdisplay) * mul / div; > - hfp -= 8; > + /* horizontal front porch */ > + hfp = (mode->hsync_start - mode->hdisplay) * mul / div; > + hfp -= 8; > + > + tegra_dsi_writel(dsi, hsw << 16 | 0, DSI_PKT_LEN_0_1); > + tegra_dsi_writel(dsi, hact << 16 | hbp, DSI_PKT_LEN_2_3); > + tegra_dsi_writel(dsi, hfp, DSI_PKT_LEN_4_5); > + tegra_dsi_writel(dsi, 0x0f0f << 16, DSI_PKT_LEN_6_7); > + > + /* set SOL delay (for non-burst mode only) */ > + tegra_dsi_writel(dsi, 8 * mul / div, DSI_SOL_DELAY); > + > + /* TODO: implement ganged mode */ > + } else { > + u16 bytes; > + > + if (dsi->master || dsi->slave) { > + /* > + * For ganged mode, assume symmetric left-right mode. > + */ > + bytes = 1 + (mode->hdisplay / 2) * mul / div; > + } else { > + /* 1 byte (DCS command) + pixel data */ > + bytes = 1 + mode->hdisplay * mul / div; > + } > + > + tegra_dsi_writel(dsi, 0, DSI_PKT_LEN_0_1); > + tegra_dsi_writel(dsi, bytes << 16, DSI_PKT_LEN_2_3); > + tegra_dsi_writel(dsi, bytes << 16, DSI_PKT_LEN_4_5); > + tegra_dsi_writel(dsi, 0, DSI_PKT_LEN_6_7); > + > + value = MIPI_DCS_WRITE_MEMORY_START << 8 | > + MIPI_DCS_WRITE_MEMORY_CONTINUE; > + tegra_dsi_writel(dsi, value, DSI_DCS_CMDS); > + > + /* set SOL delay */ > + if (dsi->master || dsi->slave) { > + unsigned int lanes = tegra_dsi_get_lanes(dsi); > + unsigned long delay, bclk, bclk_ganged; > + > + /* SOL to valid, valid to FIFO and FIFO write delay */ > + delay = 4 + 4 + 2; > + delay = DIV_ROUND_UP(delay * mul, div * lanes); > + /* FIFO read delay */ > + delay = delay + 6; > + > + bclk = DIV_ROUND_UP(mode->htotal * mul, div * lanes); > + bclk_ganged = DIV_ROUND_UP(bclk * lanes / 2, lanes); > + value = bclk - bclk_ganged + delay + 20; > + } else { > + /* TODO: revisit for non-ganged mode */ > + value = 8 * mul / div; > + } > + > + tegra_dsi_writel(dsi, value, DSI_SOL_DELAY); > + } > + > + if (dsi->slave) { > + err = tegra_dsi_configure(dsi->slave, pipe, mode); > + if (err < 0) > + return err; > + > + /* > + * TODO: Support modes other than symmetrical left-right > + * split. > + */ > + tegra_dsi_ganged_enable(dsi, 0, mode->hdisplay / 2); > + tegra_dsi_ganged_enable(dsi->slave, mode->hdisplay / 2, > + mode->hdisplay / 2); > + } > + > + return 0; > +} > + > +static int tegra_output_dsi_enable(struct tegra_output *output) > +{ > + struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); > + const struct drm_display_mode *mode = &dc->base.mode; > + struct tegra_dsi *dsi = to_dsi(output); > + u32 value; > + int err; > > - tegra_dsi_writel(dsi, hsw << 16 | 0, DSI_PKT_LEN_0_1); > - tegra_dsi_writel(dsi, hact << 16 | hbp, DSI_PKT_LEN_2_3); > - tegra_dsi_writel(dsi, hfp, DSI_PKT_LEN_4_5); > - tegra_dsi_writel(dsi, 0x0f0f << 16, DSI_PKT_LEN_6_7); > + if (dsi->enabled) > + return 0; > > - /* set SOL delay */ > - tegra_dsi_writel(dsi, 8 * mul / div, DSI_SOL_DELAY); > + err = tegra_dsi_configure(dsi, dc->pipe, mode); > + if (err < 0) > + return err; > > /* enable display controller */ > value = tegra_dc_readl(dc, DC_DISP_DISP_WIN_OPTIONS); > @@ -531,28 +663,79 @@ static int tegra_output_dsi_enable(struct tegra_output *output) > tegra_dc_writel(dc, GENERAL_ACT_REQ, DC_CMD_STATE_CONTROL); > > /* enable DSI controller */ > - value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); > - value |= DSI_POWER_CONTROL_ENABLE; > - tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); > + tegra_dsi_enable(dsi); > > dsi->enabled = true; > > return 0; > } > > +static int tegra_dsi_wait_idle(struct tegra_dsi *dsi, unsigned long timeout) > +{ > + u32 value; > + > + timeout = jiffies + msecs_to_jiffies(timeout); > + > + while (time_before(jiffies, timeout)) { > + value = tegra_dsi_readl(dsi, DSI_STATUS); > + if (value & DSI_STATUS_IDLE) > + return 0; > + > + usleep_range(1000, 2000); > + } > + > + return -ETIMEDOUT; > +} > + > +static void tegra_dsi_video_disable(struct tegra_dsi *dsi) > +{ > + u32 value; > + > + value = tegra_dsi_readl(dsi, DSI_CONTROL); > + value &= ~DSI_CONTROL_VIDEO_ENABLE; > + tegra_dsi_writel(dsi, value, DSI_CONTROL); > + > + if (dsi->slave) > + tegra_dsi_video_disable(dsi->slave); > +} > + > +static void tegra_dsi_ganged_disable(struct tegra_dsi *dsi) > +{ > + tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_START); > + tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_SIZE); > + tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_CONTROL); > +} > + > +static void tegra_dsi_disable(struct tegra_dsi *dsi) > +{ > + u32 value; > + > + if (dsi->slave) { > + tegra_dsi_ganged_disable(dsi->slave); > + tegra_dsi_ganged_disable(dsi); > + } > + > + value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); > + value &= ~DSI_POWER_CONTROL_ENABLE; > + tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); > + > + if (dsi->slave) > + tegra_dsi_disable(dsi->slave); > + > + usleep_range(5000, 10000); > +} > + > static int tegra_output_dsi_disable(struct tegra_output *output) > { > struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); > struct tegra_dsi *dsi = to_dsi(output); > unsigned long value; > + int err; > > if (!dsi->enabled) > return 0; > > - /* disable DSI controller */ > - value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); > - value &= ~DSI_POWER_CONTROL_ENABLE; > - tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); > + tegra_dsi_video_disable(dsi); > > /* > * The following accesses registers of the display controller, so make > @@ -576,39 +759,68 @@ static int tegra_output_dsi_disable(struct tegra_output *output) > tegra_dc_writel(dc, GENERAL_ACT_REQ, DC_CMD_STATE_CONTROL); > } > > - clk_disable(dsi->clk); > + err = tegra_dsi_wait_idle(dsi, 100); > + if (err < 0) > + dev_dbg(dsi->dev, "failed to idle DSI: %d\n", err); > + > + tegra_dsi_disable(dsi); > > dsi->enabled = false; > > return 0; > } > > +static void tegra_dsi_set_timeout(struct tegra_dsi *dsi, unsigned long bclk, > + unsigned int vrefresh) > +{ > + unsigned int timeout; > + u32 value; > + > + /* one frame high-speed transmission timeout */ > + timeout = (bclk / vrefresh) / 512; > + value = DSI_TIMEOUT_LRX(0x2000) | DSI_TIMEOUT_HTX(timeout); > + tegra_dsi_writel(dsi, value, DSI_TIMEOUT_0); > + > + /* 2 ms peripheral timeout for panel */ > + timeout = 2 * bclk / 512 * 1000; > + value = DSI_TIMEOUT_PR(timeout) | DSI_TIMEOUT_TA(0x2000); > + tegra_dsi_writel(dsi, value, DSI_TIMEOUT_1); > + > + value = DSI_TALLY_TA(0) | DSI_TALLY_LRX(0) | DSI_TALLY_HTX(0); > + tegra_dsi_writel(dsi, value, DSI_TO_TALLY); > + > + if (dsi->slave) > + tegra_dsi_set_timeout(dsi->slave, bclk, vrefresh); > +} > + > static int tegra_output_dsi_setup_clock(struct tegra_output *output, > struct clk *clk, unsigned long pclk, > unsigned int *divp) > { > struct tegra_dc *dc = to_tegra_dc(output->encoder.crtc); > struct drm_display_mode *mode = &dc->base.mode; > - unsigned int timeout, mul, div, vrefresh; > struct tegra_dsi *dsi = to_dsi(output); > - unsigned long bclk, plld, value; > + unsigned int mul, div, vrefresh, lanes; > + unsigned long bclk, plld; > int err; > > + lanes = tegra_dsi_get_lanes(dsi); > + > err = tegra_dsi_get_muldiv(dsi->format, &mul, &div); > if (err < 0) > return err; > > - DRM_DEBUG_KMS("mul: %u, div: %u, lanes: %u\n", mul, div, dsi->lanes); > + DRM_DEBUG_KMS("mul: %u, div: %u, lanes: %u\n", mul, div, lanes); > vrefresh = drm_mode_vrefresh(mode); > DRM_DEBUG_KMS("vrefresh: %u\n", vrefresh); > > /* compute byte clock */ > - bclk = (pclk * mul) / (div * dsi->lanes); > + bclk = (pclk * mul) / (div * lanes); > > /* > * Compute bit clock and round up to the next MHz. > */ > - plld = DIV_ROUND_UP(bclk * 8, 1000000) * 1000000; > + plld = DIV_ROUND_UP(bclk * 8, USEC_PER_SEC) * USEC_PER_SEC; > > /* > * We divide the frequency by two here, but we make up for that by > @@ -640,25 +852,13 @@ static int tegra_output_dsi_setup_clock(struct tegra_output *output, > * not working properly otherwise. Perhaps the PLLs cannot generate > * frequencies sufficiently high. > */ > - *divp = ((8 * mul) / (div * dsi->lanes)) - 2; > + *divp = ((8 * mul) / (div * lanes)) - 2; > > /* > * XXX: Move the below somewhere else so that we don't need to have > * access to the vrefresh in this function? > */ > - > - /* one frame high-speed transmission timeout */ > - timeout = (bclk / vrefresh) / 512; > - value = DSI_TIMEOUT_LRX(0x2000) | DSI_TIMEOUT_HTX(timeout); > - tegra_dsi_writel(dsi, value, DSI_TIMEOUT_0); > - > - /* 2 ms peripheral timeout for panel */ > - timeout = 2 * bclk / 512 * 1000; > - value = DSI_TIMEOUT_PR(timeout) | DSI_TIMEOUT_TA(0x2000); > - tegra_dsi_writel(dsi, value, DSI_TIMEOUT_1); > - > - value = DSI_TALLY_TA(0) | DSI_TALLY_LRX(0) | DSI_TALLY_HTX(0); > - tegra_dsi_writel(dsi, value, DSI_TO_TALLY); > + tegra_dsi_set_timeout(dsi, bclk, vrefresh); > > return 0; > } > @@ -695,7 +895,7 @@ static int tegra_dsi_pad_enable(struct tegra_dsi *dsi) > > static int tegra_dsi_pad_calibrate(struct tegra_dsi *dsi) > { > - unsigned long value; > + u32 value; > > tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_0); > tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_1); > @@ -720,14 +920,17 @@ static int tegra_dsi_init(struct host1x_client *client) > struct tegra_dsi *dsi = host1x_client_to_dsi(client); > int err; > > - dsi->output.type = TEGRA_OUTPUT_DSI; > - dsi->output.dev = client->dev; > - dsi->output.ops = &dsi_ops; > - > - err = tegra_output_init(drm, &dsi->output); > - if (err < 0) { > - dev_err(client->dev, "output setup failed: %d\n", err); > - return err; > + /* Gangsters must not register their own outputs. */ > + if (!dsi->master) { > + dsi->output.type = TEGRA_OUTPUT_DSI; > + dsi->output.dev = client->dev; > + dsi->output.ops = &dsi_ops; > + > + err = tegra_output_init(drm, &dsi->output); > + if (err < 0) { > + dev_err(client->dev, "output setup failed: %d\n", err); > + return err; > + } > } > > if (IS_ENABLED(CONFIG_DEBUG_FS)) { > @@ -736,12 +939,6 @@ static int tegra_dsi_init(struct host1x_client *client) > dev_err(dsi->dev, "debugfs setup failed: %d\n", err); > } > > - err = tegra_dsi_pad_calibrate(dsi); > - if (err < 0) { > - dev_err(dsi->dev, "MIPI calibration failed: %d\n", err); > - return err; > - } > - > return 0; > } > > @@ -756,16 +953,20 @@ static int tegra_dsi_exit(struct host1x_client *client) > dev_err(dsi->dev, "debugfs cleanup failed: %d\n", err); > } > > - err = tegra_output_disable(&dsi->output); > - if (err < 0) { > - dev_err(client->dev, "output failed to disable: %d\n", err); > - return err; > - } > - > - err = tegra_output_exit(&dsi->output); > - if (err < 0) { > - dev_err(client->dev, "output cleanup failed: %d\n", err); > - return err; > + if (!dsi->master) { > + err = tegra_output_disable(&dsi->output); > + if (err < 0) { > + dev_err(client->dev, "output failed to disable: %d\n", > + err); > + return err; > + } > + > + err = tegra_output_exit(&dsi->output); > + if (err < 0) { > + dev_err(client->dev, "output cleanup failed: %d\n", > + err); > + return err; > + } > } > > return 0; > @@ -792,20 +993,299 @@ static int tegra_dsi_setup_clocks(struct tegra_dsi *dsi) > return 0; > } > > +static const char * const error_report[16] = { > + "SoT Error", > + "SoT Sync Error", > + "EoT Sync Error", > + "Escape Mode Entry Command Error", > + "Low-Power Transmit Sync Error", > + "Peripheral Timeout Error", > + "False Control Error", > + "Contention Detected", > + "ECC Error, single-bit", > + "ECC Error, multi-bit", > + "Checksum Error", > + "DSI Data Type Not Recognized", > + "DSI VC ID Invalid", > + "Invalid Transmission Length", > + "Reserved", > + "DSI Protocol Violation", > +}; > + > +static int tegra_dsi_read_response(struct tegra_dsi *dsi, > + const struct mipi_dsi_msg *msg, > + unsigned int count) > +{ > + u8 *rx = msg->rx_buf; > + unsigned int i, j, k; > + size_t size = 0; > + u16 errors; > + u32 value; > + > + /* read and parse packet header */ > + value = tegra_dsi_readl(dsi, DSI_RD_DATA); > + > + switch (value & 0x3f) { > + case MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT: > + errors = (value >> 8) & 0xffff; > + dev_dbg(dsi->dev, "Acknowledge and error report: %04x\n", > + errors); > + for (i = 0; i < ARRAY_SIZE(error_report); i++) > + if (errors & BIT(i)) > + dev_dbg(dsi->dev, " %2u: %s\n", i, > + error_report[i]); > + break; > + > + case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_1BYTE: > + rx[0] = (value >> 8) & 0xff; > + break; > + > + case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_2BYTE: > + rx[0] = (value >> 8) & 0xff; > + rx[1] = (value >> 16) & 0xff; > + break; > + > + case MIPI_DSI_RX_DCS_LONG_READ_RESPONSE: > + size = ((value >> 8) & 0xff00) | ((value >> 8) & 0xff); > + break; > + > + case MIPI_DSI_RX_GENERIC_LONG_READ_RESPONSE: > + size = ((value >> 8) & 0xff00) | ((value >> 8) & 0xff); > + break; > + > + default: > + dev_err(dsi->dev, "unhandled response type: %02x\n", > + value & 0x3f); > + break; > + } > + > + size = min(size, msg->rx_len); > + > + if (msg->rx_buf && size > 0) { > + for (i = 0, j = 0; i < count - 1; i++, j += 4) { > + u8 *rx = msg->rx_buf + j; > + > + value = tegra_dsi_readl(dsi, DSI_RD_DATA); > + > + for (k = 0; k < 4 && (j + k) < msg->rx_len; k++) > + rx[j + k] = (value >> (k << 3)) & 0xff; > + } > + } > + > + return 0; > +} > + > +static int tegra_dsi_transmit(struct tegra_dsi *dsi, unsigned long timeout) > +{ > + tegra_dsi_writel(dsi, DSI_TRIGGER_HOST, DSI_TRIGGER); > + > + timeout = jiffies + msecs_to_jiffies(timeout); > + > + while (time_before(jiffies, timeout)) { > + u32 value = tegra_dsi_readl(dsi, DSI_TRIGGER); > + if ((value & DSI_TRIGGER_HOST) == 0) > + return 0; > + > + usleep_range(1000, 2000); > + } > + > + DRM_DEBUG_KMS("timeout waiting for transmission to complete\n"); > + return -ETIMEDOUT; > +} > + > +static int tegra_dsi_wait_for_response(struct tegra_dsi *dsi, > + unsigned long timeout) > +{ > + timeout = jiffies + msecs_to_jiffies(250); > + > + while (time_before(jiffies, timeout)) { > + u32 value = tegra_dsi_readl(dsi, DSI_STATUS); > + u8 count = value & 0x1f; > + > + if (count > 0) > + return count; > + > + usleep_range(1000, 2000); > + } > + > + DRM_DEBUG_KMS("peripheral returned no data\n"); > + return -ETIMEDOUT; > +} > + > +static ssize_t tegra_dsi_host_transfer(struct mipi_dsi_host *host, > + const struct mipi_dsi_msg *msg) > +{ > + struct tegra_dsi *dsi = host_to_tegra(host); > + const u8 *tx = msg->tx_buf; > + unsigned int count, i, j; > + u32 value; > + int err; > + > + /* maximum FIFO depth is 1920 words */ > + if (msg->tx_len > dsi->video_fifo_depth * 4) > + return -ENOSPC; > + > + /* reset underflow/overflow flags */ > + value = tegra_dsi_readl(dsi, DSI_STATUS); > + if (value & (DSI_STATUS_UNDERFLOW | DSI_STATUS_OVERFLOW)) { > + value = DSI_HOST_CONTROL_FIFO_RESET; > + tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); > + usleep_range(10, 20); > + } > + > + value = tegra_dsi_readl(dsi, DSI_POWER_CONTROL); > + value |= DSI_POWER_CONTROL_ENABLE; > + tegra_dsi_writel(dsi, value, DSI_POWER_CONTROL); > + > + usleep_range(5000, 10000); > + > + value = DSI_HOST_CONTROL_CRC_RESET | DSI_HOST_CONTROL_TX_TRIG_HOST | > + DSI_HOST_CONTROL_CS | DSI_HOST_CONTROL_ECC; > + > + if ((msg->flags & MIPI_DSI_MSG_USE_LPM) == 0) > + value |= DSI_HOST_CONTROL_HS; > + > + /* > + * The host FIFO has a maximum of 64 words, so larger transmissions > + * need to use the video FIFO. > + */ > + if (msg->tx_len > dsi->host_fifo_depth * 4) > + value |= DSI_HOST_CONTROL_FIFO_SEL; > + > + tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); > + > + /* > + * For reads and messages with explicitly requested ACK, generate a > + * BTA sequence after the transmission of the packet. > + */ > + if ((msg->flags & MIPI_DSI_MSG_REQ_ACK) || > + (msg->rx_buf && msg->rx_len > 0)) { > + value = tegra_dsi_readl(dsi, DSI_HOST_CONTROL); > + value |= DSI_HOST_CONTROL_PKT_BTA; > + tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); > + } > + > + value = DSI_CONTROL_LANES(0) | DSI_CONTROL_HOST_ENABLE; > + tegra_dsi_writel(dsi, value, DSI_CONTROL); > + > + /* write packet header */ > + value = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f); > + > + if (tx && msg->tx_len > 0) > + value |= tx[0] << 8; > + > + if (tx && msg->tx_len > 1) > + value |= tx[1] << 16; > + > + tegra_dsi_writel(dsi, value, DSI_WR_DATA); > + > + /* write payload (if any) */ > + if (msg->tx_len > 2) { > + for (j = 2; j < msg->tx_len; j += 4) { > + value = 0; > + > + for (i = 0; i < 4 && j + i < msg->tx_len; i++) > + value |= tx[j + i] << (i << 3); > + > + tegra_dsi_writel(dsi, value, DSI_WR_DATA); > + } > + } > + > + err = tegra_dsi_transmit(dsi, 250); > + if (err < 0) > + return err; > + > + if ((msg->flags & MIPI_DSI_MSG_REQ_ACK) || > + (msg->rx_buf && msg->rx_len > 0)) { > + err = tegra_dsi_wait_for_response(dsi, 250); > + if (err < 0) > + return err; > + > + count = err; > + > + value = tegra_dsi_readl(dsi, DSI_RD_DATA); > + switch (value) { > + case 0x84: > + /* > + dev_dbg(dsi->dev, "ACK\n"); > + */ > + break; > + > + case 0x87: > + /* > + dev_dbg(dsi->dev, "ESCAPE\n"); > + */ > + break; > + > + default: > + dev_err(dsi->dev, "unknown status: %08x\n", value); > + break; > + } > + > + if (count > 1) { > + err = tegra_dsi_read_response(dsi, msg, count); > + if (err < 0) > + dev_err(dsi->dev, > + "failed to parse response: %d\n", > + err); > + } > + } > + > + return 0; Hi Thierry, According to the comment in drm_mipi_dsi.h, this should return "the number of bytes transmitted for write packets or the number of bytes received for read packets" on success. Sean > +} > + > +static int tegra_dsi_ganged_setup(struct tegra_dsi *dsi) > +{ > + struct clk *parent; > + int err; > + > + /* make sure both DSI controllers share the same PLL */ > + parent = clk_get_parent(dsi->slave->clk); > + if (!parent) > + return -EINVAL; > + > + err = clk_set_parent(parent, dsi->clk_parent); > + if (err < 0) > + return err; > + > + return 0; > +} > + > static int tegra_dsi_host_attach(struct mipi_dsi_host *host, > struct mipi_dsi_device *device) > { > struct tegra_dsi *dsi = host_to_tegra(host); > - struct tegra_output *output = &dsi->output; > > dsi->flags = device->mode_flags; > dsi->format = device->format; > dsi->lanes = device->lanes; > > - output->panel = of_drm_find_panel(device->dev.of_node); > - if (output->panel) { > - if (output->connector.dev) > + if (dsi->slave) { > + int err; > + > + dev_dbg(dsi->dev, "attaching dual-channel device %s\n", > + dev_name(&device->dev)); > + > + err = tegra_dsi_ganged_setup(dsi); > + if (err < 0) { > + dev_err(dsi->dev, "failed to set up ganged mode: %d\n", > + err); > + return err; > + } > + } > + > + /* > + * Slaves don't have a panel associated with them, so they provide > + * merely the second channel. > + */ > + if (!dsi->master) { > + struct tegra_output *output = &dsi->output; > + > + output->panel = of_drm_find_panel(device->dev.of_node); > + if (output->panel && output->connector.dev) { > + drm_panel_attach(output->panel, &output->connector); > drm_helper_hpd_irq_event(output->connector.dev); > + } > } > > return 0; > @@ -818,10 +1298,10 @@ static int tegra_dsi_host_detach(struct mipi_dsi_host *host, > struct tegra_output *output = &dsi->output; > > if (output->panel && &device->dev == output->panel->dev) { > + output->panel = NULL; > + > if (output->connector.dev) > drm_helper_hpd_irq_event(output->connector.dev); > - > - output->panel = NULL; > } > > return 0; > @@ -830,8 +1310,29 @@ static int tegra_dsi_host_detach(struct mipi_dsi_host *host, > static const struct mipi_dsi_host_ops tegra_dsi_host_ops = { > .attach = tegra_dsi_host_attach, > .detach = tegra_dsi_host_detach, > + .transfer = tegra_dsi_host_transfer, > }; > > +static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi) > +{ > + struct device_node *np; > + > + np = of_parse_phandle(dsi->dev->of_node, "nvidia,ganged-mode", 0); > + if (np) { > + struct platform_device *gangster = of_find_device_by_node(np); > + > + dsi->slave = platform_get_drvdata(gangster); > + of_node_put(np); > + > + if (!dsi->slave) > + return -EPROBE_DEFER; > + > + dsi->slave->master = dsi; > + } > + > + return 0; > +} > + > static int tegra_dsi_probe(struct platform_device *pdev) > { > struct tegra_dsi *dsi; > @@ -846,10 +1347,16 @@ static int tegra_dsi_probe(struct platform_device *pdev) > dsi->video_fifo_depth = 1920; > dsi->host_fifo_depth = 64; > > + err = tegra_dsi_ganged_probe(dsi); > + if (err < 0) > + return err; > + > err = tegra_output_probe(&dsi->output); > if (err < 0) > return err; > > + dsi->output.connector.polled = DRM_CONNECTOR_POLL_HPD; > + > /* > * Assume these values by default. When a DSI peripheral driver > * attaches to the DSI host, the parameters will be taken from > @@ -863,68 +1370,83 @@ static int tegra_dsi_probe(struct platform_device *pdev) > if (IS_ERR(dsi->rst)) > return PTR_ERR(dsi->rst); > > + err = reset_control_deassert(dsi->rst); > + if (err < 0) { > + dev_err(&pdev->dev, "failed to bring DSI out of reset: %d\n", > + err); > + return err; > + } > + > dsi->clk = devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(dsi->clk)) { > dev_err(&pdev->dev, "cannot get DSI clock\n"); > - return PTR_ERR(dsi->clk); > + err = PTR_ERR(dsi->clk); > + goto reset; > } > > err = clk_prepare_enable(dsi->clk); > if (err < 0) { > dev_err(&pdev->dev, "cannot enable DSI clock\n"); > - return err; > + goto reset; > } > > dsi->clk_lp = devm_clk_get(&pdev->dev, "lp"); > if (IS_ERR(dsi->clk_lp)) { > dev_err(&pdev->dev, "cannot get low-power clock\n"); > - return PTR_ERR(dsi->clk_lp); > + err = PTR_ERR(dsi->clk_lp); > + goto disable_clk; > } > > err = clk_prepare_enable(dsi->clk_lp); > if (err < 0) { > dev_err(&pdev->dev, "cannot enable low-power clock\n"); > - return err; > + goto disable_clk; > } > > dsi->clk_parent = devm_clk_get(&pdev->dev, "parent"); > if (IS_ERR(dsi->clk_parent)) { > dev_err(&pdev->dev, "cannot get parent clock\n"); > - return PTR_ERR(dsi->clk_parent); > - } > - > - err = clk_prepare_enable(dsi->clk_parent); > - if (err < 0) { > - dev_err(&pdev->dev, "cannot enable parent clock\n"); > - return err; > + err = PTR_ERR(dsi->clk_parent); > + goto disable_clk_lp; > } > > dsi->vdd = devm_regulator_get(&pdev->dev, "avdd-dsi-csi"); > if (IS_ERR(dsi->vdd)) { > dev_err(&pdev->dev, "cannot get VDD supply\n"); > - return PTR_ERR(dsi->vdd); > + err = PTR_ERR(dsi->vdd); > + goto disable_clk_lp; > } > > err = regulator_enable(dsi->vdd); > if (err < 0) { > dev_err(&pdev->dev, "cannot enable VDD supply\n"); > - return err; > + goto disable_clk_lp; > } > > err = tegra_dsi_setup_clocks(dsi); > if (err < 0) { > dev_err(&pdev->dev, "cannot setup clocks\n"); > - return err; > + goto disable_vdd; > } > > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > dsi->regs = devm_ioremap_resource(&pdev->dev, regs); > - if (IS_ERR(dsi->regs)) > - return PTR_ERR(dsi->regs); > + if (IS_ERR(dsi->regs)) { > + err = PTR_ERR(dsi->regs); > + goto disable_vdd; > + } > > dsi->mipi = tegra_mipi_request(&pdev->dev); > - if (IS_ERR(dsi->mipi)) > - return PTR_ERR(dsi->mipi); > + if (IS_ERR(dsi->mipi)) { > + err = PTR_ERR(dsi->mipi); > + goto disable_vdd; > + } > + > + err = tegra_dsi_pad_calibrate(dsi); > + if (err < 0) { > + dev_err(dsi->dev, "MIPI calibration failed: %d\n", err); > + goto mipi_free; > + } > > dsi->host.ops = &tegra_dsi_host_ops; > dsi->host.dev = &pdev->dev; > @@ -932,7 +1454,7 @@ static int tegra_dsi_probe(struct platform_device *pdev) > err = mipi_dsi_host_register(&dsi->host); > if (err < 0) { > dev_err(&pdev->dev, "failed to register DSI host: %d\n", err); > - return err; > + goto mipi_free; > } > > INIT_LIST_HEAD(&dsi->client.list); > @@ -943,12 +1465,26 @@ static int tegra_dsi_probe(struct platform_device *pdev) > if (err < 0) { > dev_err(&pdev->dev, "failed to register host1x client: %d\n", > err); > - return err; > + goto unregister; > } > > platform_set_drvdata(pdev, dsi); > > return 0; > + > +unregister: > + mipi_dsi_host_unregister(&dsi->host); > +mipi_free: > + tegra_mipi_free(dsi->mipi); > +disable_vdd: > + regulator_disable(dsi->vdd); > +disable_clk_lp: > + clk_disable_unprepare(dsi->clk_lp); > +disable_clk: > + clk_disable_unprepare(dsi->clk); > +reset: > + reset_control_assert(dsi->rst); > + return err; > } > > static int tegra_dsi_remove(struct platform_device *pdev) > @@ -967,7 +1503,6 @@ static int tegra_dsi_remove(struct platform_device *pdev) > tegra_mipi_free(dsi->mipi); > > regulator_disable(dsi->vdd); > - clk_disable_unprepare(dsi->clk_parent); > clk_disable_unprepare(dsi->clk_lp); > clk_disable_unprepare(dsi->clk); > reset_control_assert(dsi->rst); > diff --git a/drivers/gpu/drm/tegra/dsi.h b/drivers/gpu/drm/tegra/dsi.h > index 5ce610d08d77..bad1006a5150 100644 > --- a/drivers/gpu/drm/tegra/dsi.h > +++ b/drivers/gpu/drm/tegra/dsi.h > @@ -21,9 +21,16 @@ > #define DSI_INT_STATUS 0x0d > #define DSI_INT_MASK 0x0e > #define DSI_HOST_CONTROL 0x0f > +#define DSI_HOST_CONTROL_FIFO_RESET (1 << 21) > +#define DSI_HOST_CONTROL_CRC_RESET (1 << 20) > +#define DSI_HOST_CONTROL_TX_TRIG_SOL (0 << 12) > +#define DSI_HOST_CONTROL_TX_TRIG_FIFO (1 << 12) > +#define DSI_HOST_CONTROL_TX_TRIG_HOST (2 << 12) > #define DSI_HOST_CONTROL_RAW (1 << 6) > #define DSI_HOST_CONTROL_HS (1 << 5) > -#define DSI_HOST_CONTROL_BTA (1 << 2) > +#define DSI_HOST_CONTROL_FIFO_SEL (1 << 4) > +#define DSI_HOST_CONTROL_IMM_BTA (1 << 3) > +#define DSI_HOST_CONTROL_PKT_BTA (1 << 2) > #define DSI_HOST_CONTROL_CS (1 << 1) > #define DSI_HOST_CONTROL_ECC (1 << 0) > #define DSI_CONTROL 0x10 > @@ -39,9 +46,13 @@ > #define DSI_SOL_DELAY 0x11 > #define DSI_MAX_THRESHOLD 0x12 > #define DSI_TRIGGER 0x13 > +#define DSI_TRIGGER_HOST (1 << 1) > +#define DSI_TRIGGER_VIDEO (1 << 0) > #define DSI_TX_CRC 0x14 > #define DSI_STATUS 0x15 > #define DSI_STATUS_IDLE (1 << 10) > +#define DSI_STATUS_UNDERFLOW (1 << 9) > +#define DSI_STATUS_OVERFLOW (1 << 8) > #define DSI_INIT_SEQ_CONTROL 0x1a > #define DSI_INIT_SEQ_DATA_0 0x1b > #define DSI_INIT_SEQ_DATA_1 0x1c > @@ -104,6 +115,7 @@ > #define DSI_PAD_CONTROL_3 0x51 > #define DSI_PAD_CONTROL_4 0x52 > #define DSI_GANGED_MODE_CONTROL 0x53 > +#define DSI_GANGED_MODE_CONTROL_ENABLE (1 << 0) > #define DSI_GANGED_MODE_START 0x54 > #define DSI_GANGED_MODE_SIZE 0x55 > #define DSI_RAW_DATA_BYTE_COUNT 0x56 > -- > 2.1.2 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 14/14] drm/tegra: dsi: Set up PHY_TIMING & BTA_TIMING registers earlier 2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding ` (9 preceding siblings ...) 2014-10-13 10:21 ` [PATCH 13/14] drm/tegra: dsi: Add ganged mode support Thierry Reding @ 2014-10-13 10:21 ` Thierry Reding 10 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2014-10-13 10:21 UTC (permalink / raw) To: dri-devel; +Cc: linux-tegra From: Sean Paul <seanpaul@chromium.org> Make sure the DSI PHY_TIMING and BTA_TIMING registers are initialized when the clocks are set up as opposed to when the output is enabled. This makes sure that the PHY timings are properly set up when the panel is prepared and that DCS commands sent at that time use the appropriate timings. Signed-off-by: Sean Paul <seanpaul@chromium.org> --- drivers/gpu/drm/tegra/dsi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index b7b205496e8c..0adc7804e261 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -389,6 +389,9 @@ static int tegra_dsi_set_phy_timing(struct tegra_dsi *dsi) DSI_TIMING_FIELD(timing.tago, period, 1); tegra_dsi_writel(dsi, value, DSI_BTA_TIMING); + if (dsi->slave) + return tegra_dsi_set_phy_timing(dsi->slave); + return 0; } @@ -536,10 +539,6 @@ static int tegra_dsi_configure(struct tegra_dsi *dsi, unsigned int pipe, value &= ~DSI_CONTROL_HOST_ENABLE; tegra_dsi_writel(dsi, value, DSI_CONTROL); - err = tegra_dsi_set_phy_timing(dsi); - if (err < 0) - return err; - for (i = 0; i < NUM_PKT_SEQ; i++) tegra_dsi_writel(dsi, pkt_seq[i], DSI_PKT_SEQ_0_LO + i); @@ -860,6 +859,10 @@ static int tegra_output_dsi_setup_clock(struct tegra_output *output, */ tegra_dsi_set_timeout(dsi, bclk, vrefresh); + err = tegra_dsi_set_phy_timing(dsi); + if (err < 0) + return err; + return 0; } -- 2.1.2 ^ permalink raw reply related [flat|nested] 15+ messages in thread
end of thread, other threads:[~2014-10-14 14:51 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13 10:21 [PATCH 01/14] gpu: host1x: Use struct host1x_bo pointers in traces Thierry Reding
2014-10-13 10:21 ` [PATCH 03/14] gpu: host1x: Fix typo in comment Thierry Reding
2014-10-13 10:21 ` [PATCH 04/14] gpu: host1x: Print address/offset pairs consistently Thierry Reding
2014-10-13 10:21 ` [PATCH 05/14] gpu: host1x: Make gather offsets unsigned Thierry Reding
[not found] ` <1413195715-4719-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-13 10:21 ` [PATCH 02/14] gpu: host1x: Make mapped field of push buffers void * Thierry Reding
2014-10-13 10:21 ` [PATCH 06/14] gpu: host1x: mipi: Registers are 32 bits wide Thierry Reding
2014-10-13 10:21 ` [PATCH 11/14] drm/tegra: Do not enable output on .mode_set() Thierry Reding
2014-10-13 10:21 ` [PATCH 07/14] gpu: host1x: mipi: Preserve the contents of MIPI_CAL_CTRL Thierry Reding
2014-10-13 10:21 ` [PATCH 08/14] gpu: host1x: mipi: Calibrate clock lanes Thierry Reding
2014-10-13 10:21 ` [PATCH 09/14] gpu: host1x: mipi: Set MIPI_CAL_BIAS_PAD_CFG1 register Thierry Reding
2014-10-13 10:21 ` [PATCH 10/14] drm/tegra: dc: Add powergate support Thierry Reding
2014-10-13 10:21 ` [PATCH 12/14] drm/tegra: dsi: Make FIFO depths host parameters Thierry Reding
2014-10-13 10:21 ` [PATCH 13/14] drm/tegra: dsi: Add ganged mode support Thierry Reding
[not found] ` <1413195715-4719-13-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-14 14:51 ` Sean Paul
2014-10-13 10:21 ` [PATCH 14/14] drm/tegra: dsi: Set up PHY_TIMING & BTA_TIMING registers earlier Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox