dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 03/15] vga_switcheroo: Set active attribute to false for audio clients
Date: Sat, 19 Sep 2015 19:50:12 +0200	[thread overview]
Message-ID: <20150919175012.GA7890@wunner.de> (raw)
In-Reply-To: <s5hvbb6xss5.wl-tiwai@suse.de>

Hi Takashi,

On Sat, Sep 19, 2015 at 06:44:58PM +0200, Takashi Iwai wrote:
> Without the cover letter I can't judge why this change is needed, so
> at the next time, please put relevant people to Cc of the cover letter
> (or the whole series).

There was no cover letter, aside from this reply to Daniel Vetter:
http://lists.freedesktop.org/archives/dri-devel/2015-September/090510.html

Basically he had asked for vga_switcheroo docs, which I've now written,
and in course of doing that I fixed some bugs and cosmetic issues.
I cc'ed you on the docs patch and all the patches which touch ALSA code
so that you get a chance to raise objections (or ack the patches should
you have none). Full patch set is here:
https://github.com/l1k/linux/commits/vga_switcheroo_docs

The patch you've replied to (03/15 "vga_switcheroo: Set active attribute
to false for audio clients") fixes a misuse of the "active" attribute in
struct vga_switcheroo_client by audio clients. The attribute is never
used for audio clients, so there are no behavioral changes with this patch,
it only removes superfluous/confusing code.

Thanks,

Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-09-19 17:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 13:18 [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Lukas Wunner
2015-08-29 12:29 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Lukas Wunner
2015-08-27 14:43   ` [PATCH 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-08-23 21:23     ` [PATCH 04/15] vga_switcheroo: Add missing locking Lukas Wunner
2015-09-08 12:17       ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Lukas Wunner
2015-08-28  9:56         ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Lukas Wunner
2015-08-28 11:30           ` [PATCH 07/15] vga_switcheroo: Use VGA_SWITCHEROO_UNKNOWN_ID instead of -1 Lukas Wunner
2015-08-28 10:54             ` [PATCH 08/15] vga_switcheroo: Use enum vga_switcheroo_client_id instead of int Lukas Wunner
2015-09-05 11:40               ` [PATCH 09/15] vga_switcheroo: Sort headers alphabetically Lukas Wunner
2015-09-04 18:49                 ` [PATCH 10/15] ALSA: hda - Spell vga_switcheroo consistently Lukas Wunner
2015-09-04 19:06                   ` [PATCH 11/15] drm/i915: " Lukas Wunner
2015-09-05  9:09                     ` [PATCH 12/15] drm/nouveau: " Lukas Wunner
2015-09-05  9:14                       ` [PATCH 13/15] drm/radeon: " Lukas Wunner
2015-09-05  9:17                         ` [PATCH 14/15] drm/amdgpu: " Lukas Wunner
2015-09-05  9:22                           ` [PATCH 15/15] drm: " Lukas Wunner
2015-09-22  9:20                             ` Daniel Vetter
2015-09-23 21:45                           ` [PATCH 14/15] drm/amdgpu: " Alex Deucher
2015-09-22  9:20                     ` [PATCH 11/15] drm/i915: " Daniel Vetter
2015-10-02  7:35           ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Jani Nikula
2015-10-02  8:22         ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Daniel Vetter
2015-10-25 18:19           ` Lukas Wunner
2015-10-26  7:24             ` Takashi Iwai
2015-08-27 14:43     ` [PATCH v1.1 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-09-23  7:13       ` Daniel Vetter
2015-09-24  9:40         ` Takashi Iwai
2015-09-24 15:13           ` Daniel Vetter
2015-10-01 16:19             ` Lukas Wunner
2015-09-24  9:37       ` Takashi Iwai
2015-09-17 17:15     ` [PATCH " Lukas Wunner
2015-09-22  9:17       ` Daniel Vetter
2015-09-19 16:44     ` Takashi Iwai
2015-09-19 17:50       ` Lukas Wunner [this message]
2015-09-24  9:39         ` Takashi Iwai
2015-09-22  8:38   ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Daniel Vetter
2015-09-17 16:34 ` [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Danilo Cesar Lemes de Paula
2015-09-17 17:31   ` Lukas Wunner
2015-09-17 17:56     ` Danilo Cesar Lemes de Paula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150919175012.GA7890@wunner.de \
    --to=lukas@wunner.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox