From: Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>
To: Lukas Wunner <lukas@wunner.de>
Cc: dri-devel@lists.freedesktop.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 01/15] vga_switcheroo: Document _ALL_ the things!
Date: Thu, 17 Sep 2015 14:56:20 -0300 [thread overview]
Message-ID: <55FAFEC4.3020101@collabora.co.uk> (raw)
In-Reply-To: <20150917173123.GB7184@wunner.de>
On 09/17/2015 02:31 PM, Lukas Wunner wrote:
> Hi Danilo,
>
> On Thu, Sep 17, 2015 at 01:34:54PM -0300, Danilo Cesar Lemes de Paula wrote:
>>> - * GPU driver interface
>>> - * - set_gpu_state - this should do the equiv of s/r for the card
>>> - * - this should *not* set the discrete power state
>>
>> Did you check if this creates the desired format? (ie: Doesn't create a
>> <code> block).
>
> These lines are deleted by the patch.
Sorry, you're totally right.
>
> One oddity I did notice however is that in the HTML documentation for the
> public function vga_switcheroo_process_delayed_switch(), instead of the
> heading "Description" it says "Manual switching and manual power control"
> (which is the identifier of the preceding DOC section). I guess it's a bug
> in kernel-doc but I couldn't be bothered so far to look into it. No idea
> if it's introduced by your patches or if it was there all along.
That's odd... But I can have a look later.
>
> Another thing I noticed is that URLs are not clickable in the HTML output.
Did you tried the correct format? I just saw a regular http string,
which won't be converted. Markdown has this not obvious format for
links: This is a [Google](http://google.com) link
http://pandoc.org/try/?text=sudo+give+me+a+[link]%28http%3A%2F%2Fkernel.org%29%0A&from=markdown&to=docbook
>
> Otherwise the markdown support works great (though I've only used it for
> unsorted lists in this documentation).
>
> Thanks,
>
> Lukas
>
Danilo Cesar
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-09-17 17:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 13:18 [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Lukas Wunner
2015-08-29 12:29 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Lukas Wunner
2015-08-27 14:43 ` [PATCH 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-08-23 21:23 ` [PATCH 04/15] vga_switcheroo: Add missing locking Lukas Wunner
2015-09-08 12:17 ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Lukas Wunner
2015-08-28 9:56 ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Lukas Wunner
2015-08-28 11:30 ` [PATCH 07/15] vga_switcheroo: Use VGA_SWITCHEROO_UNKNOWN_ID instead of -1 Lukas Wunner
2015-08-28 10:54 ` [PATCH 08/15] vga_switcheroo: Use enum vga_switcheroo_client_id instead of int Lukas Wunner
2015-09-05 11:40 ` [PATCH 09/15] vga_switcheroo: Sort headers alphabetically Lukas Wunner
2015-09-04 18:49 ` [PATCH 10/15] ALSA: hda - Spell vga_switcheroo consistently Lukas Wunner
2015-09-04 19:06 ` [PATCH 11/15] drm/i915: " Lukas Wunner
2015-09-05 9:09 ` [PATCH 12/15] drm/nouveau: " Lukas Wunner
2015-09-05 9:14 ` [PATCH 13/15] drm/radeon: " Lukas Wunner
2015-09-05 9:17 ` [PATCH 14/15] drm/amdgpu: " Lukas Wunner
2015-09-05 9:22 ` [PATCH 15/15] drm: " Lukas Wunner
2015-09-22 9:20 ` Daniel Vetter
2015-09-23 21:45 ` [PATCH 14/15] drm/amdgpu: " Alex Deucher
2015-09-22 9:20 ` [PATCH 11/15] drm/i915: " Daniel Vetter
2015-10-02 7:35 ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Jani Nikula
2015-10-02 8:22 ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Daniel Vetter
2015-10-25 18:19 ` Lukas Wunner
2015-10-26 7:24 ` Takashi Iwai
2015-08-27 14:43 ` [PATCH v1.1 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-09-23 7:13 ` Daniel Vetter
2015-09-24 9:40 ` Takashi Iwai
2015-09-24 15:13 ` Daniel Vetter
2015-10-01 16:19 ` Lukas Wunner
2015-09-24 9:37 ` Takashi Iwai
2015-09-17 17:15 ` [PATCH " Lukas Wunner
2015-09-22 9:17 ` Daniel Vetter
2015-09-19 16:44 ` Takashi Iwai
2015-09-19 17:50 ` Lukas Wunner
2015-09-24 9:39 ` Takashi Iwai
2015-09-22 8:38 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Daniel Vetter
2015-09-17 16:34 ` [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Danilo Cesar Lemes de Paula
2015-09-17 17:31 ` Lukas Wunner
2015-09-17 17:56 ` Danilo Cesar Lemes de Paula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAFEC4.3020101@collabora.co.uk \
--to=danilo.cesar@collabora.co.uk \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox