From: Daniel Vetter <daniel@ffwll.ch>
To: Lukas Wunner <lukas@wunner.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 11/15] drm/i915: Spell vga_switcheroo consistently
Date: Tue, 22 Sep 2015 11:20:14 +0200 [thread overview]
Message-ID: <20150922092014.GA3383@phenom.ffwll.local> (raw)
In-Reply-To: <dc88ce9beb5f3065073585e1826beb7c79f1371b.1442497843.git.lukas@wunner.de>
On Fri, Sep 04, 2015 at 09:06:15PM +0200, Lukas Wunner wrote:
> Currently everyone and their dog has their own favourite spelling
> for vga_switcheroo. This makes it hard to grep dmesg for log entries
> relating to vga_switcheroo. It also makes it hard to find related
> source files in the tree.
>
> vga_switcheroo.c uses pr_fmt "vga_switcheroo". Use that everywhere.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_acpi.c | 2 +-
> drivers/gpu/drm/i915/intel_panel.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c
> index d96eee1..8b13b9d 100644
> --- a/drivers/gpu/drm/i915/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/intel_acpi.c
> @@ -146,7 +146,7 @@ static bool intel_dsm_detect(void)
>
> if (vga_count == 2 && has_dsm) {
> acpi_get_name(intel_dsm_priv.dhandle, ACPI_FULL_PATHNAME, &buffer);
> - DRM_DEBUG_DRIVER("VGA switcheroo: detected DSM switching method %s handle\n",
> + DRM_DEBUG_DRIVER("vga_switcheroo: detected DSM switching method %s handle\n",
> acpi_method_name);
> return true;
> }
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index e2ab3f6..04f7d8e 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -809,7 +809,7 @@ void intel_panel_disable_backlight(struct intel_connector *connector)
> return;
>
> /*
> - * Do not disable backlight on the vgaswitcheroo path. When switching
> + * Do not disable backlight on the vga_switcheroo path. When switching
> * away from i915, the other client may depend on i915 to handle the
> * backlight. This will leave the backlight on unnecessarily when
> * another client is not activated.
> --
> 1.8.5.2 (Apple Git-48)
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-09-22 9:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 13:18 [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Lukas Wunner
2015-08-29 12:29 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Lukas Wunner
2015-08-27 14:43 ` [PATCH 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-08-23 21:23 ` [PATCH 04/15] vga_switcheroo: Add missing locking Lukas Wunner
2015-09-08 12:17 ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Lukas Wunner
2015-08-28 9:56 ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Lukas Wunner
2015-08-28 11:30 ` [PATCH 07/15] vga_switcheroo: Use VGA_SWITCHEROO_UNKNOWN_ID instead of -1 Lukas Wunner
2015-08-28 10:54 ` [PATCH 08/15] vga_switcheroo: Use enum vga_switcheroo_client_id instead of int Lukas Wunner
2015-09-05 11:40 ` [PATCH 09/15] vga_switcheroo: Sort headers alphabetically Lukas Wunner
2015-09-04 18:49 ` [PATCH 10/15] ALSA: hda - Spell vga_switcheroo consistently Lukas Wunner
2015-09-04 19:06 ` [PATCH 11/15] drm/i915: " Lukas Wunner
2015-09-05 9:09 ` [PATCH 12/15] drm/nouveau: " Lukas Wunner
2015-09-05 9:14 ` [PATCH 13/15] drm/radeon: " Lukas Wunner
2015-09-05 9:17 ` [PATCH 14/15] drm/amdgpu: " Lukas Wunner
2015-09-05 9:22 ` [PATCH 15/15] drm: " Lukas Wunner
2015-09-22 9:20 ` Daniel Vetter
2015-09-23 21:45 ` [PATCH 14/15] drm/amdgpu: " Alex Deucher
2015-09-22 9:20 ` Daniel Vetter [this message]
2015-10-02 7:35 ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Jani Nikula
2015-10-02 8:22 ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Daniel Vetter
2015-10-25 18:19 ` Lukas Wunner
2015-10-26 7:24 ` Takashi Iwai
2015-08-27 14:43 ` [PATCH v1.1 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-09-23 7:13 ` Daniel Vetter
2015-09-24 9:40 ` Takashi Iwai
2015-09-24 15:13 ` Daniel Vetter
2015-10-01 16:19 ` Lukas Wunner
2015-09-24 9:37 ` Takashi Iwai
2015-09-17 17:15 ` [PATCH " Lukas Wunner
2015-09-22 9:17 ` Daniel Vetter
2015-09-19 16:44 ` Takashi Iwai
2015-09-19 17:50 ` Lukas Wunner
2015-09-24 9:39 ` Takashi Iwai
2015-09-22 8:38 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Daniel Vetter
2015-09-17 16:34 ` [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Danilo Cesar Lemes de Paula
2015-09-17 17:31 ` Lukas Wunner
2015-09-17 17:56 ` Danilo Cesar Lemes de Paula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922092014.GA3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox