From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int
Date: Fri, 02 Oct 2015 10:35:07 +0300 [thread overview]
Message-ID: <87y4flafkk.fsf@intel.com> (raw)
In-Reply-To: <68e94f9e8066291430e6b5134284a965498bc8e9.1442497843.git.lukas@wunner.de>
On Fri, 28 Aug 2015, Lukas Wunner <lukas@wunner.de> wrote:
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/vga/vga_switcheroo.c | 6 +++---
> include/linux/vga_switcheroo.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c
> index 845e47d..7b53246 100644
> --- a/drivers/gpu/vga/vga_switcheroo.c
> +++ b/drivers/gpu/vga/vga_switcheroo.c
> @@ -102,7 +102,7 @@
> struct vga_switcheroo_client {
> struct pci_dev *pdev;
> struct fb_info *fb_info;
> - int pwr_state;
> + enum vga_switcheroo_state pwr_state;
> const struct vga_switcheroo_client_ops *ops;
> int id;
> bool active;
> @@ -346,7 +346,7 @@ find_active_client(struct list_head *head)
> *
> * Return: Power state.
> */
> -int vga_switcheroo_get_client_state(struct pci_dev *pdev)
> +enum vga_switcheroo_state vga_switcheroo_get_client_state(struct pci_dev *pdev)
> {
> struct vga_switcheroo_client *client;
> enum vga_switcheroo_state ret;
> @@ -496,7 +496,7 @@ static int vga_switchoff(struct vga_switcheroo_client *client)
> return 0;
> }
>
> -static void set_audio_state(int id, int state)
> +static void set_audio_state(int id, enum vga_switcheroo_state state)
> {
> struct vga_switcheroo_client *client;
>
> diff --git a/include/linux/vga_switcheroo.h b/include/linux/vga_switcheroo.h
> index 95bfbeb0..219876e 100644
> --- a/include/linux/vga_switcheroo.h
> +++ b/include/linux/vga_switcheroo.h
> @@ -133,7 +133,7 @@ void vga_switcheroo_unregister_handler(void);
>
> int vga_switcheroo_process_delayed_switch(void);
>
> -int vga_switcheroo_get_client_state(struct pci_dev *dev);
> +enum vga_switcheroo_state vga_switcheroo_get_client_state(struct pci_dev *dev);
>
> void vga_switcheroo_set_dynamic_switch(struct pci_dev *pdev, enum vga_switcheroo_state dynamic);
>
> @@ -152,7 +152,7 @@ static inline int vga_switcheroo_register_audio_client(struct pci_dev *pdev,
> int id) { return 0; }
> static inline void vga_switcheroo_unregister_handler(void) {}
> static inline int vga_switcheroo_process_delayed_switch(void) { return 0; }
> -static inline int vga_switcheroo_get_client_state(struct pci_dev *dev) { return VGA_SWITCHEROO_ON; }
> +static inline enum vga_switcheroo_state vga_switcheroo_get_client_state(struct pci_dev *dev) { return VGA_SWITCHEROO_ON; }
>
> static inline void vga_switcheroo_set_dynamic_switch(struct pci_dev *pdev, enum vga_switcheroo_state dynamic) {}
>
> --
> 1.8.5.2 (Apple Git-48)
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-10-02 7:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 13:18 [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Lukas Wunner
2015-08-29 12:29 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Lukas Wunner
2015-08-27 14:43 ` [PATCH 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-08-23 21:23 ` [PATCH 04/15] vga_switcheroo: Add missing locking Lukas Wunner
2015-09-08 12:17 ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Lukas Wunner
2015-08-28 9:56 ` [PATCH 06/15] vga_switcheroo: Use enum vga_switcheroo_state instead of int Lukas Wunner
2015-08-28 11:30 ` [PATCH 07/15] vga_switcheroo: Use VGA_SWITCHEROO_UNKNOWN_ID instead of -1 Lukas Wunner
2015-08-28 10:54 ` [PATCH 08/15] vga_switcheroo: Use enum vga_switcheroo_client_id instead of int Lukas Wunner
2015-09-05 11:40 ` [PATCH 09/15] vga_switcheroo: Sort headers alphabetically Lukas Wunner
2015-09-04 18:49 ` [PATCH 10/15] ALSA: hda - Spell vga_switcheroo consistently Lukas Wunner
2015-09-04 19:06 ` [PATCH 11/15] drm/i915: " Lukas Wunner
2015-09-05 9:09 ` [PATCH 12/15] drm/nouveau: " Lukas Wunner
2015-09-05 9:14 ` [PATCH 13/15] drm/radeon: " Lukas Wunner
2015-09-05 9:17 ` [PATCH 14/15] drm/amdgpu: " Lukas Wunner
2015-09-05 9:22 ` [PATCH 15/15] drm: " Lukas Wunner
2015-09-22 9:20 ` Daniel Vetter
2015-09-23 21:45 ` [PATCH 14/15] drm/amdgpu: " Alex Deucher
2015-09-22 9:20 ` [PATCH 11/15] drm/i915: " Daniel Vetter
2015-10-02 7:35 ` Jani Nikula [this message]
2015-10-02 8:22 ` [PATCH 05/15] vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT Daniel Vetter
2015-10-25 18:19 ` Lukas Wunner
2015-10-26 7:24 ` Takashi Iwai
2015-08-27 14:43 ` [PATCH v1.1 03/15] vga_switcheroo: Set active attribute to false for audio clients Lukas Wunner
2015-09-23 7:13 ` Daniel Vetter
2015-09-24 9:40 ` Takashi Iwai
2015-09-24 15:13 ` Daniel Vetter
2015-10-01 16:19 ` Lukas Wunner
2015-09-24 9:37 ` Takashi Iwai
2015-09-17 17:15 ` [PATCH " Lukas Wunner
2015-09-22 9:17 ` Daniel Vetter
2015-09-19 16:44 ` Takashi Iwai
2015-09-19 17:50 ` Lukas Wunner
2015-09-24 9:39 ` Takashi Iwai
2015-09-22 8:38 ` [PATCH 02/15] DocBook: Add vga_switcheroo Subsystem Guide Daniel Vetter
2015-09-17 16:34 ` [PATCH 01/15] vga_switcheroo: Document _ALL_ the things! Danilo Cesar Lemes de Paula
2015-09-17 17:31 ` Lukas Wunner
2015-09-17 17:56 ` Danilo Cesar Lemes de Paula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4flafkk.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox