* [PATCH DRM] drm: Shift * to be adjacent to pointer name @ 2018-10-15 21:26 Mamta Shukla 2018-10-16 10:30 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 3+ messages in thread From: Mamta Shukla @ 2018-10-15 21:26 UTC (permalink / raw) To: outreachy-kernel; +Cc: airlied, daniel.vetter, dri-devel, sean Shift * to be adjacent to pointer name to follow Linux coding style. Issue found with checkpatch.pl ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> --- drivers/gpu/drm/drm_memory.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index d69e4fc..40c4349 100644 --- a/drivers/gpu/drm/drm_memory.c +++ b/drivers/gpu/drm/drm_memory.c @@ -51,7 +51,7 @@ #endif static void *agp_remap(unsigned long offset, unsigned long size, - struct drm_device * dev) + struct drm_device *dev) { unsigned long i, num_pages = PAGE_ALIGN(size) / PAGE_SIZE; @@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, } /** Wrapper around agp_free_memory() */ -void drm_free_agp(struct agp_memory * handle, int pages) +void drm_free_agp(struct agp_memory *handle, int pages) { agp_free_memory(handle); } /** Wrapper around agp_bind_memory() */ -int drm_bind_agp(struct agp_memory * handle, unsigned int start) +int drm_bind_agp(struct agp_memory *handle, unsigned int start) { return agp_bind_memory(handle, start); } /** Wrapper around agp_unbind_memory() */ -int drm_unbind_agp(struct agp_memory * handle) +int drm_unbind_agp(struct agp_memory *handle) { return agp_unbind_memory(handle); } #else /* CONFIG_AGP */ static inline void *agp_remap(unsigned long offset, unsigned long size, - struct drm_device * dev) + struct drm_device *dev) { return NULL; } -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH DRM] drm: Shift * to be adjacent to pointer name 2018-10-15 21:26 [PATCH DRM] drm: Shift * to be adjacent to pointer name Mamta Shukla @ 2018-10-16 10:30 ` Julia Lawall 2018-10-16 12:37 ` Daniel Vetter 0 siblings, 1 reply; 3+ messages in thread From: Julia Lawall @ 2018-10-16 10:30 UTC (permalink / raw) To: Mamta Shukla; +Cc: airlied, dri-devel, outreachy-kernel, daniel.vetter, sean On Tue, 16 Oct 2018, Mamta Shukla wrote: > Shift * to be adjacent to pointer name to follow Linux coding style. > Issue found with checkpatch.pl > ERROR: "foo * bar" should be "foo *bar" The patch looks OK, but at this point, you know how to send a patch, so it would be better to focus on changes that are more complex than whitespace issues. julia > > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> > --- > drivers/gpu/drm/drm_memory.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c > index d69e4fc..40c4349 100644 > --- a/drivers/gpu/drm/drm_memory.c > +++ b/drivers/gpu/drm/drm_memory.c > @@ -51,7 +51,7 @@ > #endif > > static void *agp_remap(unsigned long offset, unsigned long size, > - struct drm_device * dev) > + struct drm_device *dev) > { > unsigned long i, num_pages = > PAGE_ALIGN(size) / PAGE_SIZE; > @@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, > } > > /** Wrapper around agp_free_memory() */ > -void drm_free_agp(struct agp_memory * handle, int pages) > +void drm_free_agp(struct agp_memory *handle, int pages) > { > agp_free_memory(handle); > } > > /** Wrapper around agp_bind_memory() */ > -int drm_bind_agp(struct agp_memory * handle, unsigned int start) > +int drm_bind_agp(struct agp_memory *handle, unsigned int start) > { > return agp_bind_memory(handle, start); > } > > /** Wrapper around agp_unbind_memory() */ > -int drm_unbind_agp(struct agp_memory * handle) > +int drm_unbind_agp(struct agp_memory *handle) > { > return agp_unbind_memory(handle); > } > > #else /* CONFIG_AGP */ > static inline void *agp_remap(unsigned long offset, unsigned long size, > - struct drm_device * dev) > + struct drm_device *dev) > { > return NULL; > } > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015212644.GA28579%40armorer. > For more options, visit https://groups.google.com/d/optout. > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH DRM] drm: Shift * to be adjacent to pointer name 2018-10-16 10:30 ` [Outreachy kernel] " Julia Lawall @ 2018-10-16 12:37 ` Daniel Vetter 0 siblings, 0 replies; 3+ messages in thread From: Daniel Vetter @ 2018-10-16 12:37 UTC (permalink / raw) To: Julia Lawall Cc: airlied, dri-devel, outreachy-kernel, Mamta Shukla, daniel.vetter, sean On Tue, Oct 16, 2018 at 12:30:16PM +0200, Julia Lawall wrote: > > > On Tue, 16 Oct 2018, Mamta Shukla wrote: > > > Shift * to be adjacent to pointer name to follow Linux coding style. > > Issue found with checkpatch.pl > > ERROR: "foo * bar" should be "foo *bar" > > The patch looks OK, but at this point, you know how to send a patch, so it > would be better to focus on changes that are more complex than whitespace > issues. Can't hurt to test-drive patch submission to a non-outreachy mailing list with something simple :-) Thanks for your patch, applied to drm-misc-next (for 4.21/5.1 most likely). -Daniel > > julia > > > > > > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com> > > --- > > drivers/gpu/drm/drm_memory.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c > > index d69e4fc..40c4349 100644 > > --- a/drivers/gpu/drm/drm_memory.c > > +++ b/drivers/gpu/drm/drm_memory.c > > @@ -51,7 +51,7 @@ > > #endif > > > > static void *agp_remap(unsigned long offset, unsigned long size, > > - struct drm_device * dev) > > + struct drm_device *dev) > > { > > unsigned long i, num_pages = > > PAGE_ALIGN(size) / PAGE_SIZE; > > @@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, > > } > > > > /** Wrapper around agp_free_memory() */ > > -void drm_free_agp(struct agp_memory * handle, int pages) > > +void drm_free_agp(struct agp_memory *handle, int pages) > > { > > agp_free_memory(handle); > > } > > > > /** Wrapper around agp_bind_memory() */ > > -int drm_bind_agp(struct agp_memory * handle, unsigned int start) > > +int drm_bind_agp(struct agp_memory *handle, unsigned int start) > > { > > return agp_bind_memory(handle, start); > > } > > > > /** Wrapper around agp_unbind_memory() */ > > -int drm_unbind_agp(struct agp_memory * handle) > > +int drm_unbind_agp(struct agp_memory *handle) > > { > > return agp_unbind_memory(handle); > > } > > > > #else /* CONFIG_AGP */ > > static inline void *agp_remap(unsigned long offset, unsigned long size, > > - struct drm_device * dev) > > + struct drm_device *dev) > > { > > return NULL; > > } > > -- > > 1.9.1 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015212644.GA28579%40armorer. > > For more options, visit https://groups.google.com/d/optout. > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-16 12:37 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-15 21:26 [PATCH DRM] drm: Shift * to be adjacent to pointer name Mamta Shukla 2018-10-16 10:30 ` [Outreachy kernel] " Julia Lawall 2018-10-16 12:37 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox