Re: [PATCH 2/8] drm/ast: Detect DRAM before TX-chip

[Jocelyn Falempe <jfalempe@redhat.com>]

On 17/01/2025 11:29, Thomas Zimmermann wrote:
> Move DRAM detection before TX-chip detection. Both steps are independent
> from each other. Detection of the TX-chip is now next to posting those
> chips, which can be done in a single step.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/ast/ast_main.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
> index 037d389ab630d..456230bef2736 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -290,15 +290,13 @@ struct drm_device *ast_device_create(struct pci_dev *pdev,
>   	ast->regs = regs;
>   	ast->ioregs = ioregs;
>   
> -	ast_detect_tx_chip(ast, need_post);
> -
>   	ret = ast_get_dram_info(ast);
>   	if (ret)
>   		return ERR_PTR(ret);
> -
>   	drm_info(dev, "dram MCLK=%u Mhz type=%d bus_width=%d\n",
>   		 ast->mclk, ast->dram_type, ast->dram_bus_width);
>   
> +	ast_detect_tx_chip(ast, need_post);
>   	if (need_post)
>   		ast_post_gpu(ast);
>