[PATCH] drm/i915: mark display port DPMS state as 'ON' when enabling output

[PATCH] drm/i915: mark display port DPMS state as 'ON' when enabling output

[Keith Packard]

The display port DPMS state is tracked internally in the display port
driver so that when a hotplug event comes along, the driver can know
whether to try retraining the link. This doesn't work well if the
driver never sets the DPMS state to ON when the output is enabled.

Signed-off-by: Keith Packard <keithp@keithp.com>
---
 drivers/gpu/drm/i915/intel_dp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 9ab8708..8602143 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -881,6 +881,7 @@ static void intel_dp_commit(struct drm_encoder *encoder)
 	}
 	if (IS_eDP(intel_dp) || IS_PCH_eDP(intel_dp))
 		ironlake_edp_backlight_on(dev);
+	intel_dp->dpms_mode = DRM_MODE_DPMS_ON;
 }
 
 static void
-- 
1.7.1

Re: [PATCH] drm/i915: mark display port DPMS state as ON when enabling output

[Chris Wilson]

On Sun,  3 Oct 2010 13:33:49 -0700, Keith Packard <keithp@keithp.com> wrote:
> The display port DPMS state is tracked internally in the display port
> driver so that when a hotplug event comes along, the driver can know
> whether to try retraining the link. This doesn't work well if the
> driver never sets the DPMS state to ON when the output is enabled.

It appears that all users (crtc and encoders) are tracking dpms_mode, in
one form or another. Should we move this to core?

Is there any hardware that requires notification even when there is no
change?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] drm/i915: mark display port DPMS state as ON when enabling output

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 440 bytes --]

On Sun, 03 Oct 2010 22:05:13 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:

> It appears that all users (crtc and encoders) are tracking dpms_mode, in
> one form or another. Should we move this to core?

Sounds like a good idea. Would you prefer to do that yourself?

> Is there any hardware that requires notification even when there is no
> change?

I don't know, but it seems unlikely.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: mark display port DPMS state as ON when enabling output

[Chris Wilson]

On Sun, 03 Oct 2010 16:06:07 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Sun, 03 Oct 2010 22:05:13 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> 
> > It appears that all users (crtc and encoders) are tracking dpms_mode, in
> > one form or another. Should we move this to core?
> 
> Sounds like a good idea. Would you prefer to do that yourself?

I've applied the patch to -next and I'll look through to see if there is
a clean solution to moving the checks to core.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre