From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] common/rc: fix fsmap check
Date: Mon, 19 Sep 2016 20:03:32 -0700 [thread overview]
Message-ID: <20160920030332.GD10172@birch.djwong.org> (raw)
In-Reply-To: <57E0A2BD.6050003@cn.fujitsu.com>
On Tue, Sep 20, 2016 at 10:45:17AM +0800, Xiao Yang wrote:
> On 2016/09/20 6:31, Dave Chinner wrote:
> >On Mon, Sep 19, 2016 at 04:26:15PM +0800, Xiao Yang wrote:
> >>I got an error about $TEST_DIR being a directory when xfs/273 ran, because
> >>xfs_io tried to open the directory first before it parsed the -T options.
> >>So fix it by checking this error.
> >Can I suggest that you read the man page and understand how the
> >command is supposed to work before posting patches to change the
> >test? i.e the -T option /requires/ a directory to be supplied to it:
> >
> > -T create a temporary file not linked into the filesystem
> > namespace (O_TMPFILE). The pathname passed must refer to a
> > directory which is treated as virtual parent for the newly
> > created invisible file. Can not be used together with the
> > -r option.
> >
> >IOWs, there is nothing wrong with the test code - if you if
> >you are getting an EISDIR error here then something is broken with
> >the xfs_io binary you are using.
> >
> >And, because I haven't merged fsmap support into xfs_io yet, it's
> >very likely there is a problem in the prototype patchset you are
> >running. Perhaps that's worth reporting to the patchset author....
Just get rid of -T, getfsmap doesn't care if it's run against a file
or a directory.
Yes sorry that was my fault for cut-and-paste coding. :(
--D
> >
> >Cheers,
> >
> >Dave.
> Hi Dave
>
> In xfstests/common/rc:2045
> "flink" )
> testio=`$XFS_IO_PROG -T -F -c "flink $testfile" \
> $TEST_DIR 2>&1`
> echo $testio | egrep -q "invalid option|Is a directory" && \
> _notrun "xfs_io $command support is missing"
> ;;
>
> I found that someone has met the same error and sent a patch to fix flink
> check.
> Please see the following patch:
> https://git.kernel.org/cgit/fs/xfs/xfstests-dev.git/commit/common/rc?id=0fd4705782c3748b2f83a10ce7cb7f33ffc8ad77
>
> Thanks
> Xiao Yang
>
>
>
next prev parent reply other threads:[~2016-09-20 3:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:26 [PATCH] common/rc: fix fsmap check Xiao Yang
2016-09-19 22:31 ` Dave Chinner
2016-09-20 2:45 ` Xiao Yang
2016-09-20 3:03 ` Darrick J. Wong [this message]
2016-09-20 3:10 ` Xiao Yang
2016-09-20 3:15 ` [PATCH v2] " Xiao Yang
2016-09-20 3:59 ` Eryu Guan
2016-09-20 4:40 ` Xiao Yang
2016-09-20 4:48 ` Darrick J. Wong
2016-09-20 5:23 ` [PATCH v3] " Xiao Yang
2016-09-20 5:55 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920030332.GD10172@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox