Re: [PATCH v2] common/rc: fix fsmap check

[Eryu Guan <eguan@redhat.com>]

On Tue, Sep 20, 2016 at 11:15:39AM +0800, Xiao Yang wrote:
> I got an error about $TEST_DIR being a directory when running xfs/273,
> because xfs_io tried to open the directory first before it parsed the -T

I think the problem here is your xfs_io binary doesn't have -T support
(O_TMPFILE). So the commit log doesn't seem correct to me.

Just curious, what's your xfsprogs version and what's the distrobution
you're running on? xfsprogs shipped with RHEL6 and RHEL7 both have
O_TMPFILE support.

> options.  I get rid of -T to fix it because getfsmap doesn't care if it's
> run against a file or a directory.
> 
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 13afc6a..ec5d73e 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2049,7 +2049,7 @@ _require_xfs_io_command()
>  			_notrun "xfs_io $command support is missing"
>  		;;
>  	"fsmap" )
> -		testio=`$XFS_IO_PROG -T -F -c "fsmap" \
> +		testio=`$XFS_IO_PROG -F -c "fsmap" \
>  			$TEST_DIR 2>&1`

I think it's better to operate on a file in $TEST_DIR not $TEST_DIR
itself. Previously xfs_io creates a tmpfile under $TEST_DIR (-T does
this) and runs fsmap on it. Now without -T option, we have to create the
file ourselves. And the "-F" option is not needed. So it ends up with:

		testio=`$XFS_IO_PROG -f -c "fsmap" $testfile 2>&1`

Thanks,
Eryu

>  		echo $testio | egrep -q "Inappropriate ioctl" && \
>  			_notrun "xfs_io $command support is missing"
> -- 
> 1.8.3.1
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html