From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: eguan@redhat.com, fstests@vger.kernel.org
Subject: Re: [PATCH v3] common/rc: fix fsmap check
Date: Mon, 19 Sep 2016 22:55:42 -0700 [thread overview]
Message-ID: <20160920055542.GF10172@birch.djwong.org> (raw)
In-Reply-To: <1474348992-27909-1-git-send-email-yangx.jy@cn.fujitsu.com>
On Tue, Sep 20, 2016 at 01:23:12PM +0800, Xiao Yang wrote:
> We don't need -T to detect GETFSMAP and the flag doesn't exist
> on really old versions of xfs_io, so just get rid of it.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> common/rc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 13afc6a..52a75c5 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2049,8 +2049,7 @@ _require_xfs_io_command()
> _notrun "xfs_io $command support is missing"
> ;;
> "fsmap" )
> - testio=`$XFS_IO_PROG -T -F -c "fsmap" \
> - $TEST_DIR 2>&1`
> + testio=`$XFS_IO_PROG -f -c "fsmap" $testfile 2>&1`
Seems fine to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> echo $testio | egrep -q "Inappropriate ioctl" && \
> _notrun "xfs_io $command support is missing"
> ;;
> --
> 1.8.3.1
>
>
>
prev parent reply other threads:[~2016-09-20 5:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:26 [PATCH] common/rc: fix fsmap check Xiao Yang
2016-09-19 22:31 ` Dave Chinner
2016-09-20 2:45 ` Xiao Yang
2016-09-20 3:03 ` Darrick J. Wong
2016-09-20 3:10 ` Xiao Yang
2016-09-20 3:15 ` [PATCH v2] " Xiao Yang
2016-09-20 3:59 ` Eryu Guan
2016-09-20 4:40 ` Xiao Yang
2016-09-20 4:48 ` Darrick J. Wong
2016-09-20 5:23 ` [PATCH v3] " Xiao Yang
2016-09-20 5:55 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920055542.GF10172@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox