From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, david@fromorbit.com, darrick.wong@oracle.com
Subject: Re: [PATCH v2] common/rc: fix fsmap check
Date: Tue, 20 Sep 2016 12:40:51 +0800 [thread overview]
Message-ID: <57E0BDD3.5060907@cn.fujitsu.com> (raw)
In-Reply-To: <20160920035930.GD27776@eguan.usersys.redhat.com>
On 2016/09/20 11:59, Eryu Guan wrote:
> On Tue, Sep 20, 2016 at 11:15:39AM +0800, Xiao Yang wrote:
>> I got an error about $TEST_DIR being a directory when running xfs/273,
>> because xfs_io tried to open the directory first before it parsed the -T
> I think the problem here is your xfs_io binary doesn't have -T support
> (O_TMPFILE). So the commit log doesn't seem correct to me.
>
> Just curious, what's your xfsprogs version and what's the distrobution
> you're running on? xfsprogs shipped with RHEL6 and RHEL7 both have
> O_TMPFILE support.
>
Hi Eryu
I ran this case with xfsprogs-4.5.0 on RHEL7.3Beta, I think that -T
option has been supported.
Is there another reason lead to this issue?
Thanks
Xiao Yang
>> options. I get rid of -T to fix it because getfsmap doesn't care if it's
>> run against a file or a directory.
>>
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>> ---
>> common/rc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/rc b/common/rc
>> index 13afc6a..ec5d73e 100644
>> --- a/common/rc
>> +++ b/common/rc
>> @@ -2049,7 +2049,7 @@ _require_xfs_io_command()
>> _notrun "xfs_io $command support is missing"
>> ;;
>> "fsmap" )
>> - testio=`$XFS_IO_PROG -T -F -c "fsmap" \
>> + testio=`$XFS_IO_PROG -F -c "fsmap" \
>> $TEST_DIR 2>&1`
> I think it's better to operate on a file in $TEST_DIR not $TEST_DIR
> itself. Previously xfs_io creates a tmpfile under $TEST_DIR (-T does
> this) and runs fsmap on it. Now without -T option, we have to create the
> file ourselves. And the "-F" option is not needed. So it ends up with:
>
> testio=`$XFS_IO_PROG -f -c "fsmap" $testfile 2>&1`
>
> Thanks,
> Eryu
>
>> echo $testio | egrep -q "Inappropriate ioctl"&& \
>> _notrun "xfs_io $command support is missing"
>> --
>> 1.8.3.1
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
next prev parent reply other threads:[~2016-09-20 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:26 [PATCH] common/rc: fix fsmap check Xiao Yang
2016-09-19 22:31 ` Dave Chinner
2016-09-20 2:45 ` Xiao Yang
2016-09-20 3:03 ` Darrick J. Wong
2016-09-20 3:10 ` Xiao Yang
2016-09-20 3:15 ` [PATCH v2] " Xiao Yang
2016-09-20 3:59 ` Eryu Guan
2016-09-20 4:40 ` Xiao Yang [this message]
2016-09-20 4:48 ` Darrick J. Wong
2016-09-20 5:23 ` [PATCH v3] " Xiao Yang
2016-09-20 5:55 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E0BDD3.5060907@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox